From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12AD2CD13CF for ; Mon, 2 Sep 2024 12:54:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86C8D8D00D8; Mon, 2 Sep 2024 08:54:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81BF08D0098; Mon, 2 Sep 2024 08:54:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E3998D00D8; Mon, 2 Sep 2024 08:54:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5438C8D0098 for ; Mon, 2 Sep 2024 08:54:06 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0A585C0822 for ; Mon, 2 Sep 2024 12:54:06 +0000 (UTC) X-FDA: 82519790892.12.868B762 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by imf06.hostedemail.com (Postfix) with ESMTP id D600F180008 for ; Mon, 2 Sep 2024 12:54:02 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=leemhuis.info header.s=he214686 header.b=r6R51Cth; dmarc=none; spf=pass (imf06.hostedemail.com: domain of regressions@leemhuis.info designates 80.237.130.52 as permitted sender) smtp.mailfrom=regressions@leemhuis.info ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725281574; a=rsa-sha256; cv=none; b=TmaHURLrPR+dnMTO6ASdD9pwjVd+fp6Ui7IXTHy2cphFe9kaqZLjhI4PnRhaduGYjLb5oo xoHUwGChIg59posPltyxCUAcYVDI/2NCVumrf+rDjjHWS/51oSUv1LIh9jTNy/+/Jwqzfl /LoK65Dd5ZEN/zfeSc2ah4kWUT+LcFg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=leemhuis.info header.s=he214686 header.b=r6R51Cth; dmarc=none; spf=pass (imf06.hostedemail.com: domain of regressions@leemhuis.info designates 80.237.130.52 as permitted sender) smtp.mailfrom=regressions@leemhuis.info ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725281574; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SSKrWHfr3RQQxlj73LfGosa+rJRjxqlAnWYQ+2sQHwM=; b=F2xS9XelE1tZbodTgV68YvWeYQDg+tl+7fcW3mA5px2ZM6gleNRDNOGPAFxlWbf3a8ER1A PO8QvVO+xMnYPRD83s/NOyynEwXXW2KTq0v9Pg/ulJLaal/Ds+r8IEmmUvO/lRMAB6lyFF BYRSaOZ1CBguJp1Bz8lH0Pw0czphvCk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=leemhuis.info; s=he214686; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: In-Reply-To:References; bh=SSKrWHfr3RQQxlj73LfGosa+rJRjxqlAnWYQ+2sQHwM=; t=1725281643; x=1725713643; b=r6R51Cthtd2OpU79wIqzE30jHqF3RntpO83RcxVvEuNn+iz zZB6TCUsk6/MO9ZX+2hSOnUq2i/KgJFf52ZpFeChax6xcpwV6Or991SQz8gdtgX0iliD4igslEYC0 mOr89VLY+tIz0GIhoMJPBtTaOZ5o0UaQGzbNOudSPH7Lh2+LCaaC3ny4o6N3c/9+g/38azA5WZZ6/ Wu1UBWaG1i+RbsDMkLoYW/zcewfTLcG6oQrNqwjlf0ViwdvBkg7f/sO8jbgCcx8EDW07udQlXeI/V TfjGVblDzZxcETq1y7z1xtJpkwJGsLpwkrKPYOfJcNbPHnMPrXpaQwMtuwlhO/0w==; Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1sl6ZA-0000Ot-MO; Mon, 02 Sep 2024 14:53:56 +0200 Message-ID: <56651be8-1466-475f-b1c5-4087995cc5ae@leemhuis.info> Date: Mon, 2 Sep 2024 14:53:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] mm/gup: Clear the LRU flag of a page before adding to LRU batch To: Chris Li , Kairui Song Cc: Ge Yang , Yu Zhao , Andrew Morton , linux-mm , LKML , stable@vger.kernel.org, Barry Song <21cnbao@gmail.com>, David Hildenbrand , baolin.wang@linux.alibaba.com, liuzixing@hygon.cn, Hugh Dickins , Linux kernel regressions list References: <1719038884-1903-1-git-send-email-yangge1116@126.com> <0f9f7a2e-23c3-43fe-b5c1-dab3a7b31c2d@126.com> <00a27e2b-0fc2-4980-bc4e-b383f15d3ad9@126.com> From: "Linux regression tracking (Thorsten Leemhuis)" Content-Language: en-US, de-DE Autocrypt: addr=linux@leemhuis.info; keydata= xsFNBFJ4AQ0BEADCz16x4kl/YGBegAsYXJMjFRi3QOr2YMmcNuu1fdsi3XnM+xMRaukWby47 JcsZYLDKRHTQ/Lalw9L1HI3NRwK+9ayjg31wFdekgsuPbu4x5RGDIfyNpd378Upa8SUmvHik apCnzsxPTEE4Z2KUxBIwTvg+snEjgZ03EIQEi5cKmnlaUynNqv3xaGstx5jMCEnR2X54rH8j QPvo2l5/79Po58f6DhxV2RrOrOjQIQcPZ6kUqwLi6EQOi92NS9Uy6jbZcrMqPIRqJZ/tTKIR OLWsEjNrc3PMcve+NmORiEgLFclN8kHbPl1tLo4M5jN9xmsa0OZv3M0katqW8kC1hzR7mhz+ Rv4MgnbkPDDO086HjQBlS6Zzo49fQB2JErs5nZ0mwkqlETu6emhxneAMcc67+ZtTeUj54K2y Iu8kk6ghaUAfgMqkdIzeSfhO8eURMhvwzSpsqhUs7pIj4u0TPN8OFAvxE/3adoUwMaB+/plk sNe9RsHHPV+7LGADZ6OzOWWftk34QLTVTcz02bGyxLNIkhY+vIJpZWX9UrfGdHSiyYThHCIy /dLz95b9EG+1tbCIyNynr9TjIOmtLOk7ssB3kL3XQGgmdQ+rJ3zckJUQapLKP2YfBi+8P1iP rKkYtbWk0u/FmCbxcBA31KqXQZoR4cd1PJ1PDCe7/DxeoYMVuwARAQABzSdUaG9yc3RlbiBM ZWVtaHVpcyA8bGludXhAbGVlbWh1aXMuaW5mbz7CwZQEEwEKAD4CGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AWIQSoq8a+lZZX4oPULXVytubvTFg9LQUCX31PIwUJFmtPkwAKCRBytubv TFg9LWsyD/4t3g4i2YVp8RoKAcOut0AZ7/uLSqlm8Jcbb+LeeuzjY9T3mQ4ZX8cybc1jRlsL JMYL8GD3a53/+bXCDdk2HhQKUwBJ9PUDbfWa2E/pnqeJeX6naLn1LtMJ78G9gPeG81dX5Yq+ g/2bLXyWefpejlaefaM0GviCt00kG4R/mJJpHPKIPxPbOPY2REzWPoHXJpi7vTOA2R8HrFg/ QJbnA25W55DzoxlRb/nGZYG4iQ+2Eplkweq3s3tN88MxzNpsxZp475RmzgcmQpUtKND7Pw+8 zTDPmEzkHcUChMEmrhgWc2OCuAu3/ezsw7RnWV0k9Pl5AGROaDqvARUtopQ3yEDAdV6eil2z TvbrokZQca2808v2rYO3TtvtRMtmW/M/yyR233G/JSNos4lODkCwd16GKjERYj+sJsW4/hoZ RQiJQBxjnYr+p26JEvghLE1BMnTK24i88Oo8v+AngR6JBxwH7wFuEIIuLCB9Aagb+TKsf+0c HbQaHZj+wSY5FwgKi6psJxvMxpRpLqPsgl+awFPHARktdPtMzSa+kWMhXC4rJahBC5eEjNmP i23DaFWm8BE9LNjdG8Yl5hl7Zx0mwtnQas7+z6XymGuhNXCOevXVEqm1E42fptYMNiANmrpA OKRF+BHOreakveezlpOz8OtUhsew9b/BsAHXBCEEOuuUg87BTQRSeAENARAAzu/3satWzly6 +Lqi5dTFS9+hKvFMtdRb/vW4o9CQsMqL2BJGoE4uXvy3cancvcyodzTXCUxbesNP779JqeHy s7WkF2mtLVX2lnyXSUBm/ONwasuK7KLz8qusseUssvjJPDdw8mRLAWvjcsYsZ0qgIU6kBbvY ckUWkbJj/0kuQCmmulRMcaQRrRYrk7ZdUOjaYmjKR+UJHljxLgeregyiXulRJxCphP5migoy ioa1eset8iF9fhb+YWY16X1I3TnucVCiXixzxwn3uwiVGg28n+vdfZ5lackCOj6iK4+lfzld z4NfIXK+8/R1wD9yOj1rr3OsjDqOaugoMxgEFOiwhQDiJlRKVaDbfmC1G5N1YfQIn90znEYc M7+Sp8Rc5RUgN5yfuwyicifIJQCtiWgjF8ttcIEuKg0TmGb6HQHAtGaBXKyXGQulD1CmBHIW zg7bGge5R66hdbq1BiMX5Qdk/o3Sr2OLCrxWhqMdreJFLzboEc0S13BCxVglnPqdv5sd7veb 0az5LGS6zyVTdTbuPUu4C1ZbstPbuCBwSwe3ERpvpmdIzHtIK4G9iGIR3Seo0oWOzQvkFn8m 2k6H2/Delz9IcHEefSe5u0GjIA18bZEt7R2k8CMZ84vpyWOchgwXK2DNXAOzq4zwV8W4TiYi FiIVXfSj185vCpuE7j0ugp0AEQEAAcLBfAQYAQoAJgIbDBYhBKirxr6Vllfig9QtdXK25u9M WD0tBQJffU8wBQkWa0+jAAoJEHK25u9MWD0tv+0P/A47x8r+hekpuF2KvPpGi3M6rFpdPfeO RpIGkjQWk5M+oF0YH3vtb0+92J7LKfJwv7GIy2PZO2svVnIeCOvXzEM/7G1n5zmNMYGZkSyf x9dnNCjNl10CmuTYud7zsd3cXDku0T+Ow5Dhnk6l4bbJSYzFEbz3B8zMZGrs9EhqNzTLTZ8S Mznmtkxcbb3f/o5SW9NhH60mQ23bB3bBbX1wUQAmMjaDQ/Nt5oHWHN0/6wLyF4lStBGCKN9a TLp6E3100BuTCUCrQf9F3kB7BC92VHvobqYmvLTCTcbxFS4JNuT+ZyV+xR5JiV+2g2HwhxWW uC88BtriqL4atyvtuybQT+56IiiU2gszQ+oxR/1Aq+VZHdUeC6lijFiQblqV6EjenJu+pR9A 7EElGPPmYdO1WQbBrmuOrFuO6wQrbo0TbUiaxYWyoM9cA7v7eFyaxgwXBSWKbo/bcAAViqLW ysaCIZqWxrlhHWWmJMvowVMkB92uPVkxs5IMhSxHS4c2PfZ6D5kvrs3URvIc6zyOrgIaHNzR 8AF4PXWPAuZu1oaG/XKwzMqN/Y/AoxWrCFZNHE27E1RrMhDgmyzIzWQTffJsVPDMQqDfLBhV ic3b8Yec+Kn+ExIF5IuLfHkUgIUs83kDGGbV+wM8NtlGmCXmatyavUwNCXMsuI24HPl7gV2h n7RI Reply-To: Linux regressions mailing list In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1725281643;0b4b1b97; X-HE-SMSGID: 1sl6ZA-0000Ot-MO X-Rspamd-Queue-Id: D600F180008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 956fc5yfmc1ts4qzna8ujy9q4tw4pxo1 X-HE-Tag: 1725281642-800829 X-HE-Meta: U2FsdGVkX18XzgnF5GNvtSpgzlU2VNRo2bAGhq1hSox58r7NErnhq6NKHYB30t4vY+DKB/iYYw5nSapqAxJpAU/Xy1mu2uqC8qakIB53p6DtOZk7OHc34MBCyrDBSkT6Drtlm4PO8A9kP2NpxoyZPiMV7AGt+NZddrLO7FV9vUFJc5D2B3U7mkwZamEDHH0CxY8iPT8fpX/aSwMoV+1sU5vCdh7MBZjiIW625WzxLgEEwUkrIKsqU1G5wwbM4IWL2DJyz2NcBuV5v+Ax0F1fAuaCwCUbApu2PV4piigZuQNjUNEWdmLfHAqyfPxqUnT104LC3PKN4ePzDdV9mjt9zVUkY6n/ssUGdoKIuE2TB5Con5IPNEappVkkrkLpmJ6akD/oTIw5b22kklneXc4GgQyDkSuUCrLTs8tgWKpH74mgVO69Dis9MP8dYB8laQO+IB/V/AjuHJ4OiG2+Gacg/xi2ZlGg4baIx0BBjJ3ptfTC86r9c121kgt+pBHikl6h4JKMeGBigvLKCZTJcRu1ReUSrzKdracvqb4zzQKqn1lwh1P6pf/htSXziWUC1zfwI2NUVLT6S6GU3NwDOGowvV7/Zrruw4S+4NIINRQE3wpHRDCaUHOUu3YCpQv67fRkmPeCNRlsNR9gNOfddkPZTynAcrjz3Y+hTTzURtV/VVRalItIz5sT5TjOvWTWLGsQ7yh2ZZp87PveuGTmFw2KJOFKHDVqGLD/g6PkKwoJU9xl2lLWPke8RCXiYlrdGpw7u1W21fDQEYu8pTnLDHo54smACghyPMgKuUHMrNeOBNQq6A8Qysae8rAdJN8f4Aq8siE8VMMpc1faZ5iAPfITcG6lolkVlQ7iFl3B7Heso71PsbUtOZ8ml1KSrf6aA/Rk+8F/cGPupL7Flc0I9KM58xgIY8Ww3tv3y/3dOjFHyH5VqPjkTF8Bqgtg6uONPrV7mgU99JNzGkI/FhXndPg rLUpv89W B7bBGIi2oBYg1LMfSv5gqKSxYKsykTW7sQkVg9mValY3aJGNbq3WCYhg3hO5b8xaslSsAUvuPMtFm1mOI9uVvdn/qoqaHi8Fw2vN1orvb+w4dlJBCtpZ21Io60SeH+xnwudC8qBur6VGqf4aMRGhk10yXvX0SixT+lB9HiYz5CzbzaLI0W7bF6hJCU8YaHvoHJJcFkFvgR7O6tEfPFGUPKav1pjeqUkr8EdQm2mCSKBQTLBHXegdjpsOLkqUsJs1C/Sa7Wr3/2eHJJxcItzmnkcB4it8SmKtFaoFMngyW2Tgr+AZoW115xf0OTH1xnhH1kayPZetMHOFmhsKutySsiLXCI1tmml+FhH9lMiR1bUmRaFp19NDt00v0NFXl2/lj5nknzZHZ9IPLYM5mZ0sye01IAI48VrA9TskJtGWldijXLTL7PvIDga+j0DaG02QQEeCv4LRXyHouj8GVdx/ljf0Sxd6kKmDjpBUhV6Jjo8ZvTkmESANG/j922BNace4TVJhylIGlO7XAZpGN2ds8prRsbi0zElZDI9/TzdreWw8HGp2NriyZiEVAoKddiMmpokvKfM9aZ+nKV4tLtj6C8h3e5EMn1JpmUp7Iq57811eOlblGffRrIPb1OS9+OcwJk9c/1McRlhSDr44= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone. Chris et. al., was that fix from Yu ever submitted? From here it looks like fixing this regression fell through the cracks; but at the same time I have this strange feeling that I'm missing something obvious here and will look stupid by writing this mail... If that's the case: sorry for the noise. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) On 04.08.24 21:11, Chris Li wrote: > On Sun, Aug 4, 2024 at 10:51 AM Chris Li wrote: >> On Sun, Aug 4, 2024 at 5:22 AM Kairui Song wrote: > >>>> Hi Yu, I tested your patch, on my system, the OOM still exists (96 >>>> core and 256G RAM), test memcg is limited to 512M and 32 thread (). >>>> >>>> And I found the OOM seems irrelevant to either your patch or Ge's >>>> patch. (it may changed the OOM chance slight though) >>>> >>>> After the very quick OOM (it failed to untar the linux source code), >>>> checking lru_gen_full: >>>> memcg 47 /build-kernel-tmpfs >>>> node 0 >>>> 442 1691 29405 0 >>>> 0 0r 0e 0p 57r >>>> 617e 0p >>>> 1 0r 0e 0p 0r >>>> 4e 0p >>>> 2 0r 0e 0p 0r >>>> 0e 0p >>>> 3 0r 0e 0p 0r >>>> 0e 0p >>>> 0 0 0 0 >>>> 0 0 >>>> 443 1683 57748 832 >>>> 0 0 0 0 0 >>>> 0 0 >>>> 1 0 0 0 0 >>>> 0 0 >>>> 2 0 0 0 0 >>>> 0 0 >>>> 3 0 0 0 0 >>>> 0 0 >>>> 0 0 0 0 >>>> 0 0 >>>> 444 1670 30207 133 >>>> 0 0 0 0 0 >>>> 0 0 >>>> 1 0 0 0 0 >>>> 0 0 >>>> 2 0 0 0 0 >>>> 0 0 >>>> 3 0 0 0 0 >>>> 0 0 >>>> 0 0 0 0 >>>> 0 0 >>>> 445 1662 0 0 >>>> 0 0R 34T 0 57R >>>> 238T 0 >>>> 1 0R 0T 0 0R >>>> 0T 0 >>>> 2 0R 0T 0 0R >>>> 0T 0 >>>> 3 0R 0T 0 0R >>>> 81T 0 >>>> 13807L 324O 867Y 2538N >>>> 63F 18A >>>> >>>> If I repeat the test many times, it may succeed by chance, but the >>>> untar process is very slow and generates about 7000 generations. >>>> >>>> But if I change the untar cmdline to: >>>> python -c "import sys; sys.stdout.buffer.write(open('$linux_src', >>>> mode='rb').read())" | tar zx >>>> >>>> Then the problem is gone, it can untar the file successfully and very fast. >>>> >>>> This might be a different issue reported by Chris, I'm not sure. >>> >>> After more testing, I think these are two problems (note I changed the >>> memcg limit to 600m later so the compile test can run smoothly). >>> >>> 1. OOM during the untar progress (can be workarounded by the untar >>> cmdline I mentioned above). >> >> There are two different issues here. >> My recent test script has moved the untar phase out of memcg limit >> (mostly I want to multithreading untar) so the bisect I did is only >> catch the second one. >> The untar issue might not be a regression from this patch. >> >>> 2. OOM during the compile progress (this should be the one Chris encountered). >>> >>> Both 1 and 2 only exist for MGLRU. >>> 1 can be workarounded using the cmdline I mentioned above. >>> 2 is caused by Ge's patch, and 1 is not. >>> >>> I can confirm Yu's patch fixed 2 on my system, but the 1 seems still a >>> problem, it's not related to this patch, maybe can be discussed >>> elsewhere. >> >> I will do a test run now with Yu's patch and report back. > > Confirm Yu's patch fixes the regression for me. Now it can sustain > 470M pressure without causing OOM kill. > > Yu, please submit your patch. This regression has merged into Linus' > tree already. > > Feel free to add: > > Tested-by: Chris Li > > Chris > -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page. #regzbot poke