From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DB0C369A8 for ; Wed, 25 Sep 2024 08:37:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADF186B0083; Wed, 25 Sep 2024 04:37:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A67786B0085; Wed, 25 Sep 2024 04:37:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 907EF6B0088; Wed, 25 Sep 2024 04:37:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 669A46B0083 for ; Wed, 25 Sep 2024 04:37:49 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EECE61A09E4 for ; Wed, 25 Sep 2024 08:37:48 +0000 (UTC) X-FDA: 82602607416.15.87221B8 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf07.hostedemail.com (Postfix) with ESMTP id 0E3574000E for ; Wed, 25 Sep 2024 08:37:42 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727253344; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fw8NQhuBYmgurW6KOWgg/YphXM3J6Yfft+yHRfy9Eo0=; b=f/iqaJsnVl2wpeEagFIabhMDe64lA2xEx2jxqfiPzOn9dNngIbRkoNhwR/Xp3zNtM08MCB r6tdbZ80Zcb0/a/Abv0I+9tjYaNanf2apcL7XNnQfiOs538yJL1H3b+Imxquxq0RgBZU0z T79JH0f+BT7SfIYLAmvm2Kdnjou9+ls= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727253344; a=rsa-sha256; cv=none; b=1ljzv6f4+JEayZtdPXgBaoZO4M29RAnCCL8Uu8naesMTdtSE9zG3TiOUdRcGajLjqLbkFb +YUu/7H0uBGmwEMXNOWPYCmlxph18g2U+uZSEFgkfY1UrnprixXc0HrwFBs+jMac2ndGTT 8kYAFSpUq9wM0RPMf0ZPu1XRjAdBLsM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn; dmarc=none X-UUID: 5eac7b4e7b1911efa216b1d71e6e1362-20240925 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.38,REQID:94188f28-3202-418b-8f0c-6070742375e2,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:82c5f88,CLOUDID:a046b15fc850bccb80cba159b71a5529,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0|-5,EDM:-3,IP:nil,UR L:1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,S PR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: 5eac7b4e7b1911efa216b1d71e6e1362-20240925 Received: from node2.com.cn [(10.44.16.197)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 256147864; Wed, 25 Sep 2024 16:37:16 +0800 Received: from node2.com.cn (localhost [127.0.0.1]) by node2.com.cn (NSMail) with SMTP id 49FAAB803C9B; Wed, 25 Sep 2024 16:37:16 +0800 (CST) X-ns-mid: postfix-66F3CBBC-266130561 Received: from [172.30.70.73] (unknown [172.30.70.73]) by node2.com.cn (NSMail) with ESMTPA id 6D5FDB803C9B; Wed, 25 Sep 2024 08:37:14 +0000 (UTC) Subject: Re: [PATCH] mm/vmscan: Fix hard LOCKUP in function isolate_lru_folios To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240814091825.27262-1-liuye@kylinos.cn> <20240924172205.5068e86430873b09b75f8538@linux-foundation.org> From: liuye Message-ID: <565bae19-889e-57df-42ff-70728cfb818c@kylinos.cn> Date: Wed, 25 Sep 2024 16:37:14 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20240924172205.5068e86430873b09b75f8538@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Stat-Signature: aqnt4qo6ko4gk499g9637og8sp1t5iof X-Rspamd-Queue-Id: 0E3574000E X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727253462-966990 X-HE-Meta: U2FsdGVkX183h724PcASOSOJqnbnCrcEd6Wo3LC/cgn2vfkD1hQHaTrGLDO/imCmOJXAdin/GiVSNCeeFNAfMWuP3IPxHOe1ZSb/6pwhSGIjKUJKrMQeuTgWvW/uWhcd3S5X7MnsT9Nx2t/wGGMoYTM7RncdypkrZOysRHgDhUl5cGfF/B3AyxYQooN+lQNDbx+4/0kQcCHF48KMYc7GrljTtIyKhJOaZY7k/w2FofzxcOJ51G/z2Ccy8Mu0bVMwqy9z+9VSq5OqTR6UHAnPmbjpFkodOC1P0pCnxg+otgE/6spCzkKtD9IUqWHtwvbSBpJ+QvNqfhT0bvnynp/0+n7AUxliguqlEdA4BwJTOgjkoEa+MHdplOgzLODQEKhLAd2hSasexisd2YsdeEIxvCXkC6mKVc0/Hr0/BxvvnA+jgoOdI0qQBWxudF1t2hoTWPgkbWtjlHoe/CM3J12PhRb6jgb/LPwqWr4plN3Tact8UtnvtRYRhOFMJupmNFwZWqT+XxLijlUaKRDqIB4zDV81cAYt51j9ywBv1JZaZqo/mUi2QkrAAw68wSgf4ClRQyeoHahGQmXspC2as5MTJRcZfmMZg5FHU/VkilKx4PwuOpqoPJ84r7nVztdUe91UAXXDKLUZb4qb7fXRV6i0QN+RSpdjnchQny11jMJGn3iB0HqKt2TAr9oTkk+xG2bC2HwYYYBu7GPU33ohLccFKMe0Up5u5v9oMW/8lYJN5BQxIHwchK5LjMTS2hjOo+HeeckSk/YcfozvtMXxHIvYoJOFL1kjfmyfHbUy87iKumdSBK4OoQbo0RtjJLihHDYPP4qbWajwsJ0NEjiNzLJaCDU97DLCCyQcC3Hwby0WKaWecVfeyyrQtNRgo1f5GiWPDoygneOu6cDRztgmHWJO2SCtxe2m1t77LsYJmYeLvkP6kZr4Ttb7vCe1ScHbV0sbEWm5rv8x+K1MNOzwuJN XZHXEwNB njcHrCuKt0qrA0V3ar0Gg7CjdbnC2n/jc9GMLw9norhFgL0M1b2d6FiqT3qyXEFInaJ8b02seV/vcvgFkEWSHAG8+PQCzxpaAYz5iYCfAe1EXRb26GUpfux8hPGZHLHswx9nZb9Ljy0W0xlOMJd2yZf+AS27AVQc07YUB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/25 =E4=B8=8A=E5=8D=888:22, Andrew Morton wrote: > On Wed, 14 Aug 2024 17:18:25 +0800 liuye wrote: >=20 >> @@ -1669,10 +1670,12 @@ static unsigned long isolate_lru_folios(unsign= ed long nr_to_scan, >> nr_pages =3D folio_nr_pages(folio); >> total_scan +=3D nr_pages; >> =20 >> - if (folio_zonenum(folio) > sc->reclaim_idx || >> - skip_cma(folio, sc)) { >> + /* Using max_nr_skipped to prevent hard LOCKUP*/ >> + if ((max_nr_skipped < SWAP_CLUSTER_MAX_SKIPPED) && >> + (folio_zonenum(folio) > sc->reclaim_idx || skip_cma(folio, sc))) { >> nr_skipped[folio_zonenum(folio)] +=3D nr_pages; >> move_to =3D &folios_skipped; >> + max_nr_skipped++; >> goto move; >=20 > This hunk is not applicable to current mainline. >=20 Please see the PATCH v2 in link [1], and the related discussion in link [= 2]. Then please explain why it is not applicable,thank you. [1]:https://lore.kernel.org/all/20240919021443.9170-1-liuye@kylinos.cn/ [2]:https://lore.kernel.org/all/e878653e-d380-81c2-90a8-fd2d1d4e7287@kyli= nos.cn/ Thanks, liuye