From: liuye <liuye@kylinos.cn>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmscan: Fix hard LOCKUP in function isolate_lru_folios
Date: Wed, 25 Sep 2024 16:37:14 +0800 [thread overview]
Message-ID: <565bae19-889e-57df-42ff-70728cfb818c@kylinos.cn> (raw)
In-Reply-To: <20240924172205.5068e86430873b09b75f8538@linux-foundation.org>
On 2024/9/25 上午8:22, Andrew Morton wrote:
> On Wed, 14 Aug 2024 17:18:25 +0800 liuye <liuye@kylinos.cn> wrote:
>
>> @@ -1669,10 +1670,12 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan,
>> nr_pages = folio_nr_pages(folio);
>> total_scan += nr_pages;
>>
>> - if (folio_zonenum(folio) > sc->reclaim_idx ||
>> - skip_cma(folio, sc)) {
>> + /* Using max_nr_skipped to prevent hard LOCKUP*/
>> + if ((max_nr_skipped < SWAP_CLUSTER_MAX_SKIPPED) &&
>> + (folio_zonenum(folio) > sc->reclaim_idx || skip_cma(folio, sc))) {
>> nr_skipped[folio_zonenum(folio)] += nr_pages;
>> move_to = &folios_skipped;
>> + max_nr_skipped++;
>> goto move;
>
> This hunk is not applicable to current mainline.
>
Please see the PATCH v2 in link [1], and the related discussion in link [2].
Then please explain why it is not applicable,thank you.
[1]:https://lore.kernel.org/all/20240919021443.9170-1-liuye@kylinos.cn/
[2]:https://lore.kernel.org/all/e878653e-d380-81c2-90a8-fd2d1d4e7287@kylinos.cn/
Thanks,
liuye
next prev parent reply other threads:[~2024-09-25 8:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 9:18 liuye
2024-08-14 21:27 ` Andrew Morton
2024-09-19 2:14 ` [PATCH v2] " liuye
2024-09-20 6:31 ` Bharata B Rao
[not found] ` <1727070383769353.48.seg@mailgw.kylinos.cn>
2024-09-23 6:03 ` liuye
2024-11-19 6:08 ` [PATCH v2 RESEND] " liuye
2024-11-30 3:22 ` Andrew Morton
2024-12-05 3:55 ` Hugh Dickins
[not found] ` <1733382994392357.312.seg@mailgw.kylinos.cn>
2024-12-11 7:26 ` liuye
2024-09-25 0:22 ` [PATCH] " Andrew Morton
2024-09-25 8:37 ` liuye [this message]
2024-09-25 9:29 ` Andrew Morton
2024-09-25 9:53 ` liuye
[not found] <20240815025226.8973-1-liuye@kylinos.cn>
2024-08-23 2:04 ` Re: " liuye
2024-09-03 2:34 ` liuye
2024-09-03 3:03 ` liuye
2024-09-06 1:16 ` liuye
2024-09-11 2:56 ` liuye
2024-12-05 19:17 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565bae19-889e-57df-42ff-70728cfb818c@kylinos.cn \
--to=liuye@kylinos.cn \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox