From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D456BC54798 for ; Fri, 23 Feb 2024 15:27:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 525E96B0071; Fri, 23 Feb 2024 10:27:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D5AE6B0072; Fri, 23 Feb 2024 10:27:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39D336B0074; Fri, 23 Feb 2024 10:27:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 281646B0071 for ; Fri, 23 Feb 2024 10:27:13 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C8E071A119F for ; Fri, 23 Feb 2024 15:27:12 +0000 (UTC) X-FDA: 81823447104.28.E59FE9B Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by imf22.hostedemail.com (Postfix) with ESMTP id 9E111C001A for ; Fri, 23 Feb 2024 15:27:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708702031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CmRay/SrcRhaNusd6GjC+c9qhj+nDynezdxu3T/kwmw=; b=QuqgJXrTy8KILuyBgEdVtVgwHWQk9MdItD0rmKsliT1Uy9O8odd23o8WZMLV3VoHo/TM4K B2NqDDxwtONPHflbSX9Z+Ouxw1EivCEVnwrg4tt0xDrekeplhVOr6RPjA1cq0JzlFN6496 gsGHQfceFpciNbjINR/nfgY5CdpAYlc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708702031; a=rsa-sha256; cv=none; b=VifEBsR4cCZ8wxWp0Lmv7S7VaD1ZT/MVA7QyY64xGNorM8EgjqZE85+pSjV0qYTRhYbKkg 9eM7hUiQSxUcEPatapIySdujZUEopiKl/PtxFUGSPNieYCE9wPQwEuXJ6Va6Tlcg+07Ko9 pMPJK+IQNG/RzPax7lN0i5CY3QKsoPQ= Received: from fsav415.sakura.ne.jp (fsav415.sakura.ne.jp [133.242.250.114]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 41NFQieM066165; Sat, 24 Feb 2024 00:26:44 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav415.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav415.sakura.ne.jp); Sat, 24 Feb 2024 00:26:44 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav415.sakura.ne.jp) Received: from [192.168.1.6] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 41NFQhOx066161 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Sat, 24 Feb 2024 00:26:43 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Message-ID: <564df866-e874-400e-aff3-54d75295187b@I-love.SAKURA.ne.jp> Date: Sat, 24 Feb 2024 00:26:41 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/17] mm: Add folio_end_read() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, torvalds@linux-foundation.org, npiggin@gmail.com References: <20231004165317.1061855-1-willy@infradead.org> <20231004165317.1061855-4-willy@infradead.org> From: Tetsuo Handa In-Reply-To: <20231004165317.1061855-4-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9E111C001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: my85b5erkmrs776rfaxwh3fm58saaag6 X-HE-Tag: 1708702030-632907 X-HE-Meta: U2FsdGVkX1/hjPQ+EuF6QXSva+vVpaG+shH2u1sllJup599DA5iVkxszzDPssaznSw2RvxcMhyYOVipcAENhKsGiCHpyEy8McpzM+sXBF/QZGiYG7E7oR6neQMG3KU0fBcdI9wakBXbN286MkVSJlgydo+s6LE29Mbcn0aifq1+OF1QMNcEgoR72+/RqzGFmdGRqUTGVWLf+bzTz8NSLwKBvphWYbxRndkBP1wdTfjaK74RZKxUqNkcT6ScYxmXin2Wo+VCzyZuQ37hG2e5WIdeZF/TMd7/BTPNajqJCx2Ywu4PgmBblYsmDvmY+e4hE+WIu0ZFOL1/QhVWmDUpzeGX6OqMHyFVX5bWd2Vxnt8IrQ7adWZxWSNvmRBgj1L74Vb+/eQ2jTJhFP0KMHX5TJ/RI/o0/Fqr949hPe1iZrBIR5TSFoIXozxBgXc5RmX2O/RdxoWWZNkjPcJLG4kLpegkeCQfFq+nABanMrfic7ENsu6FrLmyEaCY2mb6L3Ygr4OVpfHmzl1vkvDr0EPvjnvK+JRcCaYpQVFGdu4+h36KkvHB3+eytGzG2AcFMJk3Wxf84I+FAxTcrxmFIZHdXqEP0zd8IM61K89pqF/JghFHQURqHHGt+QVS510yXPOeu+Kgs6m+TBz0i5I8e/ZannYZ0HnmeTKrbHJItZilOBOtReeP9I5r5geO4VMMOe+aDCPuiPqHQsJbcoItAzI5uzbgY1pGBfzVwpXmDu5kMBIwXWgBqEia7hLMwgm6/jORKhIMnrFT66kGsBXbxnkSi7QZxyB8BgzZ5LLZnECBmHDifA/9xJ/loylot+PwaP3FiZrsH4c6pvi39jLW2EGX4aS+k+f5X7a6hv5yH7geMmKZ6Esln3Q1WPOtM2BUGXJLKvCCdo7uryXIU0BS3H1KSVzSLe3Uvw09eepRA8u9KQsY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: During a bisection of a different problem, I noticed that commit 0b237047d5a7 ("mm: add folio_end_read()") added folio_end_read() as ---------------------------------------- +void folio_end_read(struct folio *folio, bool success) +{ + if (likely(success)) + folio_mark_uptodate(folio); + folio_unlock(folio); +} ---------------------------------------- but commit f8174a118122 ("ext4: use folio_end_read()") for unknown reason removed folio_clear_uptodate() call when bio->bi_status != 0. ---------------------------------------- - bio_for_each_folio_all(fi, bio) { - struct folio *folio = fi.folio; - - if (bio->bi_status) - folio_clear_uptodate(folio); - else - folio_mark_uptodate(folio); - folio_unlock(folio); - } + bio_for_each_folio_all(fi, bio) + folio_end_read(fi.folio, bio->bi_status == 0); ---------------------------------------- Why else folio_clear_uptodate(folio); part is missing in folio_end_read() ?