From: Song Liu <songliubraving@fb.com>
To: William Kucharski <william.kucharski@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
"namit@vmware.com" <namit@vmware.com>,
Peter Zijlstra <peterz@infradead.org>,
"oleg@redhat.com" <oleg@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
Matthew Wilcox <matthew.wilcox@oracle.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
Kernel Team <Kernel-team@fb.com>,
"Chad Mynhier" <chad.mynhier@oracle.com>,
"mike.kravetz@oracle.com" <mike.kravetz@oracle.com>
Subject: Re: [PATCH uprobe, thp 3/4] uprobe: support huge page by only splitting the pmd
Date: Thu, 30 May 2019 17:24:42 +0000 [thread overview]
Message-ID: <564E2603-C77C-408A-9E51-B20266407360@fb.com> (raw)
In-Reply-To: <6D76CB61-CF13-4610-A883-0C25ECC5CFB7@oracle.com>
> On May 30, 2019, at 4:08 AM, William Kucharski <william.kucharski@oracle.com> wrote:
>
>
> Is there any reason to worry about supporting PUD-sized uprobe pages if
> CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD is defined? I would prefer
> not to bake in the assumption that "huge" means PMD-sized and more than
> it already is.
>
> For example, if CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD is configured,
> mm_address_trans_huge() should either make the call to pud_trans_huge()
> if appropriate, or a VM_BUG_ON_PAGE should be added in case the routine
> is ever called with one.
>
> Otherwise it looks pretty reasonable to me.
>
> -- Bill
>
I will try that in v2.
Thanks,
Song
next prev parent reply other threads:[~2019-05-30 17:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 21:20 [PATCH uprobe, thp 0/4] THP aware uprobe Song Liu
2019-05-29 21:20 ` [PATCH uprobe, thp 1/4] mm, thp: allow preallocate pgtable for split_huge_pmd_address() Song Liu
2019-05-30 11:10 ` Kirill A. Shutemov
2019-05-30 11:14 ` Kirill A. Shutemov
2019-05-30 17:23 ` Song Liu
2019-05-29 21:20 ` [PATCH uprobe, thp 2/4] uprobe: use original page when all uprobes are removed Song Liu
2019-05-30 11:17 ` Kirill A. Shutemov
2019-05-30 17:18 ` Song Liu
2019-05-29 21:20 ` [PATCH uprobe, thp 3/4] uprobe: support huge page by only splitting the pmd Song Liu
2019-05-30 11:08 ` William Kucharski
2019-05-30 17:24 ` Song Liu [this message]
2019-05-30 12:14 ` Kirill A. Shutemov
2019-05-30 17:37 ` Song Liu
2019-05-29 21:20 ` [PATCH uprobe, thp 4/4] uprobe: collapse THP pmd after removing all uprobes Song Liu
2019-05-30 12:20 ` Kirill A. Shutemov
2019-05-30 17:26 ` Song Liu
2019-05-31 7:00 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564E2603-C77C-408A-9E51-B20266407360@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=chad.mynhier@oracle.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=mhiramat@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=namit@vmware.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox