From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by kanga.kvack.org (Postfix) with ESMTP id 419096B0254 for ; Fri, 13 Nov 2015 20:02:54 -0500 (EST) Received: by pacdm15 with SMTP id dm15so115400008pac.3 for ; Fri, 13 Nov 2015 17:02:54 -0800 (PST) Received: from mga02.intel.com (mga02.intel.com. [134.134.136.20]) by mx.google.com with ESMTP id xm9si30898664pbc.199.2015.11.13.17.02.53 for ; Fri, 13 Nov 2015 17:02:53 -0800 (PST) Subject: Re: [PATCH v2 02/11] mm: add pmd_mkclean() References: <1447459610-14259-1-git-send-email-ross.zwisler@linux.intel.com> <1447459610-14259-3-git-send-email-ross.zwisler@linux.intel.com> From: Dave Hansen Message-ID: <56468838.6010506@intel.com> Date: Fri, 13 Nov 2015 17:02:48 -0800 MIME-Version: 1.0 In-Reply-To: <1447459610-14259-3-git-send-email-ross.zwisler@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Ross Zwisler , linux-kernel@vger.kernel.org Cc: "H. Peter Anvin" , "J. Bruce Fields" , Theodore Ts'o , Alexander Viro , Andreas Dilger , Dan Williams , Dave Chinner , Ingo Molnar , Jan Kara , Jeff Layton , Matthew Wilcox , Thomas Gleixner , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, x86@kernel.org, xfs@oss.sgi.com, Andrew Morton , Matthew Wilcox On 11/13/2015 04:06 PM, Ross Zwisler wrote: > +static inline pmd_t pmd_mkclean(pmd_t pmd) > +{ > + return pmd_clear_flags(pmd, _PAGE_DIRTY | _PAGE_SOFT_DIRTY); > +} pte_mkclean() doesn't clear _PAGE_SOFT_DIRTY. What the thought behind doing it here? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org