On 09/17/2015 02:24 PM, Toshi Kani wrote: > Now that we have pud/pmd mask interfaces, which handle pfn & flags > mask properly for the large PAT bit. > > Fix pud/pmd pfn & flags interfaces by replacing PTE_PFN_MASK and > PTE_FLAGS_MASK with the pud/pmd mask interfaces. > > Suggested-by: Juergen Gross > Signed-off-by: Toshi Kani > Cc: Juergen Gross > Cc: Konrad Wilk > Cc: Thomas Gleixner > Cc: H. Peter Anvin > Cc: Ingo Molnar > Cc: Borislav Petkov > --- > arch/x86/include/asm/pgtable.h | 14 ++++++++------ > arch/x86/include/asm/pgtable_types.h | 4 ++-- > 2 files changed, 10 insertions(+), 8 deletions(-) > Looks like this commit is causing this splat for 32-bit kernels. I am attaching my config file, just in case. -boris [ 8.905943] page:eea45000 count:0 mapcount:-128 mapping: (null) index:0x0 [ 8.913041] flags: 0x40000000() [ 8.916293] page dumped because: VM_BUG_ON_PAGE(page_mapcount(page) < 0) [ 8.923204] ------------[ cut here ]------------ [ 8.927958] kernel BUG at /home/build/linux-boris/mm/huge_memory.c:1485! [ 8.934860] invalid opcode: 0000 [#1] SMP [ 8.939094] Modules linked in: ahci libahci ata_generic skge r8169 firewire_ohci mii libata qla2xxx(+) scsi_transport_fc scsi_mod radeon tpm_infineon ttm backlight wmi acpi_cpufreq tpm_tis [ 8.956548] CPU: 2 PID: 1758 Comm: modprobe Not tainted 4.3.0upstream-09269-gce5c2d2 #1 [ 8.964792] Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./To be filled by O.E.M., BIOS 080014 07/18/2008 [ 8.975991] task: ed84e600 ti: f6458000 task.ti: f6458000 [ 8.981552] EIP: 0060:[] EFLAGS: 00010246 CPU: 2 [ 8.987203] EIP is at zap_huge_pmd+0x240/0x260 [ 8.991778] EAX: 00000000 EBX: f6459eb0 ECX: 00000292 EDX: 00000292 [ 8.998234] ESI: f6634d98 EDI: eea45000 EBP: f6459dc8 ESP: f6459d98 [ 8.998355] ata1: SATA link down (SStatus 0 SControl 300) [ 9.000330] ata2: SATA link down (SStatus 0 SControl 300) [ 9.015804] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 [ 9.021364] CR0: 8005003b CR2: b75b21a0 CR3: 3655b880 CR4: 000006f0 [ 9.027818] Stack: [ 9.029885] 00000080 00000000 80000002 ee795000 80000002 ffe00000 00000000 ffffff7f [ 9.037930] eee6169c f70c5e40 b6600000 f6634d98 f6459e78 c119a7c8 b6600000 80000002 [ 9.045972] 00000003 c18992f4 c18992f0 00000003 00000286 f6459e0c c10db5f0 00000000 [ 9.054018] Call Trace: [ 9.056537] [] unmap_single_vma+0x6e8/0x7c0 [ 9.061829] [] ? __wake_up+0x40/0x50 [ 9.063587] firewire_core 0000:08:05.0: created device fw0: GUID 000000001a1a2f03, S800 [ 9.074736] [] unmap_vmas+0x47/0x80 [ 9.079312] [] unmap_region+0x74/0xc0 [ 9.084067] [] do_munmap+0x1b0/0x280 [ 9.088732] [] vm_munmap+0x38/0x50 [ 9.093218] [] SyS_munmap+0x18/0x20 [ 9.097795] [] do_fast_syscall_32+0xa1/0x270 [ 9.103176] [] ? __do_page_fault+0x430/0x430 [ 9.108559] [] sysenter_past_esp+0x36/0x55 [ 9.113761] Code: 00 e9 05 fe ff ff 90 8d 74 26 00 0f 0b eb fe ba 4c e1 7a c1 89 f8 e8 f0 91 fd ff 0f 0b eb fe ba 6c e1 7a c1 89 f8 e8 e0 91 fd ff <0f> 0b eb fe ba c4 e1 7a c1 89 f8 e8 d0 91 fd ff 0f 0b eb fe 8d [ 9.133727] EIP: [] zap_huge_pmd+0x240/0x260 SS:ESP 0068:f6459d98 [ 9.140929] ---[ end trace cba8fb1fc2e2e78a ]--- [ 9.143363] scsi host5: qla2xxx [ 9.148416] qla2xxx [0000:04:07.1]-00fb:5: QLogic QLE2362 - PCI-Express to 2Gb FC, Dual Channel. [ 9.148420] qla2xxx [0000:04:07.1]-00fc:5: ISP2322: PCI-X (133 MHz) @ 0000:04:07.1 hdma+ host#=5 fw=3.03.28 IPX. [ 9.152282] ata4: softreset failed (device not ready) [ 9.152284] ata4: applying PMP SRST workaround and retrying [ 9.153282] ata3: softreset failed (device not ready) [ 9.153284] ata3: applying PMP SRST workaround and retrying [ 9.190361] Kernel panic - not syncing: Fatal exception [ 9.195764] Kernel Offset: disabled [ 9.199354] ---[ end Kernel panic - not syncing: Fatal exception