From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E467C3DA59 for ; Mon, 15 Jul 2024 12:34:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 164366B007B; Mon, 15 Jul 2024 08:34:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 113A26B0083; Mon, 15 Jul 2024 08:34:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1CEB6B0085; Mon, 15 Jul 2024 08:34:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D49466B007B for ; Mon, 15 Jul 2024 08:34:53 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1F40E1A15F2 for ; Mon, 15 Jul 2024 12:34:53 +0000 (UTC) X-FDA: 82341931266.24.DBB6041 Received: from fout8-smtp.messagingengine.com (fout8-smtp.messagingengine.com [103.168.172.151]) by imf05.hostedemail.com (Postfix) with ESMTP id C8881100003 for ; Mon, 15 Jul 2024 12:34:50 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=Wt8w9toB; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=gtrqVqa4; spf=pass (imf05.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.151 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721046872; a=rsa-sha256; cv=none; b=v0P1Cr20ZwfmEC/rX2wRYAZcqMY8EXK/fyD2G06uku4CQjOvCIhyAVXc7qVZV/pPIqijrj UhhTQk6stJZpJ0V0YLTSbazpsPDEpGkhoqptdYcfCiF0F89yxIqGssPXtS6Jp7+Qa5i02e 4A6UW6NgB5SHqg59xYUEBc6IjpEz2vg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=Wt8w9toB; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=gtrqVqa4; spf=pass (imf05.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.151 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721046872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZFxJtd+i93QBQWnvDAdYE/qsYCVxPHUYBpwxpYgj7xQ=; b=WfEanBiG3siDPOWjXWl4Z+wjwKGyUikq4rXdH9x5F2BfF9qOXiM251vyIv9Nk/pV5qy0ZQ 0mfEJofmD0gU03qeRqf6ue6msTN3o0TB1WS6eBtEaRCRW0cNNS0yQR2bymqor0quepo1L1 48RvLWu7CDv4eQLHK/lE+bax604kHmg= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id E0BA01388C6E; Mon, 15 Jul 2024 08:34:49 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Mon, 15 Jul 2024 08:34:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1721046889; x=1721133289; bh=ZFxJtd+i93 QBQWnvDAdYE/qsYCVxPHUYBpwxpYgj7xQ=; b=Wt8w9toBNte+fxi/ipN5NFeB6B q5Haazv5W+Qwn/Yd92jlTlP0JAToejUCujdhMjF3QlBUnpcAenLGsUI4v8ZdbwXC Kz3YtAfh7Bxowss2xMxG2PxUEXZLMIeYkcsET7ULs6xHZeGuHGGNNsyDWPN/bkFr imN7ZKN4FTInTbDhIuuIltU3n8pVDW3ANDosixR9KmJTghnDO6t64cWYS2rValRu F92GZlKktMqRQDeuU86vnyUG7S7D8lnxwf0xTG0mps1vxFRwhxl189dBiEy/9HNR 2CkSnoJi71AMkZ0xnemFkS0ZGLYUgKzXP6eWBuDLUaSDQUYz+mJiUNcHeXWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1721046889; x=1721133289; bh=ZFxJtd+i93QBQWnvDAdYE/qsYCVx PHUYBpwxpYgj7xQ=; b=gtrqVqa4BCIJlKBpDzemRvjbVl5D9GM+p9zdXz12vTqQ WgdomdsFPM2AoT1vg5T3yjj2wrhhqigDnRMyFbatauEW5cfD4RRrjObN9BKowklo 8lHcaoGMHa90uzjJYLWCMtLIseuz/fIXNgFpFETPKHjHPLOWl/YKG01vRjIQegD0 zPkZSemcvVxlCcnDt1WcyYsFI8Ockc2bOTzAoMGalw8HYpWR9/ZKnf90HTwR5DPw fLYb9CIoLUP/yoNm7kgfRjxJ623CbjEE51iyvKIV1qFyiJPTc6kB2aA31w28A8cx kcttbYuWMjmnC4yI/zi096UgidoM6KdZptHxDp/2QQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrgedvgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8FEB0B6008F; Mon, 15 Jul 2024 08:34:48 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-568-g843fbadbe-fm-20240701.003-g843fbadb MIME-Version: 1.0 Message-Id: <5637dbc2-de31-4b30-bd14-9c4d670ef790@app.fastmail.com> In-Reply-To: References: <202407112039.cyyIQ3Js-lkp@intel.com> <0de0aeba-da02-4fa6-a1f8-a468dcbfac58@app.fastmail.com> Date: Mon, 15 Jul 2024 14:42:06 +0200 From: "Arnd Bergmann" To: "Dmitry Torokhov" Cc: oe-kbuild-all@lists.linux.dev, "Linux Memory Management List" , "Linus Walleij" , "kernel test robot" , "Greg Kroah-Hartman" Subject: Re: [linux-next:master 11606/12643] arm-linux-gnueabi-ld: arch/arm/mach-pxa/devices.o:undefined reference to `gpio_set_wake' Content-Type: text/plain X-Stat-Signature: gtcbbb3bjcazweqmafuwo9xajwuopgek X-Rspamd-Queue-Id: C8881100003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721046890-398888 X-HE-Meta: U2FsdGVkX1/bBfJw6LGfrrfdBxxeIFBMA/fUdsIOIdNv4ocLV9FSIfXgwkTJ7wlNgcCVNvNyV+zcQcMrrBo/gmFohi39I58AavZP5sPEfM42BAFXGjjPz8+oO3qTjbFfiu8eH7nJAwnZD387HzGUwJEJSm72NPpSWm2oIxsU14FZ7zpsgOm3+863h1C0k+6DUe7l+4/yu8kOVoS9LBrUkyHvXO6nwuHTqT08bIRYJbyrnNBFN6OzPMV4Qr7zcN4RRwIT0BgpW+RmpuBih3DQ4n8vkkIZlsdT8XIsTZQTpu1Ujtbk9yTo7NGJhBn8Z80iWaP+xbxE2TSv6yBiAeeFQ9717GZzxXhVea+JAjOrZPUVFX+oTwt+93Hu/iAJd5JllSB+7s7lHCotdfYjnXJ+oSOpKv46dxVzy9OWEnjxofZC79LRmqU3cDWR3tXfamjO0qjUDq0QYYu9ZEUOONNZud52+CzmX6Edtdb9mlgkXzoY08b5TFezjSwhVUhUZQW5x7oGws86GdGbSNTJWsFiIu7OUQoiNRAaie3qpf6iqpPU1Bs2Yphzhxh4KBR63Zribk3cChfvPo3E95l6Tt8AXgnH4JJTr+aQaK+0ufsUC6epqWvben4eo5pUwQZwVMQ95nuK34IccwhqTa69jvBuvvMDWNhDt4TB3cHlZ/Q7/gCQpf+QrWr7ZcyAm7lZXH4CO5EiLh0DGzNJjbPRt3Db8vWH+wfm8a45JsomJbT6Kz01ovqogM8qBY7/aCVuIJ9cfJZdIXJBDizsoEB6ygXTdLaG2sP65LlQmReAoJqDWP4i04Bq0CeNx6bh/Qe4bEFxklGyqx21XxvU4c/FhPkl/W1BWoH1bIxaDmQJidwRPLPLgvH174I1994ppQpeQjB2R6lGE91dqk8p1ps9SnwX4bgwkELY2mysSqgInRgSfBWkQ/fgXu/K/oBzPN8MLmXBnY66UBUxDF2F6rOJDt2 lL0NOJu1 sy4i5Q6gqVF/rQ3RsOGV/11KoV4+YIuta72qHmj1vA0FWYEZm0X6RdTBGyLAFdhpiv5QAPXZI0FZh2aVPDbmc+aBPh6rM3S5+pelBPBwuvUvrdd1LkJKPO7Zjz6YT6c1+i1ukuPF/Z4U83v+jm9HimJZIPowGshqVMwhLKFLZc+dH1+aBaAAncqRJAOQslL5VMSsWPxRBNyhf1sFk846+xuthi/EcbvoPJGRw7/4mbKdHcW8aicRLXLDrsFuJUca5PteeWSbQSP91Ro/HK5/XdoyCnC73mxDyO9OAcSO5OO+/61T+Eh7WoC9z8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jul 13, 2024, at 05:38, Dmitry Torokhov wrote: > On Fri, Jul 12, 2024 at 08:41:58AM +0200, Arnd Bergmann wrote: >> On Fri, Jul 12, 2024, at 07:31, Dmitry Torokhov wrote: >> > @@ -684,6 +685,7 @@ struct platform_device pxa27x_device_gpio = { >> > .platform_data = &pxa2xx_gpio_info, >> > }, >> > }; >> > +#endif /* CONFIG_PXA25x || CONFIG_PXA27x */ >> > >> > static struct resource pxa_dma_resource[] = { >> > [0] = { >> > >> > If you are OK with this I'll submit proper patch. >> >> Right, that's probably the easiest way. I was trying a more >> elaborate change (see below), but there is a good chance I >> introduce another regression in that, so let's go with >> your patch. Please send it directly to soc@kernel.org >> Cc:linux-arm-kernel and I'll pick it up. > > Done. Merged now in preparation for my pull requests, thanks! >> One more thing I noticed: if you are doing more patches >> to convert devices in board files to use software nodes, >> we should probably try to move them away from static >> platform_device definitions towards a dynamic >> platform_device_register_simple() or similar interface >> at the same time. > > Sometimes platform_device_register_full() which operates on > platform_device_info structure is very handy, but in general > what is the issue with statically defined devices (when they > are never unregistered)? Greg has been asking for this for many years, but it has been unrealistic in the past because of the large number of board files using static platform devices. As far as I understand it, having static platform devices prevents us from better enforcing lifetime management rules on device objects. Adding Greg to Cc in case he has something to add. The other point of course is static memory usage: a platform device structure in .data is much larger than a platform_device_info, and this adds up in a kernel that tries to support lots of boards. Arnd