From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F153C3DA6F for ; Fri, 25 Aug 2023 08:03:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE7E328009D; Fri, 25 Aug 2023 04:03:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A982A8E0011; Fri, 25 Aug 2023 04:03:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95F3228009D; Fri, 25 Aug 2023 04:03:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8142D8E0011 for ; Fri, 25 Aug 2023 04:03:52 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 534B21C9762 for ; Fri, 25 Aug 2023 08:03:52 +0000 (UTC) X-FDA: 81161888304.27.E094DA6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 0F4B9C0016 for ; Fri, 25 Aug 2023 08:03:49 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NWTMLXRW; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692950630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2MxIZZ4mXfirEQxPRIwxDlbt+KbgvYe7pzgQ6nQuMXM=; b=Jo6PALXBpYs3TgcaGRBBtylY6bMoKoNBzvJRHIJF0hcp3fBunP98iotdLXCsv9sfqvLHKK UiTd3AxH/B0f96AXy8qJvrxgTw2xY05Z+BoSvqyTmQf2Ha2FhhQ+PSsilpn6oKVT566KG7 Gnq9qKyEJo1dep4Vt/tXdh+5ECNGrOg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NWTMLXRW; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692950630; a=rsa-sha256; cv=none; b=N7p8cHJjer9y3nKPQ7PhOv5tHWPGuKe3HKn9IG1D+VYHn10LdFvmb9daQkI+mR9YxQyMjZ QerPTo81qph6ssAuMmLuhW6+STL9bGI0vVXec4EZQEIg+aK5XgU2Yhli50dPJYj5fGLhgC xphE4LvtOOR9fv835GZK+iNOHqlx1xY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692950629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2MxIZZ4mXfirEQxPRIwxDlbt+KbgvYe7pzgQ6nQuMXM=; b=NWTMLXRWP+Y/5d4WCd5mvMFtdhTnyOY08LbeiVF956cAoL7iFq2Dp7pM9pdK0ZRPk2WkZH J+0suFEBXh2QJ1XUXFZEbTzwRBLUgif9fqp366+W2C8c4jQx6k0c9OottRpGNKrNlEomZb Tr87KgP4oGz9LGi/rA52wXXAoQpmL4A= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-199-PBGtf30XO9C8sFXNlZQNEA-1; Fri, 25 Aug 2023 04:03:47 -0400 X-MC-Unique: PBGtf30XO9C8sFXNlZQNEA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-31aecb86dacso482735f8f.1 for ; Fri, 25 Aug 2023 01:03:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692950626; x=1693555426; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2MxIZZ4mXfirEQxPRIwxDlbt+KbgvYe7pzgQ6nQuMXM=; b=CNhvBTQNxuSz75XhfgYCRAJoxDkSjr2qXbkDmodlTukT4GahbIfq+lWnZsq456/LUA elsMS9eb9IOrJdC5xqQkdkD06GpP8ney05CHS3frv/YqdruYJjxbyhALXhCGJSwFl++P Ivx56tif52mmkuXWooWort0Uzth7mCE0IBJmC9yj3Mwae9+t66I49KzrGn/77GTpXeJp FNQRrdGrJ53ggOJaRGqWNy+Yj8qBha1eo5ZIV+ohM6qMYExwXCIrnxP7/n+nvusc1kJb +iDM71X48tHQpqW4F40to8dmk3sVR7q2VDIK4rTLhIsC4zDX3CyQnpE2mBJy8WZhJGci 6p4w== X-Gm-Message-State: AOJu0YxsylYFCwnv84XVgVeJpw24g9bE6kFA0w1LtGckbHKOaWrasl/d 7VuU40sZdaQK9D2nOCwjcO74ISIZeto3WApHQqqYknFmgNFgsp1jaizeK8hZOB71MNQyd8TC2Jh vo1CIDopG/3bMAiYAY+w= X-Received: by 2002:adf:f3cd:0:b0:313:e9f6:3378 with SMTP id g13-20020adff3cd000000b00313e9f63378mr12914611wrp.4.1692950626181; Fri, 25 Aug 2023 01:03:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEp77WBmoQU7jbIBWKspqG9dAlzLpg5JTV9tJC+oX4MTnlZBIoLiOJSXLCsVRo5z+lM1xyTlQ== X-Received: by 2002:adf:f3cd:0:b0:313:e9f6:3378 with SMTP id g13-20020adff3cd000000b00313e9f63378mr12914599wrp.4.1692950625838; Fri, 25 Aug 2023 01:03:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:9200:ce93:b5e6:8aa9:65d4? (p200300cbc70e9200ce93b5e68aa965d4.dip0.t-ipconnect.de. [2003:cb:c70e:9200:ce93:b5e6:8aa9:65d4]) by smtp.gmail.com with ESMTPSA id o15-20020a5d684f000000b003180027d67asm1464874wrw.19.2023.08.25.01.03.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Aug 2023 01:03:45 -0700 (PDT) Message-ID: <56300927-4b81-8acc-58d3-4cbe0f1d60f1@redhat.com> Date: Fri, 25 Aug 2023 10:03:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() To: Vern Hao , akpm@linux-foundation.org Cc: zhaoyang.huang@unisoc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vern Hao References: <20230825075735.52436-1-user@VERNHAO-MC1> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230825075735.52436-1-user@VERNHAO-MC1> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0F4B9C0016 X-Rspam-User: X-Stat-Signature: n3g7ch6ay1iqcdwcjfeuae4kct96hdpj X-Rspamd-Server: rspam01 X-HE-Tag: 1692950629-198013 X-HE-Meta: U2FsdGVkX19IM0xaCqcYmpyvmuI9eJ+hxhaJXyTTzjgVNw264m8GHfmocFAcvBcB5X70wwvQTL6I6tZFHfLUu9QY8vKymXeCYmvx0zQ0SI8+DebEKUSfCbG3lmNW4cdkAhD8hE1zFv+blp55UwH/cXJB2NTBAaA028vMFLMwgJ++UHUIdHCgv2tWexncqDdW/Iz5pVt2IaQnf6ER9Y7E5+XdOjr4//5veUfV4Dx0fpaABeas1V/2k32EWyyaEGLBhMQnxFqx4E1Hy1+Su2/eiYFO554a64T3iaphTus0mS8eR3ZlYl0Hrx8pEnfNG0oHttlEZ9kcOsjOsOVqcroKllr6eKuzdMIfGYeASF/qOBLzYyF8iNSDLBv1Fkh8oBKtl8WCVv0kAbL6aEtzfSJvzEezNxPzqXJ1eyT0WJGuoSAVmfvFjTwI+LHfShh/kmIO4nlHhJoiV6t39bMC2e8zlPaVrgRgut5RKDZ3c6TOxN0DJ7eRU9X5ockflCAaVw/bTE/GEIPZi+G/4ruQ60GzDScqjHhe99iMcmoTD7uQkxuR8pNvb6qtTK+VfprdM6TVKkB7KD357wAuxZgBtrhFKlFhZB3pefJSS1iArNWWwlNRjBEUI6J79Vh0JEizt6XYIEt8+n3FpUKLTGZCt+PzrZ+QuN4u1OhvEmG8IfJzNCPyxHYLBr8cc8pRrGrjU8m0v1iUMGT85Ydqcngvh+4CiQvOPTojLzhRetQtxxSAbv5liamAbeYUYlIcyhGfnm41NZH8WTtGfpKh703IhArFz4NXtvugItBRgm8G/Sm3hiY1Le7FUOFJjCB9AG4eWS4CNokZn1fxavFjDC3Q6N8ZejO5NdZMouWvLq1FA5bhqVUDW0XrlQMpuUvkXR9An/aHMbVpcKVZPgnxEPpdK6f2bsDP7BShf048B7k908meNCAJN9mUnEBDp/lJg+IOOIN7B9RrPAKXf6Vpza8TN4E R/MCid90 vL/z6ABaKjR/Lngh8sosvg0AhmK4a0F5s+6RymihiZ+QVKss4L7XIVxIiI2OiWdgYU+bUIHKEtzQ9QyVzW5NUlWLt6DFMo/R4k1hPxuTJTY+jkT2fmfIDMBkY7uWyy69ZjR23N1KQwkzt2pNLqxvqKsuyjcyBL7OY+lV7W+jixbXK+avzaveun1Ip/By7urtSp5GJjwV85SDa21tlJlMDwqRcpCU+ApHls9QVPZgPd4IeBg0ZCL8X+4VBAEAfy/izfLzmGx5d3Lrf6rNkp1dbwuw6RhBm9m4giws3s8kiq3gMXbrRBLWnTLLTqI9aNkT+4HjVYc+K54z3OLbJObnMj4raOMDnw4G1GSgkp8TT7hRLLsjVMDbkfqd89mbDnLuuS8/IHHKSLQA/xAZyVEt8TVnSRsq5T02BbPtUi82gQ1qAcmpjV77nrDnOdP+Hwee9LjehBiN9i0gj9I2bX4j9Y2WZpoNV0nYgxNTmErKYJqEntd5SR6fXhp8fKxhXLLPicjJ7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.08.23 09:57, Vern Hao wrote: > From: Vern Hao > > In skip_cma(), we can use folio_migratetype() to replace get_pageblock_migratetype(). > > Signed-off-by: Vern Hao > --- > v1 -> v2 > - remove "Fixs:xxx" as David Hildenbrand suggestion. > > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 2b5d61eeb039..850811bb5699 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2271,7 +2271,7 @@ static bool skip_cma(struct folio *folio, struct scan_control *sc) > { > return !current_is_kswapd() && > gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE && > - get_pageblock_migratetype(&folio->page) == MIGRATE_CMA; > + folio_migratetype(folio) == MIGRATE_CMA; Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb