From: David Hildenbrand <david@redhat.com>
To: Vern Hao <haoxing990@gmail.com>, akpm@linux-foundation.org
Cc: zhaoyang.huang@unisoc.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Vern Hao <vernhao@tencent.com>
Subject: Re: [PATCH v2] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype()
Date: Fri, 25 Aug 2023 10:03:44 +0200 [thread overview]
Message-ID: <56300927-4b81-8acc-58d3-4cbe0f1d60f1@redhat.com> (raw)
In-Reply-To: <20230825075735.52436-1-user@VERNHAO-MC1>
On 25.08.23 09:57, Vern Hao wrote:
> From: Vern Hao <vernhao@tencent.com>
>
> In skip_cma(), we can use folio_migratetype() to replace get_pageblock_migratetype().
>
> Signed-off-by: Vern Hao <vernhao@tencent.com>
> ---
> v1 -> v2
> - remove "Fixs:xxx" as David Hildenbrand suggestion.
>
> mm/vmscan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 2b5d61eeb039..850811bb5699 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2271,7 +2271,7 @@ static bool skip_cma(struct folio *folio, struct scan_control *sc)
> {
> return !current_is_kswapd() &&
> gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE &&
> - get_pageblock_migratetype(&folio->page) == MIGRATE_CMA;
> + folio_migratetype(folio) == MIGRATE_CMA;
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
parent reply other threads:[~2023-08-25 8:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230825075735.52436-1-user@VERNHAO-MC1>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56300927-4b81-8acc-58d3-4cbe0f1d60f1@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=haoxing990@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vernhao@tencent.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox