From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30943D2A523 for ; Wed, 16 Oct 2024 14:41:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C28F56B0089; Wed, 16 Oct 2024 10:41:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB2306B008A; Wed, 16 Oct 2024 10:41:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7A4A6B008C; Wed, 16 Oct 2024 10:41:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 83BD46B0089 for ; Wed, 16 Oct 2024 10:41:39 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 425E64066C for ; Wed, 16 Oct 2024 14:41:32 +0000 (UTC) X-FDA: 82679728866.05.2B1CF09 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id D6D5E180009 for ; Wed, 16 Oct 2024 14:41:27 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729089649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=16LorRKjT33sx3KR4keGG7/49m3lTdc5lak60eDcl5U=; b=EHAT1V9Io/SX4vrKXxMeg2X3GDgKw9YjpGnIgvJhU9aFexPxWaiuOUe3YwTfw+RQxymLXE Wji21xi9D8aVmdlSaB88bRHSuKkD5tBoqmvDb9l1H80d38/iwaZo7mRlkREBHqtdqluR4I ODw1iWJoXb0dCNEyVigB3/ij5vmfTOc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729089649; a=rsa-sha256; cv=none; b=3e6olKCjQ8QpCt5eFmmkCELbfkhSZOUIjEdNYovjm/d6j0jILthkZvhElqQ6YaeKq3U1RM RS5rKyYdeTgobVkCl26Nep35cbkamvUUGDmK0GetgXq+jowzfTvXm7bPpBCvw8IK+2iyN5 E9Udkbw6aByJh9FNLfxx1XawKs9svt0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6BDB0FEC; Wed, 16 Oct 2024 07:42:05 -0700 (PDT) Received: from [10.1.28.177] (XHFQ2J9959.cambridge.arm.com [10.1.28.177]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 449BE3F71E; Wed, 16 Oct 2024 07:41:33 -0700 (PDT) Message-ID: <5621f716-1ab5-486f-ac8f-670cc68ee410@arm.com> Date: Wed, 16 Oct 2024 15:41:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 17/57] kvm: Remove PAGE_SIZE compile-time constant assumption Content-Language: en-GB To: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Will Deacon , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-17-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: <20241014105912.3207374-17-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: muajg6hay3qjsfiuzbtg3qpwzs4h8dux X-Rspamd-Queue-Id: D6D5E180009 X-Rspamd-Server: rspam11 X-HE-Tag: 1729089687-406106 X-HE-Meta: U2FsdGVkX1/0KYqYYpv9ujf6yecJj6isuyIBr5ckKHvh4ygUobYcmQpLIUB8l/qCV/Z/dYnbvrHwdaqqLkUqvUhH/YzF820W3kwax33w9tVgiH5jxHv60ddtjBb+M5AUbOcgYhI2xadFvCxx0NdKyGgFr4poOcy2czP0ABIu3Fu68We56z+3rupG9O32aAjJqoDnGfkwOFJaIxID7AbS9yzlqKPhBaXOfvryI2ycwjRyxJNpDeOuIQgcVBxXKMrLQNjOUMF2wL0ERJWnmDVd3NukhF1JQTzLZ+07jiwyFKzRW/Xaqn4PIDdMutALJfuP5q6ubK8EeHXUVa+1XFzyCk13aBdwhZkbclrYad8zyVBDyxq9/yLyq5w0Q2uABPfBfM7s3Ffw0dBrRa+jsjMoh+SyZh3lDS4gS1qOe3E7k+QTGQQG5klWx12043c0gAsvORk8ck7y8WkBjVTxMUGpnHv+IfZ2RwMcm/dseI7QtQJssGn/IT8EJvcQrnJdcwAdjiihafexpGn6TDM+8AA7AqubKsWqWo2ToNf+aSLj1oZLs/soSznIxpncesaSMGWI9YcUIwjPZhZtfXluXsjhmofzt+lF5V5wBSABntbYcWxQmxIeLpdQ8rMoluMEGfiBVg16fpvBLAsdniG0CdHyX0wlToAeKg86obJHaWkgOK5r+jUhetpMr2T97Or47TAM89cb4TOPxXLCYL3RfeCumNy+EBiB7g4sE0Pv8iLtUXu4ukKTzZb7c9l5RJOtnxHRkHGR6un5Kps93gGIFrvLzRg5rg74Bqh76EFA2K/U0tfeglGVWdJ77TmQrHhppjdWNczikb9RJcCY21/0sLUbq+DVuEixMkFJvegJw79UJmdikTfZN05mm8Rd1pwBr0a6rs/ubGlcvuRRf9dMfOlOUQ8TzJ4zB22vYMWnOIiZ13czA52HyxQN8Q+c6zJHGF++M3Rh78Nu0KZT4Crs6a2 /EiPlZ00 CnWnLA4y3bowLkk16/Fe5g4PeAPT2nmxkUj6xTotU1/eqrxrzoVpGiYZE0P02SDaxlxc/FBeHiWHlvxWslZPC03qL55KKLE8CBotkK3g0wvj5/EXY8e4/5perlSysbH6yDJF0zS5MLnSK85IzHr9vCKjab9xPmyuwAREOgOCt9OngtySqkKJTOITsXwsEfN6neuFTxYfK57Kg56hYQ43+/uSJiJwlVF36kHMNql4NYxm8xbz02s+G4XGx9YChJsFzMGVpPmklyGDL2UT7eCl9J21utQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: + Paolo Bonzini This was a rather tricky series to get the recipients correct for and my script did not realize that "supporter" was a pseudonym for "maintainer" so you were missed off the original post. Appologies! More context in cover letter: https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ On 14/10/2024 11:58, Ryan Roberts wrote: > To prepare for supporting boot-time page size selection, refactor code > to remove assumptions about PAGE_SIZE being compile-time constant. Code > intended to be equivalent when compile-time page size is active. > > Modify BUILD_BUG_ON() to compare with page size limit. > > Signed-off-by: Ryan Roberts > --- > > ***NOTE*** > Any confused maintainers may want to read the cover note here for context: > https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ > > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index cb2b78e92910f..6c862bc41a672 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -4244,7 +4244,7 @@ static int kvm_vm_ioctl_create_vcpu(struct kvm *kvm, unsigned long id) > goto vcpu_decrement; > } > > - BUILD_BUG_ON(sizeof(struct kvm_run) > PAGE_SIZE); > + BUILD_BUG_ON(sizeof(struct kvm_run) > PAGE_SIZE_MIN); > page = alloc_page(GFP_KERNEL_ACCOUNT | __GFP_ZERO); > if (!page) { > r = -ENOMEM;