From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF54C36002 for ; Wed, 9 Apr 2025 10:01:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 918196B00A0; Wed, 9 Apr 2025 06:01:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C5E76B00A2; Wed, 9 Apr 2025 06:01:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 741026B00A3; Wed, 9 Apr 2025 06:01:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 562F86B00A0 for ; Wed, 9 Apr 2025 06:01:31 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3B0F656E6C for ; Wed, 9 Apr 2025 10:01:32 +0000 (UTC) X-FDA: 83314063224.23.A528536 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 8A8E21C000D for ; Wed, 9 Apr 2025 10:01:29 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HoZwu0iu; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744192889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UhsomB+pGcZTr0xfC9JjN6JYuerG9YdUwBkaq9uXxH8=; b=qo5a8OG+S5SQQ3ccE4EAMoYnUzuNaus40TBFftlIu1pEaBOK8rjhXQ6vGmM/gyHVDNLmpg MWi++EtA3PySMRh17pC96qoDYkMPjAJ6jwWQhLaQ3YFnqfpDN0VMc2PvjGkxfok/CkRB6e OXD1IuKyPdLtWjvmrNCdFbG7hzG6/Bg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HoZwu0iu; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744192889; a=rsa-sha256; cv=none; b=ubOmhaCFNhBo0dul270/o9meN+SPbhI7ma6SueY1SHJ0zCgiOyIxI418XOuyJrjH+XaKcs 18531Z7antUGvMBEiyOqXn2r++euCLJxBGlqqiF/OMh3mURqsjjYOihzTebzuo06RY4ZCx Vdg5h43BGl5X9MJt76P329FXwv6BbZM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744192888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UhsomB+pGcZTr0xfC9JjN6JYuerG9YdUwBkaq9uXxH8=; b=HoZwu0iuYgdarXBkJnMpQeQHopV+cFvPHQHwqQFfDzp4wtUr9Zt7m01iQkhwpQAW5OFhpJ ShD4YXaJI+9lKav88ZenO7Rc9UiCKkpIiD20f1AYWoZMGMmyNVgHrq/l1RIP51ZkhnUNmG qM1IErYk9QB6t4pjU08Cw2MpwZj69aY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-Q3FzPIGDN5-DphCBVw1w8w-1; Wed, 09 Apr 2025 06:01:25 -0400 X-MC-Unique: Q3FzPIGDN5-DphCBVw1w8w-1 X-Mimecast-MFC-AGG-ID: Q3FzPIGDN5-DphCBVw1w8w_1744192885 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3912d5f6689so3735105f8f.1 for ; Wed, 09 Apr 2025 03:01:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744192885; x=1744797685; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UhsomB+pGcZTr0xfC9JjN6JYuerG9YdUwBkaq9uXxH8=; b=tFFoO0JEzh+cwHRFcIn8sp0Nuq1n+JMiry1jkboBV3OB0Wb0K+Pliyus1t5GRki+4H U0MCpswMuI28dWFzAgRyI0a2XK5VQxPbV6xLS1Zuucm/gqARmF4U5JsrUw8yap+h0AuH WQLbXVbUrp8p5i7c/wjjFrgwI8TGFBjxQJ1jEbhIXC35daG/FC+GOC/XaxfFVDEW+WH+ Huj+AtKbm/t2MpX7WzRlmqZJQlZ3ZUG861etQMt1pbEy0CTaLZ4huxmD2AreFEttzdKv D1J2RikIy6zfph8JuMjxXkkWv1nQD5Lqc9MPZ0NlGVVqvEzwFSnIPG342KuvqvBFAkMa w6GA== X-Forwarded-Encrypted: i=1; AJvYcCXG3d4S7sfqm9LjmLYRsgZVN1k/ll96BNfiHwiEUfDD3wmrnJ7IRyBqpsphAJZqGyM2VLIXJnAA0w==@kvack.org X-Gm-Message-State: AOJu0Yw3UpWiZZE3cOM61l1Li7uAE+OQ9kd+Gbab8TpdIbt6Ns8nwXN6 OQwfeVwM1YDavmoSL51CwOkbxh0X5nXkVQOWrej2O66H2gfMoH9Hsj4y8IGQv3vds4SG3k+qOMU 1GN2nhanzqkpVFSTwqDbpbNXx1Ka4OPq8dFhFb7sslt+TOne9 X-Gm-Gg: ASbGncv4bzYVeiMBv0MFB5gPoR1JxAv+t17P77oAIGGYKHYtiIsSOGYtXaWlif93MFq Hy+jbLevQNNL6bRCk4DCjw05bWdUt/O9rqIhGRyV41qTltL+eARG06AGvxdX+eHHS2Wxo/vKPmy syFbuXIwGgpG2zyFwGpi8lyGazuxbf1u9XIHWtRG9gi4ubmBuZgvZfnR4BKFBrK28QTCbkAQrIv hZCezweHVpWvUI+mRCeJkYRW3rT3M0+lmNSX3AasQfVRCewcbX1wxT9VXXFplDXHbslITqQDadW lxORDyEvaIa5lBIoi3S4ap7SDs4dtVRWkfSTqflrd42hIiQg8GEtl7TumV1yYFPy8CnSaYnpH+R Uy9dai7J3yKYs9fzT7kAna65qnikh6G82TQ== X-Received: by 2002:a5d:5f46:0:b0:39c:30f9:1e57 with SMTP id ffacd0b85a97d-39d87aa7b48mr1850977f8f.18.1744192884571; Wed, 09 Apr 2025 03:01:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGn9dm8e0cNTFadjdThfqm79abD8ZcW9cyIWghyoWetdqCNs3giSGCfAB7zcy8vbdovna6ymg== X-Received: by 2002:a5d:5f46:0:b0:39c:30f9:1e57 with SMTP id ffacd0b85a97d-39d87aa7b48mr1850925f8f.18.1744192884148; Wed, 09 Apr 2025 03:01:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:8400:ed9b:a3a:88e5:c6a? (p200300cbc70d8400ed9b0a3a88e50c6a.dip0.t-ipconnect.de. [2003:cb:c70d:8400:ed9b:a3a:88e5:c6a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d893fe28fsm1161542f8f.96.2025.04.09.03.01.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Apr 2025 03:01:23 -0700 (PDT) Message-ID: <561d6050-e24f-4643-806f-8a520e324d11@redhat.com> Date: Wed, 9 Apr 2025 12:01:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 09/10] optee: FF-A: dynamic restricted memory allocation To: Sumit Garg , Jens Wiklander , akpm@linux-foundation.org, rppt@linux.ibm.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, op-tee@lists.trustedfirmware.org, linux-arm-kernel@lists.infradead.org, Olivier Masse , Thierry Reding , Yong Wu , Sumit Semwal , Benjamin Gaignard , Brian Starkey , John Stultz , "T . J . Mercier" , =?UTF-8?Q?Christian_K=C3=B6nig?= , Matthias Brugger , AngeloGioacchino Del Regno , azarrabi@qti.qualcomm.com, Simona Vetter , Daniel Stone , linux-mm@kvack.org References: <20250305130634.1850178-1-jens.wiklander@linaro.org> <20250305130634.1850178-10-jens.wiklander@linaro.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IZIsDsYtlQsahQTb64PdaTgT9f-eGFTGuAeQct5Mvqs_1744192885 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Stat-Signature: 8f134e7n8bdjeisppor9kuwt617ib9h7 X-Rspam-User: X-Rspamd-Queue-Id: 8A8E21C000D X-HE-Tag: 1744192889-608213 X-HE-Meta: U2FsdGVkX1+9xhenPCRHDiR3qqscj5XEBbg/GJw3IttBUU9AMrI12aVvc3J8ItrZFqDnc9Vzq/EAFYiE5QV6RfEbDIi0eXUhrRp9L4kktNXejFs9bIsh8e1/XpchX3oUK61lnkz9B7WLZLxlMktzbTJiSkeBzulvy4VO03SCsEH1pPLXR6zxiBVtIff4lD+wGBPfmfdbk7i4T1iO4BQETqNXut3hS0Isi5GDxtRnRg2qOjaTSbkXcYQRDglReuxl2zQTL+Lmfu33guprW1YmgMihlUdFaVt0lodvwlSGFJf7VHAwCXc1UL87eEgOInc1VyvYl93Eeg5qz7J5SZcDr6GZR/jXVRNvScne7dU15p5VTpLUhzfbIfgSCkHO+VArgQClkUS59yFeySsEyN6Bno0yI9WURZcJvKNboz6HUZC0j53WLDcehMA0qKeu4RlPO6El2ELfpVsxIrPvbHu0psOsp3ELTnQoiHvbDzzHGw0f1ZeNfcoQ20vGtV4/Hmtx+E1HMmQv2hGDLGwCfpK/dNIut74r43oDaN50Vyq3399HT3iwD3Ra5xiKf24ds4h+uCtKagnYa2RU+eG6b1jP6gPPqMywZrHMwfCRj7Wgw+nNSR5xvX2+xaU8urwF4bN7gSp9UpeMSi6z7XqPZEi2Z9slV438MdYY7ztA+SUsHSH2I145Bs/wGr6cFxqbkwvHZlsO6N1qxGhWp5NB7XHUOhKoNOIPNMGViSDC0D1EXLb4gJayPCmZiupPZyTcMtZl9tdHTDUilNPRsCPiM+uRiwhrP3bXSr0uQH5jaV59OCTR8TpSSrCW/8TvXcrWYk7arVsNS9G7TEbc+sbl73mOeK6zV8f9BuTCs3jW1fvE175fO0ZZTWEz8xlhJXM9rTE+k4wu04LXwucZ1N+HDJhye3v8qz9MMT8uxy1aXs9fITLlXLR+l9eLAlthYJTNS5/p08FLgnzZgIA9VGRTbKQ 8DBAW4AG nJ7N1b4chUOrEo+4s30Z3Q/pIvTVnhHkPiLcBFhyRs+jizwiIFu1j5AJ8iNtO7TP826m5dylFzEeXTBQ0QgpuejdJ+i6xliSHzJRGzkDQ48rEuRdLAgzcIkkwUFBk7Vvtt9BJ6YdIJ/skjSKbYa4yRc+dLIwI81iad1rIIwUFHVEceu7EeNj7GhwbTvsh6NiA38AphC776+1QJEh5x3NGinZyVOAFl/iolvNd9PiVYniz6KxC1OSLaVmytDlwT0UCM2i5TvXqGrQCLfIX3grdprFcZUJZKf0GrzIrPSvzBwJgad/xkw97Xo/zun0y5DloXDcgi+lsKJ7/ZFOQLWUdAoq1RwivxRGIAsNkgncmLOxYPg4xUAeTWD++D7f3c/mMSppKhUKw2L0bPLGYBOffrA/eCiUHnfYot2jwf636B2NAfyizMkVMXO6MXV5ZjGrep94HQ+EUstIipGo2plFoMpdbAMaOT0HrFSxfbNy4kA9FDtGSaxFFM66MWPxfhqWm2gT2eU6gGAm6e4xxiToFIUXpmYwcKGbk1kHx7HCHt9q2dlNnBqVSvcTdhv9zfAvxhXUjhqdGrf7luKw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.04.25 12:13, Sumit Garg wrote: > + MM folks to seek guidance here. > > On Thu, Mar 27, 2025 at 09:07:34AM +0100, Jens Wiklander wrote: >> Hi Sumit, >> >> On Tue, Mar 25, 2025 at 8:42 AM Sumit Garg wrote: >>> >>> On Wed, Mar 05, 2025 at 02:04:15PM +0100, Jens Wiklander wrote: >>>> Add support in the OP-TEE backend driver dynamic restricted memory >>>> allocation with FF-A. >>>> >>>> The restricted memory pools for dynamically allocated restrict memory >>>> are instantiated when requested by user-space. This instantiation can >>>> fail if OP-TEE doesn't support the requested use-case of restricted >>>> memory. >>>> >>>> Restricted memory pools based on a static carveout or dynamic allocation >>>> can coexist for different use-cases. We use only dynamic allocation with >>>> FF-A. >>>> >>>> Signed-off-by: Jens Wiklander >>>> --- >>>> drivers/tee/optee/Makefile | 1 + >>>> drivers/tee/optee/ffa_abi.c | 143 ++++++++++++- >>>> drivers/tee/optee/optee_private.h | 13 +- >>>> drivers/tee/optee/rstmem.c | 329 ++++++++++++++++++++++++++++++ >>>> 4 files changed, 483 insertions(+), 3 deletions(-) >>>> create mode 100644 drivers/tee/optee/rstmem.c >>>> > > > >>>> diff --git a/drivers/tee/optee/rstmem.c b/drivers/tee/optee/rstmem.c >>>> new file mode 100644 >>>> index 000000000000..ea27769934d4 >>>> --- /dev/null >>>> +++ b/drivers/tee/optee/rstmem.c >>>> @@ -0,0 +1,329 @@ >>>> +// SPDX-License-Identifier: GPL-2.0-only >>>> +/* >>>> + * Copyright (c) 2025, Linaro Limited >>>> + */ >>>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >>>> + >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include "optee_private.h" >>>> + >>>> +struct optee_rstmem_cma_pool { >>>> + struct tee_rstmem_pool pool; >>>> + struct gen_pool *gen_pool; >>>> + struct optee *optee; >>>> + size_t page_count; >>>> + u16 *end_points; >>>> + u_int end_point_count; >>>> + u_int align; >>>> + refcount_t refcount; >>>> + u32 use_case; >>>> + struct tee_shm *rstmem; >>>> + /* Protects when initializing and tearing down this struct */ >>>> + struct mutex mutex; >>>> +}; >>>> + >>>> +static struct optee_rstmem_cma_pool * >>>> +to_rstmem_cma_pool(struct tee_rstmem_pool *pool) >>>> +{ >>>> + return container_of(pool, struct optee_rstmem_cma_pool, pool); >>>> +} >>>> + >>>> +static int init_cma_rstmem(struct optee_rstmem_cma_pool *rp) >>>> +{ >>>> + int rc; >>>> + >>>> + rp->rstmem = tee_shm_alloc_cma_phys_mem(rp->optee->ctx, rp->page_count, >>>> + rp->align); >>>> + if (IS_ERR(rp->rstmem)) { >>>> + rc = PTR_ERR(rp->rstmem); >>>> + goto err_null_rstmem; >>>> + } >>>> + >>>> + /* >>>> + * TODO unmap the memory range since the physical memory will >>>> + * become inaccesible after the lend_rstmem() call. >>>> + */ >>> >>> What's your plan for this TODO? I think we need a CMA allocator here >>> which can allocate un-mapped memory such that any cache speculation >>> won't lead to CPU hangs once the memory restriction comes into picture. >> >> What happens is platform-specific. For some platforms, it might be >> enough to avoid explicit access. Yes, a CMA allocator with unmapped >> memory or where memory can be unmapped is one option. > > Did you get a chance to enable real memory protection on RockPi board? > This will atleast ensure that mapped restricted memory without explicit > access works fine. Since otherwise once people start to enable real > memory restriction in OP-TEE, there can be chances of random hang ups > due to cache speculation. > > MM folks, > > Basically what we are trying to achieve here is a "no-map" DT behaviour > [1] which is rather dynamic in nature. The use-case here is that a memory > block allocated from CMA can be marked restricted at runtime where we > would like the Linux not being able to directly or indirectly (cache > speculation) access it. Once memory restriction use-case has been > completed, the memory block can be marked as normal and freed for > further CMA allocation. > > It will be apprciated if you can guide us regarding the appropriate APIs > to use for un-mapping/mamping CMA allocations for this use-case. Can we get some more information why that is even required, so we can decide if that is even the right thing to do? :) Who would mark the memory block as restricted and for which purpose? In arch/powerpc/platforms/powernv/memtrace.c we have some arch-specific code to remove the directmap after alloc_contig_pages(). See memtrace_alloc_node(). But it's very arch-specific ... -- Cheers, David / dhildenb