From: "Christoph Lameter (Ampere)" <cl@linux.com>
To: Ming Yang <yangming73@huawei.com>
Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, vbabka@suse.cz,
roman.gushchin@linux.dev, 42.hyeyoo@gmail.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
zhangliang5@huawei.com, wangzhigang17@huawei.com,
liushixin2@huawei.com, alex.chen@huawei.com,
pengyi.pengyi@huawei.com, xiqi2@huawei.com
Subject: Re: [PATCH] slub: fix slub segmentation
Date: Thu, 4 Apr 2024 12:12:11 -0700 (PDT) [thread overview]
Message-ID: <56193a2c-dadb-108d-4eaf-0a923fc4912b@linux.com> (raw)
In-Reply-To: <20240402031025.1097-1-yangming73@huawei.com>
On Tue, 2 Apr 2024, Ming Yang wrote:
> The key point of above allocation flow is: the slab should be alloced
> from the partial of other node first, instead of the buddy system of
> other node directly.
If you use GFP_THISNODE then you will trigger a reclaim pass on the remote
node. That could generate a performance regression.
We already support this kind of behavior via the node_reclaim /
zone_reclaiom setting in procfs. Please use that.
The remote buildup of the partial pages can be addressed by changing the
remote_node_defrag_ratio in the slabs. This will make slub scan remote
nodes for partial slabs before going into the page allocator.
next prev parent reply other threads:[~2024-04-04 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 3:10 Ming Yang
2024-04-02 3:45 ` Chengming Zhou
2024-04-02 16:13 ` Vlastimil Babka
2024-04-04 19:12 ` Christoph Lameter (Ampere) [this message]
2024-04-05 9:05 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56193a2c-dadb-108d-4eaf-0a923fc4912b@linux.com \
--to=cl@linux.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alex.chen@huawei.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=penberg@kernel.org \
--cc=pengyi.pengyi@huawei.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=wangzhigang17@huawei.com \
--cc=xiqi2@huawei.com \
--cc=yangming73@huawei.com \
--cc=zhangliang5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox