From: David Hildenbrand <david@redhat.com>
To: Yang Li <abaci-bugfix@linux.alibaba.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/swap_slots.c: remove redundant NULL check
Date: Tue, 2 Feb 2021 11:12:15 +0100 [thread overview]
Message-ID: <56166666-4bbf-30b1-3f96-32fe972abc43@redhat.com> (raw)
In-Reply-To: <1611214229-11225-1-git-send-email-abaci-bugfix@linux.alibaba.com>
On 21.01.21 08:30, Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./mm/swap_slots.c:197:3-9: WARNING: NULL check before some freeing
> functions is not needed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
> ---
> mm/swap_slots.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/swap_slots.c b/mm/swap_slots.c
> index 0357fbe..be9de6d 100644
> --- a/mm/swap_slots.c
> +++ b/mm/swap_slots.c
> @@ -193,8 +193,7 @@ static void drain_slots_cache_cpu(unsigned int cpu, unsigned int type,
> cache->slots_ret = NULL;
> }
> spin_unlock_irq(&cache->free_lock);
> - if (slots)
> - kvfree(slots);
> + kvfree(slots);
> }
> }
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-02-02 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 7:30 Yang Li
2021-02-02 10:12 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56166666-4bbf-30b1-3f96-32fe972abc43@redhat.com \
--to=david@redhat.com \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox