From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "Liam.Howlett@oracle.com" <Liam.Howlett@oracle.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Stable@vger.kernel.org" <Stable@vger.kernel.org>,
"support@spotco.us" <support@spotco.us>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mgkeyes@vigovproductions.net" <mgkeyes@vigovproductions.net>
Subject: Re: [PATCH] maple_tree: Make maple state reusable after mas_empty_area()
Date: Thu, 4 May 2023 19:10:05 +0000 [thread overview]
Message-ID: <560c0037f71be3b0bfe0109ace30cfb869dc7382.camel@intel.com> (raw)
In-Reply-To: <20230504175509.2195838-1-Liam.Howlett@oracle.com>
On Thu, 2023-05-04 at 13:55 -0400, Liam R. Howlett wrote:
> Do not update the min and max of the maple state to the slot of the
> leaf
> node. Leaving the min and max to the node entry allows for the maple
> state to be used in other operations.
>
> Users would get unexpected results from other operations on the maple
> state after calling the affected function.
>
> Reported-by: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
> Reported-by: Tad <support@spotco.us>
> Reported-by: Michael Keyes <mgkeyes@vigovproductions.net>
> Link:
> https://lore.kernel.org/linux-mm/32f156ba80010fd97dbaf0a0cdfc84366608624d.camel@intel.com/
> Link:
> https://lore.kernel.org/linux-mm/e6108286ac025c268964a7ead3aab9899f9bc6e9.camel@spotco.us/
> Fixes: Fixes: 54a611b60590 ("Maple Tree: add new data structure")
> Cc: <Stable@vger.kernel.org>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
This fixes it for all the cases I encountered, thanks!
next prev parent reply other threads:[~2023-05-04 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 17:55 Liam R. Howlett
2023-05-04 19:10 ` Edgecombe, Rick P [this message]
2023-05-04 21:59 ` Michael Keyes
2023-05-05 3:23 ` Peng Zhang
2023-05-05 13:16 ` Liam R. Howlett
2023-05-05 15:45 ` Peng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560c0037f71be3b0bfe0109ace30cfb869dc7382.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=Liam.Howlett@oracle.com \
--cc=Stable@vger.kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=mgkeyes@vigovproductions.net \
--cc=support@spotco.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox