From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8360DC47DAF for ; Mon, 22 Jan 2024 20:03:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E12F56B009C; Mon, 22 Jan 2024 15:03:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D9C3F6B00AE; Mon, 22 Jan 2024 15:03:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3CB76B00AF; Mon, 22 Jan 2024 15:03:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AE8706B009C for ; Mon, 22 Jan 2024 15:03:36 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 75319A1F0D for ; Mon, 22 Jan 2024 20:03:36 +0000 (UTC) X-FDA: 81708022032.14.595DE30 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by imf06.hostedemail.com (Postfix) with ESMTP id 5D808180023 for ; Mon, 22 Jan 2024 20:03:34 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.199 as permitted sender) smtp.mailfrom=alex@ghiti.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705953814; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UY+/M458NshjFahjq+G46cZtUvxPAnqJfcOX5t02M5I=; b=3hhaXsOTVZz5EKAEPaK78z9WyhNiEsy39uFtp/N2tS0+7PzD7LWd+6e1bZeR+qmcZ0mkzo uJH1N8VI9Tvj0Dggc5KsSc1nquFncW5t2youODlIFvApj/JqRsM46VM+BsXYriu0My4jjs y9Aine1bF47OsqnSQfihqmdKkDR307s= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.199 as permitted sender) smtp.mailfrom=alex@ghiti.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705953814; a=rsa-sha256; cv=none; b=JSulHVdCiqcFiLIcwMcjpsm+i8UrZoBLtRRhWYkt7pd27w8QqLIQa5LJ79OFtySh+qgrUS NlXZu1KHN0e0/jqUTWKSXJlUhWOX+uvloFqvxDpG8C00wfv/HWmS8G1FgpFshN2fSAoc+C TcObXftJ2FnR/7vTtb0UNLn0h3pNyYw= Received: by mail.gandi.net (Postfix) with ESMTPSA id 42A22FF802; Mon, 22 Jan 2024 20:03:26 +0000 (UTC) Message-ID: <5601b896-f67c-432d-a169-0f08928123fc@ghiti.fr> Date: Mon, 22 Jan 2024 21:03:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 04/11] risc: pgtable: define PFN_PTE_SHIFT Content-Language: en-US To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Ryan Roberts , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org References: <20240122194200.381241-1-david@redhat.com> <20240122194200.381241-5-david@redhat.com> From: Alexandre Ghiti In-Reply-To: <20240122194200.381241-5-david@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-GND-Sasl: alex@ghiti.fr X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5D808180023 X-Stat-Signature: 757t7ur5bx3818t63kp9f5sgjnq8sgyh X-HE-Tag: 1705953814-467016 X-HE-Meta: U2FsdGVkX18PKyhXZVNERibLSDQfJpPGIJIaEi0tCG6Nk6qRJdvVHVG5yEteaewOeiYApPu5PCXMNfgQmA7UELyeQGuB6JNUOk0rUGALTYeAUeublbp36BF/V5btzIV3L4DUYv9er27YIowAvd9GBJwRiekPEjtF3zULKor012nvAG9v7YlnfTVigwL0dCl5H0aI8T3xMRLD+z6P6AYOHykOE95tnk9Hx3zKKNO0S2ccG3IuJwPI1n+yNUxhpAzsTgjG3oKyzmFaPYoddxrZJuGDS6HGZ2m634bqc3WgVSUzqsqKkRac5pUZs5SliMNs+B3QBKF6z4/CjS52bTrh/b03awSTL8fC/8FHBnShdriKI3cF/YJQu0skHOthsyuoLEh15Vu4zIRCpjjpXdp+f2srbgRx/HP2NlpI4g+WZcEoKCCxBWeB6fJW0zVTkIRQJZLgcLA8QN12q/9GMQHYCkXCAzxh+V2IJpjcovHKyK9pNELKsNSixfVjHg/mBG460CWcieV5fNmFcw6joQnVJjzuyuIw84X6fqG1doTGIeoZbyhXN1O2nMlM+lZpbAml7keampdvhkoiS0TbUnFl41b2pXoEHwnqiZHf1I1P4w/yp8rGK9OmhkZuoDqaPlz7wpSxNWJpoUXIBS4AaRpZnJ8pMlx4gxdmrQdAOL6/ICp0ykW6O0SaHR4NMptzMg1vs/qRn/MCI31M1v9javtyw2FfBQk+02lyOQ3xvaZKYxxCymJ69jiOrA+lAgeCtnnZejVUP03yRuU+9e5yvTQTb424Jr6zJFRrEummHZHPI8dSVolJNLe2BcKR0rfcv4zxkPkH1gSWVIIcSmRIWTfnG57T+8LF4ZFo5YXPNClRLappPcQqEDGvauoZzWRNKP+Txv9FIgBaEE/lqB1dfVaBYoidrd0slGx9rdsB7aAkD4kkiAYuUfkenSQHnzZWYjLCrz+YHv+qKkpXQ3fyUAh ex3nCqbU em2l7M1PQEdTS8PsWsDHgTTSZOoiLeFcFnkkXjUuqQ2BvvPmPBZwUczpoKV0EIpkPpTFghhhVWI8RM74HQ+v/KaDbitXj8R68MSJsq+4N+XNp5i+h1M/qB8AzwDbcgNADFaA3GfV5mxvqn/Ah5+Q90rBnYIngOxgRHuqH0foG5UK806r1IW34eSRsqici/2ke2D52J0Cy252E2O2lT/8QEyOIuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On 22/01/2024 20:41, David Hildenbrand wrote: > We want to make use of pte_next_pfn() outside of set_ptes(). Let's > simpliy define PFN_PTE_SHIFT, required by pte_next_pfn(). > > Signed-off-by: David Hildenbrand > --- > arch/riscv/include/asm/pgtable.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > index 0c94260b5d0c1..add5cd30ab34d 100644 > --- a/arch/riscv/include/asm/pgtable.h > +++ b/arch/riscv/include/asm/pgtable.h > @@ -523,6 +523,8 @@ static inline void __set_pte_at(pte_t *ptep, pte_t pteval) > set_pte(ptep, pteval); > } > > +#define PFN_PTE_SHIFT _PAGE_PFN_SHIFT > + > static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, pte_t pteval, unsigned int nr) > { There is a typo in the commit title: risc -> riscv. Otherwise, this is right so: Reviewed-by: Alexandre Ghiti Thanks, Alex