From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B57C433EF for ; Sat, 9 Jul 2022 18:30:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4247C6B0074; Sat, 9 Jul 2022 14:30:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D6166B0071; Sat, 9 Jul 2022 14:30:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2827C940007; Sat, 9 Jul 2022 14:30:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 169326B0071 for ; Sat, 9 Jul 2022 14:30:35 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DF7A3204DC for ; Sat, 9 Jul 2022 18:30:34 +0000 (UTC) X-FDA: 79668401988.06.93D8525 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf20.hostedemail.com (Postfix) with ESMTP id E7D671C005D; Sat, 9 Jul 2022 18:30:33 +0000 (UTC) Received: by mail-wr1-f52.google.com with SMTP id n10so2213459wrc.4; Sat, 09 Jul 2022 11:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UzXTEzvirVIfQgpRsZ+S3IQH5KHrdqAU7esxyuqlcI4=; b=azFPTNNmWWMPgUFKlPXqmgq48Ky1+NFueWA8CeF4u6bOZNNqI/ZouXYtrZzIQI8369 tHNRrJbP3Sk+Qceww9e7NnrcuDgJ6oXsFN+7UXhcMdUokeJ6YJlHAlJxMvos2ldKLn3j 7qnyIMJNcvc4n+99h6ZoUqIl96IBxZcSLUP2Row3p9htPHtQDjaOVGMxEPZIg0ThAzku JP/YMWoEj/7gz/zYLt8XR5fUmxUTGzc7A4L/NsKoD1clU44nb9/glj7xUMteE9ztqdCY xScs/VQryAk4+7BFaPGN8I56D8qyIDvJpCmOtxLQds1DYNF1pzvoTJw1JwfwK48t37Iw OhgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UzXTEzvirVIfQgpRsZ+S3IQH5KHrdqAU7esxyuqlcI4=; b=iEBbJBtu9zIWRuKmx0IlI1Uno7Q10sFJfp4+ALc5VzCfROE5UEbJZA5topznvEk7dK frOB37Pk/nhOQDpKp0+l4TbwfSoe8B8eQGVhR66xJ1DNw1zFfsXarnPQta6gehePxjAt D9Rh3INQX3Gtf9UCdk/MqGvgl+Q4MBKH0ZBTuxbTjQBIOAsFsQRPqLr+VHmCgfGkugxx pWGfRdCEw7sFVFXtFqtVDEvJfubWljRVRYJfnsXwbNdFG7z2AHdTto08WC8oEAEtuD9o rhJaAeHJpU858dy0csBQ8BGT5pPnK46ty7pmTDhk5+jJCMAOm/R6f1MyXHDr/kOvHQnR Yv4g== X-Gm-Message-State: AJIora9kGB3/dWs5AHKSXZTO9G00dMXePsNa5HEnGfk73DYr4CcCbTnO pvtFWNZj674SNvyQ9rVRgTk= X-Google-Smtp-Source: AGRyM1tAtrtLBOTNfS7tOy8h/BBFOAIT9pR7nVNc89ZMI3mrlIbdzOc1A9K2XpDn13ZLjn4N3vi0ng== X-Received: by 2002:adf:e0c9:0:b0:21b:8271:2348 with SMTP id m9-20020adfe0c9000000b0021b82712348mr8620979wri.222.1657391432677; Sat, 09 Jul 2022 11:30:32 -0700 (PDT) Received: from opensuse.localnet (host-95-235-102-55.retail.telecomitalia.it. [95.235.102.55]) by smtp.gmail.com with ESMTPSA id j9-20020a05600c190900b0039db31f6372sm6358721wmq.2.2022.07.09.11.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 11:30:31 -0700 (PDT) From: "Fabio M. De Francesco" To: Ira Weiny Cc: Benjamin LaHaise , Alexander Viro , Eric Biederman , Kees Cook , Dan Williams , Matthew Wilcox , Jan Kara , Jeff Layton , Chuck Lever , Jens Axboe , Pavel Begunkov , Thomas Gleixner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, io-uring@vger.kernel.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [PATCH] fs: Replace kmap{,_atomic}() with kmap_local_page() Date: Sat, 09 Jul 2022 20:30:28 +0200 Message-ID: <5600017.DvuYhMxLoT@opensuse> In-Reply-To: References: <20220630163527.9776-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657391434; a=rsa-sha256; cv=none; b=tq3CXgplK4DVs2ELG+E+HVVnhUJL678QRp7KihSpqPiVf4ZxCcKnd4n+MD+t0dW+DAAyUx NT3eB8FKwcBF8lMA9vqa9uiVwNdLIXVwqYcMoJCPKNe5SAXOge/cfsRjFKp3xo15yIEQCU V5iPqckYiwzNUvoNYXInCP0fs6yrS6s= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=azFPTNNm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657391434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UzXTEzvirVIfQgpRsZ+S3IQH5KHrdqAU7esxyuqlcI4=; b=5jKE/ydWJcWvtm77tRBFA8Ka0YL3dIR1eq7CAOsdeBCsNHy7zSztv8ZvQMcSnFYd6A+lPi cuNwCiInhF92iATInSzfl3H99y0YZduD4ejE4E6/DpwmhSNrBZRf83UjfIl1+o5kHp5Wmf aCrmNsfggMCt5t1kxXjzJM1H22XucXE= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E7D671C005D Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=azFPTNNm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com X-Stat-Signature: qwtmeukjqqh5bctrtq7wrfz3odasbcde X-Rspam-User: X-HE-Tag: 1657391433-923 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On venerd=C3=AC 8 luglio 2022 22:18:35 CEST Ira Weiny wrote: > On Thu, Jun 30, 2022 at 06:35:27PM +0200, Fabio M. De Francesco wrote: > > The use of kmap() and kmap_atomic() are being deprecated in favor of > > kmap_local_page(). > >=20 > > With kmap_local_page(), the mappings are per thread, CPU local and not > > globally visible. Furthermore, the mappings can be acquired from any > > context (including interrupts). > >=20 > > Therefore, use kmap_local_page() in exec.c because these mappings are=20 per > > thread, CPU local, and not globally visible. > >=20 > > Tested with xfstests on a QEMU + KVM 32-bits VM booting a kernel with > > HIGHMEM64GB enabled. > >=20 > > Suggested-by: Ira Weiny >=20 > This looks good but there is a kmap_atomic() in this file which I _think_= =20 can > be converted as well. But that is good as a separate patch. >=20 > Reviewed-by: Ira Weiny >=20 Thanks for your review! I didn't notice that kmap_atomic(). I'll send a conversion with a separate= =20 patch. =46abio