From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A85CF2576 for ; Sun, 13 Oct 2024 07:56:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DC186B0085; Sun, 13 Oct 2024 03:56:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 664C56B0088; Sun, 13 Oct 2024 03:56:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 506226B0089; Sun, 13 Oct 2024 03:56:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2DE776B0085 for ; Sun, 13 Oct 2024 03:56:55 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C0C68C05E9 for ; Sun, 13 Oct 2024 07:56:47 +0000 (UTC) X-FDA: 82667822622.06.9C82E3B Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf25.hostedemail.com (Postfix) with ESMTP id D40D7A0012 for ; Sun, 13 Oct 2024 07:56:49 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=OhvQ4iYg; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728806072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IS5ld+TSbl+kNeWYScFUSy7z01NMJzyZaBDFgbTS7x8=; b=HwiunOrtSiFyApQzyfz8hEzmcQ5aUrOMT/x/uh0sfjoUso38HXrZVDUSlCYopnbmM2PqE0 RlU/pqjKCuBgBBA2izV9vJaHSo4t8Pg8kwsTnIkT2nffsJBUC5800D337Kw6YhwdSrajK3 Q8+LfdtOWq3sHWpiRLdkCuLp1KCjN24= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728806072; a=rsa-sha256; cv=none; b=vqT7ZHydxGKUJNzVspg+Et118e0bnACN/C5Se1IEeiz0dwszI7JCajs7x43D5SpWpMYGus DT7BGwtEamCKJ0xuwSikQH0wgHXRxD9Z0UXODGCWsWM2ep+Jx3eQFkSUoBKse7JJvwZ3Yl hWr3HH1fxkSdI3gVz+AVnqTvid/VTEI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=OhvQ4iYg; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Sun, 13 Oct 2024 00:56:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1728806210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IS5ld+TSbl+kNeWYScFUSy7z01NMJzyZaBDFgbTS7x8=; b=OhvQ4iYgQjx1Ivs6+rhB5cpNBwGPd/E5l5cDdaNPjVzTE/2cfC+hf2xYcTR/DKozTU4ojp Qlm26be7xHp0rZ+QnStIMg3L+9bCvlr04ioz18Z3+NkoWCTNc702C5gPCjnTBW+3Q8VuOc oOKozOG5j3pb4yABfFfmnMxsT2Vgw8w= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Andrii Nakryiko Cc: linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, peterz@infradead.org, oleg@redhat.com, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, surenb@google.com, akpm@linux-foundation.org, mjguzik@gmail.com, brauner@kernel.org, jannh@google.com, mhocko@kernel.org, vbabka@suse.cz, hannes@cmpxchg.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com Subject: Re: [PATCH v3 tip/perf/core 2/4] mm: switch to 64-bit mm_lock_seq/vm_lock_seq on 64-bit architectures Message-ID: <55hskn2iz5ixsl6wvupnhx7hkzcvx2u4muswvzi4wuqplmu2uo@rj72ypyeksjy> References: <20241010205644.3831427-1-andrii@kernel.org> <20241010205644.3831427-3-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241010205644.3831427-3-andrii@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D40D7A0012 X-Stat-Signature: az4wjhau33d8rzoodcsipt7fx5amjohc X-HE-Tag: 1728806209-543527 X-HE-Meta: U2FsdGVkX18esHv2BXucVCWG09gl5NkYMJqWF3a3dsqjsuF4RaYiOlCYkJCuaqmFdddzQhIYluitkcpTOADWbj5rSXKytG7RLwWGl9DLBTkpvb41ieAw4EywAGoWx6XSDgWUJ85hm6DG0YQYhqHfxMtCFwPia6A2TUjdrSZmBur9zK3XRsqrBZM8Wlu75HiiVj8gda+iS4etMY2YgIeMx+y8/npm/ddGjgr33Kq2O7oisabGRrCiGsFQkAvNVlsg9VZYQ69wNri81Xq3eZBg/3aeF9UBZhnfNCmpoeX5Y/yDbkOblyNgdUQWMiv+YEVv9pBxnirq1J/ZwEN6KB9SeA2O5sTBgd3JvkqeDGlAzeVl+TJyUTxUqWyA1Mvf9/16GcUAA2D9yscSZV6O7wRk/WmZjolOvf91rWP7nTCJUlMi7+hNrlQ57zs0bEjlqwERzEVLQWMZKqFzh4ebx/G91pRtGOHBGawmv76QjzF1giH2Wtvv8sUHkQHbYgW327RHL5N03OtWYfsQBmomZdwdckxySHHhaunABUPykwAypMN3RZI+khqfbVYeQ5PogPmoBpEKMJtnd3w8wtD5HkImyoUfFq+PSgsy3d2l3YlXu7zkIEjy5NTSYzAzcIpTVHLu8//NdddiiBs82CPLXXkNhqYMEiT24w0QMMRsN/00uE8tg+98QxAwMGJQqzkI2EEWsmWMx3kEFAz4UN0FCTQiUbAQKBcW/02VgnbEHQZ3CqqvlySSQERaTu8P1bGcRLG3QTFRVDlE4JO6OlAZ/QccOgJXNm2QNjSJqfzJxkwlqoR2RqGZjDvTsT0XBmIt6jgLJ0DSyPDCtVYJkHPp9yjO+8D1Q13Lmj9w0aUj/rloLB6JQEZMjzzC2jgJAAVSET/6uSyyCqLvL5sGQH5Eh1TZ2hUFFTvYBiQWiqPljqRfwosRH2Lcla7SkxQZH0r04tjuZ2DP9TxGALbyl0xlQ9N XRsMIqzj RNj0gEZ1Mg2WDI5XkUBJacnU1m+mRwngVgVKPS+jrOlWcI0kwdJQolY53BWRDDb3AAQ7rfuZL1Xd1LcYShGIZiyLufc6HYJeDpXQcNYFTco3U36INv5l8JKiBPspSFlkt6oGm75GuDPzOQiosMyMRlEiWmREosCkPGuWtYgOn/nfr7On4cvdQXb956kYYadw8uyVrshUtbMhHrjqc8mXnt7QgDkPkZw5G6enmOKew6sq0rTFD0cQiLCF71Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 10, 2024 at 01:56:42PM GMT, Andrii Nakryiko wrote: > To increase mm->mm_lock_seq robustness, switch it from int to long, so > that it's a 64-bit counter on 64-bit systems and we can stop worrying > about it wrapping around in just ~4 billion iterations. Same goes for > VMA's matching vm_lock_seq, which is derived from mm_lock_seq. > > I didn't use __u64 outright to keep 32-bit architectures unaffected, but > if it seems important enough, I have nothing against using __u64. > > Suggested-by: Jann Horn > Signed-off-by: Andrii Nakryiko Reviewed-by: Shakeel Butt