From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BA9FC6FD1F for ; Wed, 22 Mar 2023 08:18:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0DCD6B007D; Wed, 22 Mar 2023 04:18:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBDEA6B007E; Wed, 22 Mar 2023 04:18:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B86E96B0080; Wed, 22 Mar 2023 04:18:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A7BEC6B007D for ; Wed, 22 Mar 2023 04:18:03 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 783E61A03BD for ; Wed, 22 Mar 2023 08:18:03 +0000 (UTC) X-FDA: 80595831246.03.85FE591 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id 5677B1C0016 for ; Wed, 22 Mar 2023 08:18:00 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="dJo2/XNA"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wrJhbWHZ; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679473080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yaCVa54jTiy0sgc0DeIq+Nm9gEuRnN1h71KkgJKmB4E=; b=f7GyauP7yDlARej9pjeYRNH4kKb9wURpe5cXKMD3mPpi7j8gVNI+I23pZdIY3qe6oK35yc LAxp/2y57m9zzja3UXfQM9fvWHk5zf2H0fzGgPpdY064QUWKIvjVBRg2edHzxgQVjgUocU kKUQN/Mv/YPSe5ty7o/wIMJ8XjM0X8I= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="dJo2/XNA"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wrJhbWHZ; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679473080; a=rsa-sha256; cv=none; b=V1+pnxItOPbAi0I8744P9JONbc4ltp8PKvv1nluvPGabbjS7KSc2+JdJYJZhczozoOgaht VzG67Bff7i7E2oXVsxcVhpmkE8qiTGLjcP0isshus+YJ05vjOQLcOYqDibAvWDAlW1TSoR JdYWc0H6UAofS7rils3h79yrd79xpzE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B462920B2D; Wed, 22 Mar 2023 08:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679473078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yaCVa54jTiy0sgc0DeIq+Nm9gEuRnN1h71KkgJKmB4E=; b=dJo2/XNAugQ+AaQYit0oTk7CuTVIeaxtvGeZTEB6kdq8JaGEYVpMvNaqUqTck9T6OTit1C 9RUYYtLNzOUByH+AcN1iCnDnsu08jYEn1qZmuVVVhFDMkjrbcy1tQB+6kY/2aGGnMgRMod 9poTiAg/NgHvbzsi9Zbqht9jl7LlS5g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679473078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yaCVa54jTiy0sgc0DeIq+Nm9gEuRnN1h71KkgJKmB4E=; b=wrJhbWHZK7vewa10Gts4vVrvtEjZ24d1g+UpMC05Gra3buqFZ4mZ0DmOo/Kg2v9rHuIz9C ofh4C9Q1FGJ9s1Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 916EA138E9; Wed, 22 Mar 2023 08:17:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0IDYIra5GmQPNgAAMHmgww (envelope-from ); Wed, 22 Mar 2023 08:17:58 +0000 Message-ID: <55f3b07b-13dd-f7a1-8d3a-bc79ae1b4f50@suse.cz> Date: Wed, 22 Mar 2023 09:17:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 1/4] mm/mmap/vma_merge: further improve prev/next VMA naming To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: David Hildenbrand , Matthew Wilcox , "Liam R . Howlett" , maple-tree@lists.infradead.org, Vernon Yang References: Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: pr6aumwuf5hjrdexujx9gfyex7j3ykqf X-Rspam-User: X-Rspamd-Queue-Id: 5677B1C0016 X-Rspamd-Server: rspam06 X-HE-Tag: 1679473080-472902 X-HE-Meta: U2FsdGVkX1+eHW5Iz/in8CK/mSeqk6k3a7QwhVNEUo7gq8V5ezdyxoZV31BO2HZK1BEQcHp9Nx2k4iwB1kljaC4qPLJYKiHkEQtghLcMOC88Ve4wTurWYNyoWJJO/xvhk1Oxj+4OTHSnkSyZrMquj9egrlBQjxQWQGzeNaidRJ17Yu9oM/d7MK63rUOnfFEGoj+a/H0VoJ0asQ7PpdqkPWavzOUEiS1694+Rn1Q9d1hWgR9oeXZSDPqNSikOIv8zVnuI85n42qnnl2UdpjpAQV5Om816nnCYCtrtRrFdQOOSqqFh5lkpdoyIAPCgr9AcjIg5PviwNgt96mSLRT3d+n8MDIgQDYiuPDfOdl8vbDDJeusn17OaQOhOLfqx6CSDLeXUy71kj6mhXOO0PpIaOePT7ecZsHhI0vKZ63gBOjRKKQtNilDoxM5Fn4oVrhpLEiRZ7aM9p5IlcW0NvvnIwBoFhaENXdnUQUZC/8ksZIxrcinhlGaBC10fBhmQEr6/X4n8qeXkiaraScfkW02FerFleyRYaqXTzQEnj3PNTU9LQBhUNN/po//yLqjR6VCBpDK36RLn30JNXHAamoU+NqZy9hHI4kD632yPzP0LD/t4WmkehwsDH79CD0DTPNB27Dayi+/a9dz8JPSbDcl/8Mz0g6B1qrYWfnQBucLh5/u9QQpQ8gqewSoNrO5fhQ6OY8u2xfLg+EisBk4eUCPbb8yToyVz0kmuWHmwnK57QQVIF/wp4BPG2iAxrlO07hR6zV554gcamciINYEWuH4lcKjmDzcC3PpVUV3s6CzaaazrM0jFXUAE2syz6W1CTC2Pweu6AclkKQjqhkC150HBB+JS+1osZ37LFaM9PCH+vnzk1CsxPG85B2xOqffT6pz1Bvfwl1nxAfAbk8lAjsnQIBbKuujrmTg2kizp+zDS7iSmqe42y/dvOn6Jfd0G/F4wnO/gsHTeX1kWldl26Qg 48gCLwcV PJFbTi2EsDQIDXKIGkZQXKbOJUKTo1yzhKRQiKVd+9s/vhkvDZSmegkmSIOx1K1tTAcoWod227BDMGe22fX7loGoDt8mvpjsyXc63Ga7eGWVVLOC979VVL87ViyTp8JvqA8bSbFQUXTCHKKFUD0gN4J5oaeuN8oDxXiyCPAGtlSblNIdIwThV+PT0cWG5JAPazah8OXMg7s6hAswX5/IMUIJNqiAjxNT4PJ1OaBirEL8Vc4M5b2hPnOnys9cgU+aHxXq+AXqqu12j4PmL004foPTUyTwiLzwLof2Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/22/23 08:13, Lorenzo Stoakes wrote: > Previously the ASCII diagram above vma_merge() and the accompanying > variable naming was rather confusing, however recent efforts by Liam > Howlett and Vlastimil Babka have significantly improved matters. > > This patch goes a little further - replacing 'X' with 'N', which feels more > natural as this represents the _next_ VMA and replacing what was 'N' with > 'C' which represents the current VMA. Might have wanted to mention the 'A' to '*' change as well? > No word quite describes a VMA that has coincident start as the input span, > however 'concurrent' (or more simply 'current') abbreviated to 'curr' fits > intuitions well alongside prev and next. 'curr' sounds good to me, I concur > This has no functional impact. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka > --- > mm/mmap.c | 86 +++++++++++++++++++++++++++---------------------------- > 1 file changed, 43 insertions(+), 43 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 042d22e63528..c9834364ac98 100644