From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 191E2C7EE2E for ; Mon, 12 Jun 2023 09:54:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A96E56B0075; Mon, 12 Jun 2023 05:54:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A470B6B0078; Mon, 12 Jun 2023 05:54:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90EE46B007B; Mon, 12 Jun 2023 05:54:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7F5556B0075 for ; Mon, 12 Jun 2023 05:54:58 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4C561A01A0 for ; Mon, 12 Jun 2023 09:54:58 +0000 (UTC) X-FDA: 80893637076.15.035D138 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 0C7E6100005 for ; Mon, 12 Jun 2023 09:54:55 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PLhjE2cO; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686563696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2+lliQQv0MFqMy2/MjnJS4GgfZK9CtTvSlEKJTTXlR0=; b=fojuzfHCk8Le1grAnHl+03JANOp6Cj1QpQX5jHMUdqF9nPzmy+FRE7x7m2j1i5xrpzsoGc 1tnEGQCpGnzg5rs+H3Q7e1Baf2qpNs71cyjY9oiuMx8aLD1ATjCoDx+cadUOzt6vOPHSCB EfNynEurHRWsIzWRXkmsXDwF99ykVxM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PLhjE2cO; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686563696; a=rsa-sha256; cv=none; b=jOQMFpaJ2hwLkeG9VM3r9H7VjhCw55WGhOS1Q9F5tG+9FlJDBw0pqPhb1nGyK7o/0JA5f+ yv81l0EVt+HyNQarCNW8S0GPtAmxwnxj0Vmke5lHP7JCS9rB4jLcFSlmAWEOam6JYTIJjs uNX9Tf3yWwl96OXplVwXQjmQz4cUnUE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686563695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2+lliQQv0MFqMy2/MjnJS4GgfZK9CtTvSlEKJTTXlR0=; b=PLhjE2cOkvZjSsmAnl3i0mZFQuC6xt0XsJY5GhMgtI48ax5PWTwfkxhQqGNniGrDmYwYAv mph2HKY4PItzozhlPYa42s8YzJ1kcDRQTPA1pbLPVswc1iu+sFjSJDP8+dRg1i7Klq2nMf TIfudVp6KpX5zLj1VG5CKNA9YARlGaQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-Zf1EMBOkNHqeoj57sB19-Q-1; Mon, 12 Jun 2023 05:54:53 -0400 X-MC-Unique: Zf1EMBOkNHqeoj57sB19-Q-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f81bdf4716so2852115e9.0 for ; Mon, 12 Jun 2023 02:54:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686563693; x=1689155693; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2+lliQQv0MFqMy2/MjnJS4GgfZK9CtTvSlEKJTTXlR0=; b=ZrHJj6QsTDgc3z40VLYJm+TaPo38qM8VdJi4N5oPjoWXNQurOkrfPgarYDIhFK/tX8 i8paYfUHyCXOCTOmgiMjiKmViAomgvXySrCTg5DPK8wTmoeGxZiKKmX9wflWiPR8ravf 7pleBuU3/WhgC0eDkfNDhAQ0AfbLdChV10XfQjEpcjadoCGVw7QFSxS88EgqJdkX/sGU O9zWJ9l7QL5EeetYkQS5F73I+pnz5L52Cm1A2fk0O33o1Po0nxrAZRVS9t//Nc8mm4ol NW4zc8uf1EV7yKx4zwmId8ccaGO4Xi4wwPmU5WpwCAwV2YUq6s7ahFkxIP3FkEfECbzx 9cWA== X-Gm-Message-State: AC+VfDxWMLkH14KRO58RamFIehHERO1VREDnKQop4Bn1NR6yU1OkCdhO Fq5ZOJL95T+A7tHvvuxdFY7qTptn+yuotEuOlHVE2yFffQRObPr3f5KPntdcV41QX9y2aYaLfxd QyUOp1GGHWd8= X-Received: by 2002:a1c:f70e:0:b0:3f4:1ce0:a606 with SMTP id v14-20020a1cf70e000000b003f41ce0a606mr6887899wmh.1.1686563692838; Mon, 12 Jun 2023 02:54:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7zaoW/4EJw3xh9E18HQ7DmUYd+SNWO5wWCUYsDX5fhzMtWJef4K3YX9DfpLzkdvYrozazasg== X-Received: by 2002:a1c:f70e:0:b0:3f4:1ce0:a606 with SMTP id v14-20020a1cf70e000000b003f41ce0a606mr6887887wmh.1.1686563692460; Mon, 12 Jun 2023 02:54:52 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e? (p200300cbc74e16004f6725b23e8c2a4e.dip0.t-ipconnect.de. [2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e]) by smtp.gmail.com with ESMTPSA id i12-20020a05600c290c00b003f7e653c3e3sm10904071wmd.21.2023.06.12.02.54.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 02:54:51 -0700 (PDT) Message-ID: <55e05ac0-041d-75eb-4707-e053dc3f2976@redhat.com> Date: Mon, 12 Jun 2023 11:54:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] mm: compaction: skip memory hole rapidly when isolating migratable pages To: Baolin Wang , "Huang, Ying" Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <8cc668b77c8eb2fa78058b3d81386ebed9c5a9cd.1686294549.git.baolin.wang@linux.alibaba.com> <87sfax6v7c.fsf@yhuang6-desk2.ccr.corp.intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0C7E6100005 X-Rspam-User: X-Stat-Signature: tykc64ye9jd8wnfieaai3t65ytktfadq X-Rspamd-Server: rspam01 X-HE-Tag: 1686563695-829764 X-HE-Meta: U2FsdGVkX1+Gm7K2K4RIQjmVrt2q0YxnmZ8u4v3O31lKIqzky0j7ZGXYTQ2rtCCCRUvrODSpzqoP25RUNDXzSvBCEYKuBLuuC9wmLzCTUIep3T9y5PK46x+WNOMQoZWBjSQm9vQKw9qknc9V2uRCDmycin7YpSDPRGdTkI0cyzQthOlFzaEyMWmp4fxrsQRMGb9DCaChvFz87BKopJb2mxzQ9uE2qkeiZ3XU3FHKhIti/UOMQ245L0Ezxf6rGmaQMtq2hRKGT4UF+F7+oLrztGkQbRJjUSQ9W69f7fMeAkmZmnhFJnrWPAxXIH1lIGUdRJtUNak6htIoeS6nGz4fydGL7++CQ+4FTf0aErpwoVZIj++Z7TXoUqw7/jcDDKCHekddPcejXLiA6KczFye449xW2RE5ATvAnJSxEe2NCh9q377g0gtteAG28i2QoTbZDJFG3ayv/O9gkNQhMqCJQlALC2ln7HP05371IqS/GTA/g+rL4G+V5xIShPpLZxVaA17e43TacOGDO11o/48euw6JU1KOT6HkCudsFjb6UsZzbAgUpNZN+vVPACSffXvShhwr3q6D8WaNxDbklBn5bBKVP3LjXYDRbdwSeNaQsN9/uN1hniaYlDyjaUVqY9fNUQSDNoXh8fF0glh+GT6+cssn+sghePPyargJN8qnaIPhiDnuRfLO0EBKpIXn8K4zvh/IS23p1iRfT5ROLCFjaiHY0B7Q+dxbi0sB8EcV94Ou3hOoaXVj8Opo6pnMHmjXb90C9sJuCDBDo5dLq7R3ZG+r2uJ9N2shpoUMQ2j7waRRn89NASQpjOhcX14lEQdHL/7vWzc9fkRXd6TMNRccQBcJAScn/X1TCy+wRU8K6YwiXduFHqGd/BhnYO25Gs0XjfW6xUDmVxht4CjfpNyEgfXaHo3WpLPwGiTnGKgdCEK0RDjaihATcTnTktIsjfecLtLozd+qxCaPCL5Vjo+ mqw0h9sH 1dY7HqeCorreOXNJKr3jCn4hHQftdu2tTAw8Q2+WXqqmhPsnfXLDjC8KVAtvST9HP5rm6yiDegdznU1glW12ko6CLLLk3TBwi2MliG6Cwe1qUuDgJqsyIGZgMvq6Ub4fv8otSjRikpvowFj6ongCKkAykaZkFOVLDuUMJ6XgDPBeDpOtM4hpC0TnaXtydzoe9MeXpnty4Th3b6FaCXQRmiYFBVE9uivOanLsgXdvczmLYhqp2o+vNvbx/PtZHokxtLuIOnhpokyQN1kKKsjF1bpUAk4vYdkmJzMg5G6I6XxiLQXAH7z2kcjNXajAKFkYSJLpLn7riOYwDyWLiLIPF5AOc1yPhvQT9KSHNWCnu1KyOLsWP4git6O83ru4kWvWhhV2T0U7MsXe+L2qYbhvFLpt2E1DrFbjLvWSH0Ofsx7goSBmhSTYPzB5cvpNydAF0pQN6RyKvIOdTH3SjriViAEEAwcW1i9Wyltk2HHMkQAfUWDA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.06.23 11:36, Baolin Wang wrote: > > > On 6/12/2023 2:39 PM, Huang, Ying wrote: >> Baolin Wang writes: >> >>> On some machines, the normal zone can have a large memory hole like >>> below memory layout, and we can see the range from 0x100000000 to >>> 0x1800000000 is a hole. So when isolating some migratable pages, the >>> scanner can meet the hole and it will take more time to skip the large >>> hole. From my measurement, I can see the isolation scanner will take >>> 80us ~ 100us to skip the large hole [0x100000000 - 0x1800000000]. >>> >>> So adding a new helper to fast search next online memory section >>> to skip the large hole can help to find next suitable pageblock >>> efficiently. With this patch, I can see the large hole scanning only >>> takes < 1us. >>> >>> [ 0.000000] Zone ranges: >>> [ 0.000000] DMA [mem 0x0000000040000000-0x00000000ffffffff] >>> [ 0.000000] DMA32 empty >>> [ 0.000000] Normal [mem 0x0000000100000000-0x0000001fa7ffffff] >>> [ 0.000000] Movable zone start for each node >>> [ 0.000000] Early memory node ranges >>> [ 0.000000] node 0: [mem 0x0000000040000000-0x0000000fffffffff] >>> [ 0.000000] node 0: [mem 0x0000001800000000-0x0000001fa3c7ffff] >>> [ 0.000000] node 0: [mem 0x0000001fa3c80000-0x0000001fa3ffffff] >>> [ 0.000000] node 0: [mem 0x0000001fa4000000-0x0000001fa402ffff] >>> [ 0.000000] node 0: [mem 0x0000001fa4030000-0x0000001fa40effff] >>> [ 0.000000] node 0: [mem 0x0000001fa40f0000-0x0000001fa73cffff] >>> [ 0.000000] node 0: [mem 0x0000001fa73d0000-0x0000001fa745ffff] >>> [ 0.000000] node 0: [mem 0x0000001fa7460000-0x0000001fa746ffff] >>> [ 0.000000] node 0: [mem 0x0000001fa7470000-0x0000001fa758ffff] >>> [ 0.000000] node 0: [mem 0x0000001fa7590000-0x0000001fa7ffffff] >>> >>> Signed-off-by: Baolin Wang >>> --- >>> include/linux/mmzone.h | 10 ++++++++++ >>> mm/compaction.c | 23 ++++++++++++++++++++++- >>> 2 files changed, 32 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >>> index 5a7ada0413da..87e6c535d895 100644 >>> --- a/include/linux/mmzone.h >>> +++ b/include/linux/mmzone.h >>> @@ -2000,6 +2000,16 @@ static inline unsigned long next_present_section_nr(unsigned long section_nr) >>> return -1; >>> } >>> >>> +static inline unsigned long next_online_section_nr(unsigned long section_nr) >>> +{ >>> + while (++section_nr <= __highest_present_section_nr) { >>> + if (online_section_nr(section_nr)) >>> + return section_nr; >>> + } >>> + >>> + return -1UL; >>> +} >>> + >>> /* >>> * These are _only_ used during initialisation, therefore they >>> * can use __initdata ... They could have names to indicate >>> diff --git a/mm/compaction.c b/mm/compaction.c >>> index 3398ef3a55fe..3a55fdd20c49 100644 >>> --- a/mm/compaction.c >>> +++ b/mm/compaction.c >>> @@ -229,6 +229,21 @@ static void reset_cached_positions(struct zone *zone) >>> pageblock_start_pfn(zone_end_pfn(zone) - 1); >>> } >>> >>> +static unsigned long skip_hole_pageblock(unsigned long start_pfn) >>> +{ >>> + unsigned long next_online_nr; >>> + unsigned long start_nr = pfn_to_section_nr(start_pfn); >>> + >>> + if (online_section_nr(start_nr)) >>> + return -1UL; >> >> Define a macro for the maigic "-1UL"? Which is used for multiple times >> in the patch. > > I am struggling to find a readable macro for these '-1UL', since the > '-1UL' in next_online_section_nr() indicates that it can not find an > online section. However the '-1' in skip_hole_pageblock() indicates that > it can not find an online pfn. Maybe something like #define SECTION_NR_INVALID -1UL > > So after more thinking, I will change to return 'NR_MEM_SECTIONS' if can > not find next online section in next_online_section_nr(). And in > skip_hole_pageblock(), I will change to return 0 if can not find next > online pfn. What do you think? Well, 0 "might be" (and most likely is) a valid section number, so you'd simulate some kind-of a wraparound. I guess I'd prefer SECTION_NR_INVALID instead. -- Cheers, David / dhildenb