From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEBBDC432BE for ; Wed, 1 Sep 2021 08:04:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 64B4B6103D for ; Wed, 1 Sep 2021 08:04:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 64B4B6103D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EF8F18D0001; Wed, 1 Sep 2021 04:04:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA9366B0071; Wed, 1 Sep 2021 04:04:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D98998D0001; Wed, 1 Sep 2021 04:04:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id CAE8A6B006C for ; Wed, 1 Sep 2021 04:04:34 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 82E1E1800EAEA for ; Wed, 1 Sep 2021 08:04:34 +0000 (UTC) X-FDA: 78538267668.38.80AD46E Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf27.hostedemail.com (Postfix) with ESMTP id D51E7700009B for ; Wed, 1 Sep 2021 08:04:33 +0000 (UTC) Received: from dggeme703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GzxQX6Wt1zYvtS; Wed, 1 Sep 2021 16:03:48 +0800 (CST) Received: from [10.174.178.75] (10.174.178.75) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Wed, 1 Sep 2021 16:04:30 +0800 Subject: Re: [PATCH 5/6] mm/page_alloc.c: avoid accessing uninitialized pcp page migratetype To: Vlastimil Babka , Mel Gorman CC: , , , , References: <20210830141051.64090-1-linmiaohe@huawei.com> <20210830141051.64090-6-linmiaohe@huawei.com> <20210831134311.GG4128@techsingularity.net> <00a73cf9-b2e8-116b-dc9c-fc5e2aacb1a1@suse.cz> From: Miaohe Lin Message-ID: <55d7b921-f51c-0c1e-82a8-c9e6148e2115@huawei.com> Date: Wed, 1 Sep 2021 16:04:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <00a73cf9-b2e8-116b-dc9c-fc5e2aacb1a1@suse.cz> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.75] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeme703-chm.china.huawei.com (10.1.199.99) X-CFilter-Loop: Reflected Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D51E7700009B X-Stat-Signature: 7wyjx9mmozs9t3c9noucyeok3own6wu8 X-HE-Tag: 1630483473-4979 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/9/1 0:34, Vlastimil Babka wrote: > On 8/31/21 15:43, Mel Gorman wrote: >> On Mon, Aug 30, 2021 at 10:10:50PM +0800, Miaohe Lin wrote: >>> If it's not prepared to free unref page, the pcp page migratetype is >>> unset. Thus We will get rubbish from get_pcppage_migratetype() and >>> might list_del &page->lru again after it's already deleted from the >>> list leading to grumble about data corruption. >>> >>> Fixes: 3dcbe270d8ec ("mm/page_alloc: avoid conflating IRQs disabled with zone->lock") >>> Signed-off-by: Miaohe Lin >> >> Acked-by: Mel Gorman >> >> This fix is fairly important. Take this patch out and send it on its own >> so it gets picked up relatively quickly. It does not belong in a series >> that is mostly cosmetic cleanups. > > Also Cc: stable, please. > > Will do. Many thanks for both of your suggestions! > > . >