From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F587CD128A for ; Sun, 7 Apr 2024 17:12:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D75316B0087; Sun, 7 Apr 2024 13:12:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D251B6B0088; Sun, 7 Apr 2024 13:12:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA03A6B0089; Sun, 7 Apr 2024 13:12:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 968C16B0087 for ; Sun, 7 Apr 2024 13:12:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2930CA0207 for ; Sun, 7 Apr 2024 17:12:10 +0000 (UTC) X-FDA: 81983378820.30.D090C30 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf11.hostedemail.com (Postfix) with ESMTP id 2BD2D40010 for ; Sun, 7 Apr 2024 17:12:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KsrQTHf7; spf=pass (imf11.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712509928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3qCUriK+M0jiIXILb+tuB1UUD9u2BDme31WEMqfwtns=; b=F7Cd1YtyRnx/or7a55CzoNxBhnM+Am+4DoiaRBKsW5/JRk0DFALUWlqw40uLDmEMFycPLB 8ziwGHCIA55Ei6vBH2uzF31gmjn1kZsOkxus4IQabYHQtoMKqxqxyGZ7DvefJpjxw9JUZr Soi1DCMfovkpLX5h+hGWfHsUosXxwy4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712509928; a=rsa-sha256; cv=none; b=gnLpGP22QRzVHX/VJJFuanzJXJNG+zQvrHuvapfTNUY+Va/vdbNfiOM9vyYv0XHrKUkHaI kJliIQ8YRylYdfZm3OPGW8piWuHg4dq9Xr5a6KRtGXzkTkLemWkt9JrByJlhRnviTJHYDi vJNusMFOEpJRgMcgpvHUgHFqqodr53A= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KsrQTHf7; spf=pass (imf11.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-516be63af88so4066170e87.0 for ; Sun, 07 Apr 2024 10:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712509926; x=1713114726; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3qCUriK+M0jiIXILb+tuB1UUD9u2BDme31WEMqfwtns=; b=KsrQTHf74xoqtIJDebXdN4wiOxPvWjmgUUBhkKpWOZOZFnGij1HIbwZDjjMw5zuS3i JmvKQZx4EByI3Uix+2qSQHuqCLQDl1H5PvcroAGerHmPxwQsWpBm91dqXynWlKnMbihb fZ9SBAFg4AMXfsYa8V9AY9UOooe/ZGVpFrEUwgr2nxkWBH0XaBV+VXCgS1XK8MYNaUaZ VKVutranV0+9TvCDds7LOW28Ywakaq8O45FDizo5Ei7OTvvKpHxXu/iZN3lqy5ZdV80Z e//xlAJr9ljHysganA/Lf1hQO7uKoPAGo0XyNraoUAaIXkBTbGbzlu5IaSzazhRqVnAI XZvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712509926; x=1713114726; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3qCUriK+M0jiIXILb+tuB1UUD9u2BDme31WEMqfwtns=; b=C4YG3JA/DSPAlOuQC40njFFojzWVbhv/CpRuSMe+OS+irNHXU1imeuLJ2amivL374+ xj++pkxZQ5s9laSJxGopR6f6W6m0UAZkhCSxuoX53PkTKYaQgobmZZYp6Y2DXLdFp6Zt yGZXx+U+uUoJqjY7JvK7bcPJRBp6dbd7I5yyuN3iBp7kLjm3itAjoIl6FUcnaZQ/CnU0 xdRkNY+Jk/MX+/wlDsdUNekrWKvhVB0em3xX+iWsMU74puMCySHGpdc3xGUI5qDPK61O 37Fph9kc7qW/xvmmFOcuVydp95WC8JIbtBUz3rNk5wBPe6egwhUdS+BzhZur3GmdJfLk XtUA== X-Forwarded-Encrypted: i=1; AJvYcCU0EhURox7j/QgDeHVSGNHPa+V44NYAZQeeTJo6/PvEp9K9MqYumaUVHPjcoY2eMTGDMBLeRJcdVEQ5BDgbwkscnfo= X-Gm-Message-State: AOJu0YyO5dI6G1XfnlGyNdahGktezfyYy88jzFLxEcH15PYptAxXwJaA jgorMhmvvRX5GYjNjjl5//aHuS8FKqshz4CtKXlfL8FtL2OWCFKQ X-Google-Smtp-Source: AGHT+IHtaIccuyFUdaKKa2Zpdn1UYBrvGIcS+CFd9LibEYo3spBXmcNmUNHFqmPVcKYM58FADUip+Q== X-Received: by 2002:a05:6512:224d:b0:513:cf73:d8d2 with SMTP id i13-20020a056512224d00b00513cf73d8d2mr4282714lfu.54.1712509926074; Sun, 07 Apr 2024 10:12:06 -0700 (PDT) Received: from ?IPV6:2001:678:a5c:1202:2659:d6e4:5d55:b864? (soda.int.kasm.eu. [2001:678:a5c:1202:2659:d6e4:5d55:b864]) by smtp.gmail.com with ESMTPSA id x24-20020ac24898000000b00515c1b1fb85sm870313lfc.233.2024.04.07.10.12.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Apr 2024 10:12:05 -0700 (PDT) Message-ID: <55c71868-e2ae-4095-a5ca-5cdb195d508b@gmail.com> Date: Sun, 7 Apr 2024 19:12:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/memprofiling: explicitly include irqflags.h in alloc_tag.h To: Kent Overstreet Cc: akpm@linux-foundation.org, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240407133252.173636-1-klarasmodin@gmail.com> Content-Language: en-US, sv-SE From: Klara Modin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: caeips7aqah4pkaj4f65oaouyqdbre3b X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2BD2D40010 X-Rspam-User: X-HE-Tag: 1712509927-842588 X-HE-Meta: U2FsdGVkX1942uzJzRkgEy/ylTdf6VLzH/dcboBoSTLee7aKzkyA1cYEawPg6AKIOMOXrZ6rZvMnUnylfljWJI0tvV3t6fgxJfy7vySl5AK3/8PSeIlJCiCa56bBT9FmY2L0CC/uiNQ9YWdideNBAMnpFQ1QnsitJGHPVy2kIcKTManYDl6xX2siEv9lWEv7//DNUQcooqSEKsyMpgDB4i/r3luNrq2C2xH8D3beuE+eAFi9XmEGYOFKdhivm5b/OeEeJU+d66hoziM9kWzpeqqg0nN85u32NFMJxQnt20JP0nSgRAGPTjUMebNJHelSIc+5g4H+SbCq64AvAPNH2giSVy1iRuQC4pLA8XHCVMUVdO3I8bTJT01T6o52sxvrRJw5oGAxq60Cjtj5D+LyebanZ2/7uYZ3SBBaH8lr2hd6sDwZVz7zkKZ2Hidp/GQLjqe6e5iTmAYKrVtW3ob2cPqjBPkF00OqGSNXHMYsJ/gyMu+fcGlOuDSt6S/RW9QeRV2GyI57Mz0jKamhG7IBesZlQW+zdP0/X2TQPcnMGrjw3gizGrWgN7tPPyDgKcHytsgaZY6XfzPC4aWOLWUr4X9ewPLqIvN0oDw19hnvdsfHDU9Jyk0sI3Cwa3cMawY+PRm98UfKDVz/dLUuN2iN042MAbiV9jxJGLKZ0qnBMlKCskM63cZbaepZGVs8z7C0v9gQsYj0+h7JxTx40EFDSxxhqYCg7w8X4iyZBkGIFHITJe5KDKm1l3QhozbfCBpj4xDTMfCqYXxT8O81Lgr569Yl3XB55lsrsOrW8oyBRyy+ufV7bN9VB8/yJ/MEr+cuScMs+CHhLNcooUWTCFGWeKYuY6aA7OmP5NM18RgVhYPGGWEppVC3XOVTUFnWm5G4KXh6CEN6MwyCXQXBo3wqYVBPHyxCiz95PNhpuSqJQvLWQ9UItT+InHJReJHl1T2SaspBDQt3WwaEjkdqQFp kSC0g4Fp Qtax3V039tmdQGYbzUM5OEfsnk84Vyd1tuQeJbHpiZJaCv3j+Rs0ZbyN+gQ1ogZd6LUdFBYgQY/MwfYI8AUQiEXZqt9eVXopVowYMsMgPn8t9GcKJ5uYppL42uZy3QFkLsKFnL7TUUnLBhSDBCTeFA9SZHjmiXtn3WA6t2o6Gq2j+m7e3VVGJ/+rkg6estpvYdwMraet5W8HulmTRAZDrVQp0/wisWzA3i+ObY++rpjPyEIWWrmv3iI9drLBOENh6N5wRHYsUd3aoh28k3g3ApMMDr1q9mb1pcFoJRtbS8xQW5Hi5AsQRyX+uK13dHyMpnUXTpPwZ2GlXb7EVv4XnCP69nPpHCiuzOlqe+Il/2+bqzbcm1/QGe+eoiEBJvykcwGJcVZ0PwcV2zeatSf3pB68PStiLH+D2qT9x2oQcncFVBpXMS3as+KRw3+RB8qnpRQuaMyPm8KUsMzPtdH6RQrwpCerQVjUg28fXbz0smGw54fLukqcxwZvKZ0g/ziJaDwk6ecNupP6Szecs7Mnbo9Hpby9eG83jUEGktybCr+besefr+++9wqK6qFsbc3xdO4L0ouAruirpRSY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.021063, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-04-07 19:01, Kent Overstreet wrote: > On Sun, Apr 07, 2024 at 03:32:52PM +0200, Klara Modin wrote: >> linux/alloc_tag.h uses the macro this_cpu_inc which eventually expands to: >> >> #define this_cpu_generic_to_op(pcp, val, op) \ >> do { \ >> unsigned long __flags; \ >> raw_local_irq_save(__flags); \ >> raw_cpu_generic_to_op(pcp, val, op); \ >> raw_local_irq_restore(__flags); \ >> } while (0) >> >> The macros raw_local_irq_save and raw_local_irq_restore are defined in >> linux/irqflags.h which is not included implicitly on all configs. >> Therefore, include it explicitly. >> >> Fixes: ac906a377c67 ("lib: add allocation tagging support for memory allocation profiling") >> Link: https://lore.kernel.org/lkml/6b8149f3-80e6-413c-abcb-1925ecda9d8c@gmail.com/ >> Signed-off-by: Klara Modin >> --- >> include/linux/alloc_tag.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/linux/alloc_tag.h b/include/linux/alloc_tag.h >> index e867461585ff..afc9e259a2d3 100644 >> --- a/include/linux/alloc_tag.h >> +++ b/include/linux/alloc_tag.h >> @@ -12,6 +12,7 @@ >> #include >> #include >> #include >> +#include > > Actually, shouldn't this end up in a percpu header? Or was there a > problem with that? If I understand it correctly, linux/alloc_tag.h does not include linux/percpu.h (which has that include) to avoid a circular dependency as linux/percpu.h includes linux/alloc_tag.h. It instead includes arch-specific asm/percpu.h, and as a consequence it doesn't always get linux/irqflags.h. It's also entirely possible that I've mixed something up, I really don't have much experience developing for the kernel.