From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A790EC4167B for ; Wed, 13 Dec 2023 00:10:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E3A96B03FC; Tue, 12 Dec 2023 19:10:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36CA06B03FD; Tue, 12 Dec 2023 19:10:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E5B56B03FE; Tue, 12 Dec 2023 19:10:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 07F316B03FC for ; Tue, 12 Dec 2023 19:10:27 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D0592A09F2 for ; Wed, 13 Dec 2023 00:10:26 +0000 (UTC) X-FDA: 81559863252.14.EABEFB3 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf17.hostedemail.com (Postfix) with ESMTP id 183484000F for ; Wed, 13 Dec 2023 00:10:24 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aYHBhY+G; spf=pass (imf17.hostedemail.com: domain of rientjes@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702426225; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/awqNNuuBVdOMOwDFb7/1nEW8nsApwi+stmH8yh+pvA=; b=T5aMn0CE81nhSlbNVlLKc5jmacIvYHPR0Bw57BNKWJ51bL/jXE80A7D8Kmkuly6tcgvtq+ bP2p/OABT3H3LqUSSprMsd5Es5HxtgXmlQ535p/7is+HiZOUss3npJaYPcXAKrGQ5+UEb5 SjGwNXiWr9N84Y30bw1kDJZi8LVZxUY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aYHBhY+G; spf=pass (imf17.hostedemail.com: domain of rientjes@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702426225; a=rsa-sha256; cv=none; b=TUr2KQriS8DygeGTzXwByPqAZH1T/NTbPVrCeOhYQ5TR0ZqqP8k6ha9rr0qc6SqBaodQIs 1fcusD2BC1lGLHSR2rS59dfmjlr0hTBxNiK6zdrncgQE4BaL8whoKqh3AQdSapo3YPBcLS Fjh56dyXejfViu+OMG8ykJ6XsLoJcwk= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d34ae77fbaso60995ad.0 for ; Tue, 12 Dec 2023 16:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702426224; x=1703031024; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=/awqNNuuBVdOMOwDFb7/1nEW8nsApwi+stmH8yh+pvA=; b=aYHBhY+Gonr+a3UcAjfUJLJ6cc8ek4oHxUqsk5SMv5FxROIddMuWRAGGmxquLthtnm 3rUsRYbnznRWr7gcN7wg9SO19hbbhHNg/qZmDQ780GJ63kQtNJmlK7YM7ccIHbrBp8HB Banu9skdw3YB7V84E7GqRB5V5QoMYOtkNcZ1euFtXhZMZcldGBxsBvJ+UtF2vw6szwz7 ByJbtG6y1+8RWfAKbp/FXehp26ZZt1P5+5zxbVRB047Rh4nUxQfuD6pLSiyWw5MYKENs n54SjNM8FbG5DsrKSwE08H+31qWA9GU355X6H9Oqf2UCPE4JFdm1Po2VEl3V8Y6rsxe5 USqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702426224; x=1703031024; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/awqNNuuBVdOMOwDFb7/1nEW8nsApwi+stmH8yh+pvA=; b=HtDwMiwNdMtwAHOIXjWwo4rOlHhBXu4gnWI6i5zcDjytvfeGm0ZJSjDzFEgyKBvBsL PtskJPPxBYzj0NTMn0P++Su0JAPv3EGlWcZ10x0H/KjnqNeTeQzeb1Gv1oTHKCfL0sE2 Q5dyoVx4+QeIIGjkjOcB4zLBEuvg5y7wsLbNepqFtOI8fP5gBUqctV6wsimydvn5BEYM 8WAYft8p6tUNDCpEWX47EyfWyoY+RTiKyG05/jdjnz0nH+1mWBIBEok2WTpHZ3aIilpK 9Bw05kHDcdoP7orLVjmiVCXRuPX+nvIjdxiAHjD65NfGuY4IBwUFvFV0/EmjyGzAQ+C3 tB4w== X-Gm-Message-State: AOJu0YyftMxDDbBoqXUo0CtjYEMCsmH8scYzgLxSGuEWHyVLzSeIW+Tw d2/jAN735tw/cq5LBzhvoM3L+w== X-Google-Smtp-Source: AGHT+IGcYgMZfthZW8oEln3UOI7eJLeysSJbN4H/5YvLwIiX4bJrWyLcr2xf3zrBbGW7JFZ5tRClKQ== X-Received: by 2002:a17:902:d2c2:b0:1d0:c25b:5733 with SMTP id n2-20020a170902d2c200b001d0c25b5733mr973517plc.18.1702426223687; Tue, 12 Dec 2023 16:10:23 -0800 (PST) Received: from [2620:0:1008:15:fc81:e0ce:797b:3b4b] ([2620:0:1008:15:fc81:e0ce:797b:3b4b]) by smtp.gmail.com with ESMTPSA id h2-20020a170902704200b001d06b63bb98sm9178392plt.71.2023.12.12.16.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 16:10:23 -0800 (PST) Date: Tue, 12 Dec 2023 16:10:22 -0800 (PST) From: David Rientjes To: Mike Kravetz cc: Gang Li , David Hildenbrand , Muchun Song , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com Subject: Re: [RFC PATCH v2 0/5] hugetlb: parallelize hugetlb page init on boot In-Reply-To: <20231212230813.GB7043@monkey> Message-ID: <55c6c1f6-0792-61c3-86ed-4729d4a3fdf5@google.com> References: <20231208025240.4744-1-gang.li@linux.dev> <996ba32c-78f0-1807-5e64-af5841a820e7@google.com> <20231212230813.GB7043@monkey> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 183484000F X-Rspam-User: X-Stat-Signature: cfmun1b5353x4ssiuf1upmu9xde8gx3r X-Rspamd-Server: rspam01 X-HE-Tag: 1702426224-992168 X-HE-Meta: U2FsdGVkX1+SfWRn7mRSkGQRv3xFVFJ1xrzeEpeo9TJkZCTidpf7rf+S7tGGW166Y583+jkD4Oms0BqNdd935tWZq/L9lELXoQ9JxrjLA7d3TPJ6z/P2OgaIOGmqq7CQiHGOpNypwyhVVEEjJ27oAHwrFZEPvWLvF6Tdv74UruQ6oaUptKcr4jBDwkxWCRi2KSdg3tTDIcMCQrdtVBMebHCRROA8vJIZk0p9gobVP0SfOpDHKjnIzAhYf1qhfjRelgB8efFba4RyF40VDp98XJ699xONppuS+LsJSJC5/+Q38omK2QSB4798TGY2YswWfxruZFcz94+3xKjD6beG0pa+ynL4FYD+kTZxfxXu6BgUAtNVvZZz5mXaFlNLlz07vYQsJlPojlcC0iIUDZ1wlQqCS/2ZI4yTYTqhenf2jBKV1CObj5ZRK0iCA6EETdVpvpm3+eOYLpiF6WhP+dxyV/JdIDqF8LwbablDjre6Jy7iQtYi6DySOzqAGGYwp7nhbtnoXIVU/lODN2TkN2oWgGXPS+QbiaT7THvWGQza5zaFJWdNCPXBNzogmxGyDfwz1zSM5Wd8+KnPqyycvSbeoXWxdw6CUniFeapQhjbxoCEMyNzwxuzMYGFYuVpuu8bKCnhhfmr8/9Ig3I3jDButhgih1FDBA2o0I0bEveNw9FbXltGkn3nyueJB+fo6Q5Z9JQqSKaFXwBp9EVxMxFLTo1shYq9ht62ZEgb8upaTPvC8NwrfT8+D9dPS3wNdU72xrZESB2AZipdA87iJo+HbXzDVmeQ5fnVfDIsPteG0RU6de4+I98KEzhL3Ehi8x/+JbOPvAtrUSiZEwM9pU+zcOMGQ9+k/XX3SCjF6VkIeBcUWUpYuonv+hdFUtFSIHIR5gfBdZd0mphSPjkUpi4nuehzzJRhqzSPuDsXljjNLYHxJcwbHdfcdLcvsHIKizBgY1dHSZnnho0Er8DZiLTj Tkxct9Jy BfzLB86Z+EzlSW0E7rm3zd1eLzEh/L0EmZDtIzQlazn12rhjayhnhuVQtEv+peaakIRT937qRXRQx6NLD54GL3U5imQuAeNcfzteOl5q787RP/RRo3hhqyUPSfcBn171xGzrg1LqhG6HzfqwWLxiJTaFmk7FMXG44+ncUX9a2z0X0zfYw7e7Tyu436C44uYk52sFAoWYuZaPO9pzyxNc5NOpQ2+jtilu251tcaGiyNu+89Zm5kDLdg8llMMqM08y9LaIPAOddYtuSlmhxva8emfixWheqrH5OmAY1bHYOn5tlS1XO8/CwtkJGXXubqFQpNfahGqGNPNG0jVptgEkAfbOb93DkV9HjPznETLf0kv7fDchbf4orCmcKqysICqW4FXAebQHuZf6kVIY7t6rEeXvQWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 12 Dec 2023, Mike Kravetz wrote: > On 12/12/23 14:14, David Rientjes wrote: > > On Fri, 8 Dec 2023, Gang Li wrote: > > > > > Hi all, hugetlb init parallelization has now been updated to v2. > > > > > > To David Hildenbrand: padata multithread utilities has been used to reduce > > > code complexity. > > > > > > To David Rientjes: The patch for measuring time will be separately included > > > in the reply. Please test during your free time, thanks. > > > > > > > I'd love to, but what kernel is this based on? :) I can't get this to > > apply to any kernels that I have recently benchmarked with. > > I was able to apply and build on top of v6.7-rc5. > > Gang Li, > Since hugetlb now depends on CONFIG_PADATA, the Kconfig file should be > updated to reflect this. Gotcha, thanks. I got this: ld: error: undefined symbol: padata_do_multithreaded referenced by hugetlb.c:3470 (./mm/hugetlb.c:3470) vmlinux.o:(gather_bootmem_prealloc) referenced by hugetlb.c:3592 (./mm/hugetlb.c:3592) vmlinux.o:(hugetlb_hstate_alloc_pages_non_gigantic) referenced by hugetlb.c:3599 (./mm/hugetlb.c:3599) vmlinux.o:(hugetlb_hstate_alloc_pages_non_gigantic) So, yeah we need to enable DEFERRED_STRUCT_PAGE_INIT for this to build. On 6.6 I measured "hugepagesz=1G hugepages=11776" on as 12TB host to be 77s this time around. A latest Linus build with this patch set does not boot successfully, so I'll need to look into that and try to capture the failure. Not sure if it's related to this patch or the latest Linus build in general.