From: David Rientjes <rientjes@google.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Gang Li <gang.li@linux.dev>, David Hildenbrand <david@redhat.com>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ligang.bdlg@bytedance.com
Subject: Re: [RFC PATCH v2 0/5] hugetlb: parallelize hugetlb page init on boot
Date: Tue, 12 Dec 2023 16:10:22 -0800 (PST) [thread overview]
Message-ID: <55c6c1f6-0792-61c3-86ed-4729d4a3fdf5@google.com> (raw)
In-Reply-To: <20231212230813.GB7043@monkey>
On Tue, 12 Dec 2023, Mike Kravetz wrote:
> On 12/12/23 14:14, David Rientjes wrote:
> > On Fri, 8 Dec 2023, Gang Li wrote:
> >
> > > Hi all, hugetlb init parallelization has now been updated to v2.
> > >
> > > To David Hildenbrand: padata multithread utilities has been used to reduce
> > > code complexity.
> > >
> > > To David Rientjes: The patch for measuring time will be separately included
> > > in the reply. Please test during your free time, thanks.
> > >
> >
> > I'd love to, but what kernel is this based on? :) I can't get this to
> > apply to any kernels that I have recently benchmarked with.
>
> I was able to apply and build on top of v6.7-rc5.
>
> Gang Li,
> Since hugetlb now depends on CONFIG_PADATA, the Kconfig file should be
> updated to reflect this.
Gotcha, thanks.
I got this:
ld: error: undefined symbol: padata_do_multithreaded
referenced by hugetlb.c:3470 (./mm/hugetlb.c:3470)
vmlinux.o:(gather_bootmem_prealloc)
referenced by hugetlb.c:3592 (./mm/hugetlb.c:3592)
vmlinux.o:(hugetlb_hstate_alloc_pages_non_gigantic)
referenced by hugetlb.c:3599 (./mm/hugetlb.c:3599)
vmlinux.o:(hugetlb_hstate_alloc_pages_non_gigantic)
So, yeah we need to enable DEFERRED_STRUCT_PAGE_INIT for this to build.
On 6.6 I measured "hugepagesz=1G hugepages=11776" on as 12TB host to be
77s this time around.
A latest Linus build with this patch set does not boot successfully, so
I'll need to look into that and try to capture the failure. Not sure if
it's related to this patch or the latest Linus build in general.
next prev parent reply other threads:[~2023-12-13 0:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 2:52 Gang Li
2023-12-08 2:52 ` [RFC PATCH v2 1/5] hugetlb: code clean for hugetlb_hstate_alloc_pages Gang Li
2023-12-08 2:52 ` [RFC PATCH v2 2/5] hugetlb: split hugetlb_hstate_alloc_pages Gang Li
2023-12-08 2:52 ` [RFC PATCH v2 3/5] padata: dispatch works on different nodes Gang Li
2023-12-12 23:40 ` Tim Chen
2023-12-18 6:46 ` Gang Li
2023-12-27 10:33 ` Gang Li
2023-12-08 2:52 ` [RFC PATCH v2 4/5] hugetlb: parallelize 2M hugetlb allocation and initialization Gang Li
2023-12-08 2:52 ` [RFC PATCH v2 5/5] hugetlb: parallelize 1G hugetlb initialization Gang Li
2023-12-08 2:56 ` [PATCH 1/1] hugetlb: add timing to hugetlb allocations on boot Gang Li
2023-12-12 20:06 ` [RFC PATCH v2 0/5] hugetlb: parallelize hugetlb page init " Mike Kravetz
2023-12-21 7:22 ` Gang Li
2023-12-12 22:14 ` David Rientjes
2023-12-12 23:08 ` Mike Kravetz
2023-12-13 0:10 ` David Rientjes [this message]
2023-12-18 6:34 ` Gang Li
2023-12-22 4:33 ` David Rientjes
2023-12-25 5:21 ` David Rientjes
2023-12-25 6:24 ` Gang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55c6c1f6-0792-61c3-86ed-4729d4a3fdf5@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gang.li@linux.dev \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox