From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98484D16261 for ; Mon, 14 Oct 2024 13:17:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DEA26B0089; Mon, 14 Oct 2024 09:17:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28F156B008A; Mon, 14 Oct 2024 09:17:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E2586B008C; Mon, 14 Oct 2024 09:17:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E0A676B0089 for ; Mon, 14 Oct 2024 09:17:29 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 26B2CA0EFF for ; Mon, 14 Oct 2024 13:17:15 +0000 (UTC) X-FDA: 82672259208.26.0E89BB3 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf22.hostedemail.com (Postfix) with ESMTP id AA227C0012 for ; Mon, 14 Oct 2024 13:17:19 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XJSAPzJ7; spf=pass (imf22.hostedemail.com: domain of maddy@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=maddy@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728911704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nYUq7adz2xqCBl+Ga8oFU+DVr40SauuZOQ0GZ3ecydE=; b=iDg08OkdqdiQHTRRLIxP4mNXdMwCsjsSHf81DKbL7CL9dDjSuFiExS+rRpJ04c/4qLvQ1z q6W4/EBq/KuxmUDVcmwwFNvPWFDBGZ9qT87nA37DT+bYeKNR3XERwKgetejQggdT2KsyUN 7d0d1RdIU92pprrnhS9YJO7AJFMU+Vw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728911704; a=rsa-sha256; cv=none; b=KEX5n+SavG9igvLwRz114sgRuOv29rF3n27pROZU8ZO7WfAdknO4QkUKoQ64onZG42K926 MrC4V7cEvgSYKkTleFopBpcgBUlIYIvQMFwu7K5OgaYkjCVZp3usCkkJrLJ//rZDHTtb2r l4QO1vCVwc49EUPweT0XFkhiFFvUE9E= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XJSAPzJ7; spf=pass (imf22.hostedemail.com: domain of maddy@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=maddy@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49E9ssNT005734; Mon, 14 Oct 2024 12:21:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:subject:to:cc:references:from:in-reply-to :content-type:content-transfer-encoding:mime-version; s=pp1; bh= nYUq7adz2xqCBl+Ga8oFU+DVr40SauuZOQ0GZ3ecydE=; b=XJSAPzJ7NFg0Uy47 Xou3n60PadCbcr/cXU7mKzHF9sAUDXVYmwteHAaayXNJKeG2u7gv+pL5wL6Odfa2 QcnH4+miDCNKpZdK0Oojvght6xZIF4w0s/ieNsCj5YDmqyZ0YKgQvsgr6yKTPJqe qGYPLeVlYP7hI/HOBW3ZE280q5j1kpG6IcpfcxmJqyZ5pN17NxuwN66l8SYnIWkb rNs8U1Fomb9EIVJK5SFUivJMtUyrI77KSm+4/z1zbTEloEJzgh7KgXPRQ52COMJ3 0nXgXXS8+OfJcYoRhDxWKtpMwi421MsmEC/Pn3EMCcqVbs8Qt994vz6QpmnZNIOa k/Va6A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4291330pex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2024 12:21:27 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49ECJgRj002720; Mon, 14 Oct 2024 12:21:27 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4291330pet-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2024 12:21:27 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49EBVSJu006401; Mon, 14 Oct 2024 12:21:26 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4284xjxb7p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2024 12:21:26 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49ECLOrq45351440 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Oct 2024 12:21:25 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D913D5804B; Mon, 14 Oct 2024 12:21:24 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5CD3D58065; Mon, 14 Oct 2024 12:21:16 +0000 (GMT) Received: from [9.43.116.47] (unknown [9.43.116.47]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 14 Oct 2024 12:21:15 +0000 (GMT) Message-ID: <55c554a2-fdf9-4a1b-acf4-c227786624ce@linux.ibm.com> Date: Mon, 14 Oct 2024 17:51:13 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v3 1/3] fadump: Refactor and prepare fadump_cma_init for late init To: "Ritesh Harjani (IBM)" , linuxppc-dev@lists.ozlabs.org Cc: linux-mm@kvack.org, Sourabh Jain , Hari Bathini , Zi Yan , David Hildenbrand , "Kirill A . Shutemov" , Mahesh J Salgaonkar , Michael Ellerman , "Aneesh Kumar K . V" , Donet Tom , LKML , Sachin P Bappalige References: <030b6d46fddac126a6cf7e119bea48055338f0ed.1728658614.git.ritesh.list@gmail.com> <941875f7-0d7f-4ba3-bc7c-7aedc3b20dae@linux.ibm.com> <87bjznyliv.fsf@gmail.com> Content-Language: en-US From: Madhavan Srinivasan In-Reply-To: <87bjznyliv.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 0qMBKVP7s2lJ0nmJZBXSfyMPAbPytZn_ X-Proofpoint-GUID: utFw1S-hiIhm1HWZkMo502AomZsmQ6d5 Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-14_10,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410140089 X-Stat-Signature: xfpqg8ju143bumiwyid97yb6gmto4gca X-Rspamd-Queue-Id: AA227C0012 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728911839-646428 X-HE-Meta: U2FsdGVkX1/8B0ZizwKozDfvR/AFRDqH4zdoHQsJgKGOSxcmXEAwwAfX0nUgLY1qNrbhXCCh/9Ekc6p8jLpvpyWY1eQYsG1i4ueSo4yFjW8tdeAw/JAr7LFqTw/aACkeWkV7dVJP5c1nJQJMp0+6BBFqVEch5jr/GI4ia9kQz6zH8ZAH2sQxOSZZcqnBqZJ3fyk+CE9qstQlX5YNik3hv5mWZ3s8w8ui5n7JAaN+G2HoMbcV1qRFfj3/NJWorQnC1L7wPiNPbDvTToaiv0YCqPEIfvIA9kU+z97C4FC7Y2DgUSAG2y7JJtlVl+XZKG3V03XxQb1wCzcqj1TJTXgA4ATEbmIu4ZwWjuKSQuszoTi59Ve6CR/cH+Bycq6W0dnDqBxy+rrr7t/sPz5NGMJZpDb1Elobo0YZXWevzrlUmBMHdQI06jB2p5nmf12pMjyx0eSXn5ssBr3DeMjeInPZqgr9dR1GeYxrDt4jNRNhwASLS9hmBxP1QjH83zqqP0Kq5A12thlecOGj+JxENO7DH3aQA8rBrZ0hb425VBgscAoX1Ih/VleeA5z9VYirxBRB4bHynSaYRWAGEhAzTT1D4ShAMlpnInmLjLfZH/YwfBIM/3fCTopm+bzMxWjfd/u/q/c7Px+m+l6f0UDVAKJrc7Ue9WlCPIqdGSy4TLPRbWQqlhWm3yJ8w0mWuDhaebQJRHa+BbOIKdG5o1n/U5VZ1lWWIPmCmI/LHlnMqwCW8Tp+jSRQSUFZND6LF4VXk1nTILDPrlj4bZWP9bbaYtCW6fz1qMJI4J24ZPfaQfkmwq5fVXUMrJhRQQwl0Xm9RC+yNhXX2VNqvWiNCpPlzCIf+jVmPRXOZVkqWfTxm8cedwCN0o7n4edYvnoSOqiV+AkcYJQyWJSCW+ZRehYsTFi36iiAykKJPhxmuhvf3wx7Jf2Z0wQMG9lvmUUR3EnNw0gNKBs+QNhT5X2EOVnnQzV CIQ5AoMg QhUK3MnjGDMRAigsj249idUM3OblG0aB6Fs/dgF4UE2fxQ1s5+QCvaEkO6tTj8AX5vg/r7EHJyHsK9I45ylzZ8OylY6MmasOeImzbx4f2GOcS0WLN0mS4m22Xoes5+DDAkV5X0NwBUlSxGL4oV21x2kAQV2Gjj9DL87FbmIqN1dPHJhfYvhLIn0O6nJRYJZYiqoXc9IbGFYfnM7g6IwT3esgd5jgxthF52WzNXEN/fsuHL0HHCea9Gp5o7Vvmhcu54QC/4Lyu5LQR4vJ94do/B8iUA7KZmq1IV3ztfy/5zV6LJ2axBtjjtVe4OsBoO43QUdOxT2BHTSYvClVXbIcLH/T89l5dXN904fhV9ZbA19LVT3YWlVb3jxi6oxzMdKdXVVLdPDXsH1KBK3Utkm4DSxpKwgVFMxHDONrqpdNREUWBq9s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/14/24 4:54 PM, Ritesh Harjani (IBM) wrote: > Madhavan Srinivasan writes: > >> On 10/11/24 8:30 PM, Ritesh Harjani (IBM) wrote: >>> We anyway don't use any return values from fadump_cma_init(). Since >>> fadump_reserve_mem() from where fadump_cma_init() gets called today, >>> already has the required checks. >>> This patch makes this function return type as void. Let's also handle >>> extra cases like return if fadump_supported is false or dump_active, so >>> that in later patches we can call fadump_cma_init() separately from >>> setup_arch(). >> >> Usually patches to this file are posted with title format of >> >> powerpc/fadump:<> > > yes. I guess it is good to do it that way (I might have missed it) > Although commit history of oldest few patches to fadump shows.. > > ebaeb5ae2437 fadump: Convert firmware-assisted cpu state dump data into elf notes. > 2df173d9e85d fadump: Initialize elfcore header and add PT_LOAD program headers. > 3ccc00a7e04f fadump: Register for firmware assisted dump. > eb39c8803d0e fadump: Reserve the memory for firmware assisted dump. > >> >> >>> >>> Acked-by: Hari Bathini >>> Signed-off-by: Ritesh Harjani (IBM) >>> --- >>> v2 -> v3: Separated the series into 2 as discussed in v2. >>> [v2]: https://lore.kernel.org/linuxppc-dev/cover.1728585512.git.ritesh.list@gmail.com/ >>> >>> arch/powerpc/kernel/fadump.c | 23 +++++++++-------------- >>> 1 file changed, 9 insertions(+), 14 deletions(-) >>> >>> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c >>> index a612e7513a4f..162327d66982 100644 >>> --- a/arch/powerpc/kernel/fadump.c >>> +++ b/arch/powerpc/kernel/fadump.c >>> @@ -78,27 +78,23 @@ static struct cma *fadump_cma; >>> * But for some reason even if it fails we still have the memory reservation >>> * with us and we can still continue doing fadump. >>> */ >>> -static int __init fadump_cma_init(void) >>> +static void __init fadump_cma_init(void) >>> { >>> unsigned long long base, size; >>> int rc; >>> >>> - if (!fw_dump.fadump_enabled) >>> - return 0; >>> - >>> + if (!fw_dump.fadump_supported || !fw_dump.fadump_enabled || >>> + fw_dump.dump_active) >>> + return; >> >> Is these checks even needed here? fadump_reserve_mem() checked for all >> these already, also dont see any other caller for fadump_cma_init(). >> >> > > In the next patch we will move fadump_cma_init() call from within > fadump_reserve_mem() to setup_arch(). Hence we need these extra checks > in fadump_cma_init() as well. I mentioned the same in the commit msg of > this patch too. > yes, just saw that when looking at the patch 3, sorry for the noise. >>> /* >>> * Do not use CMA if user has provided fadump=nocma kernel parameter. >>> - * Return 1 to continue with fadump old behaviour. >>> */ >>> - if (fw_dump.nocma) >>> - return 1; >>> + if (fw_dump.nocma || !fw_dump.boot_memory_size) >>> + return; >>> >>> base = fw_dump.reserve_dump_area_start; >>> size = fw_dump.boot_memory_size; >>> >>> - if (!size) >>> - return 0; >> >> So this is the only place where we return 0, which in turn will make the >> "ret" in fadump_reserve_mem() as zero forcing to call reserve_crashkernel() >> in early_init_devtree(). >> >> we are removing it, becos we know "size" here will never be zero? >> >> > > yes. Because we already check if boot_memory_size is less than > bootmem_min in fadump_reserve_mem(). If it is less, then we fail and > disable fadump (fadump_enabled = 0). > Thanks for the clarification. > So then there is no need to check for !boot_memory_size in here. > > fadump_reseve_mem( ) { > <...> > if (!fw_dump.dump_active) { > fw_dump.boot_memory_size = > PAGE_ALIGN(fadump_calculate_reserve_size()); > > bootmem_min = fw_dump.ops->fadump_get_bootmem_min(); > if (fw_dump.boot_memory_size < bootmem_min) { > pr_err("Can't enable fadump with boot memory size (0x%lx) less than 0x%llx\n", > fw_dump.boot_memory_size, bootmem_min); > goto error_out; > } > <...> > } > <...> > error_out: > fw_dump.fadump_enabled = 0; > fw_dump.reserve_dump_area_size = 0; > return 0; > } > > > Thanks for the review! > -ritesh