From: Dave Hansen <dave.hansen@intel.com>
To: Yosry Ahmed <yosryahmed@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH mm-stable 1/2] x86/mm: further clarify switch_mm_irqs_off() documentation
Date: Thu, 22 Feb 2024 11:11:37 -0800 [thread overview]
Message-ID: <55c537d9-4fd2-4b61-a30d-4cdbeb037875@intel.com> (raw)
In-Reply-To: <20240222190911.1903054-1-yosryahmed@google.com>
On 2/22/24 11:09, Yosry Ahmed wrote:
> Commit accf6b23d1e5a ("x86/mm: clarify "prev" usage in
> switch_mm_irqs_off()") attempted to clarify x86's usage of the arguments
> passed by generic code, specifically the "prev" argument the is unused
> by x86. However, it could have done a better job with the comment above
> switch_mm_irqs_off(). Rewrite this comment according to Dave Hansen's
> suggestion.
Looks good, thanks for sending this!
Acked-by: Dave Hansen <dave.hansen@intel.com>
prev parent reply other threads:[~2024-02-22 19:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 19:09 Yosry Ahmed
2024-02-22 19:09 ` [PATCH mm-stable 2/2] x86/mm: always pass NULL as the first argument of switch_mm_irqs_off() Yosry Ahmed
2024-02-22 19:12 ` Dave Hansen
2024-02-22 19:11 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55c537d9-4fd2-4b61-a30d-4cdbeb037875@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox