From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37253D2AB33 for ; Tue, 29 Oct 2024 12:42:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0B8A6B009A; Tue, 29 Oct 2024 08:42:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE1FA6B009D; Tue, 29 Oct 2024 08:42:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5BF26B009E; Tue, 29 Oct 2024 08:42:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 824906B009D for ; Tue, 29 Oct 2024 08:42:21 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2C6D0C14AA for ; Tue, 29 Oct 2024 12:42:21 +0000 (UTC) X-FDA: 82726602630.14.787E12C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 4DA98140025 for ; Tue, 29 Oct 2024 12:42:00 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="M+HMbJ/S"; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730205579; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W74IpGQRUQTzTro39G8OtmhHbvCKLkRV0MC4eyKHQ8s=; b=hFmRGxaBkqDJkcY3lyhXPIv0jJyRxc0V1owi72s9be1doDUdpWICuJ4eV9Ty1gzeM6jJp4 JDHcYVYcIlOs0Y66q4tQK8P2Ty29DrNgfGDFwwK1mo97CbrNWUO/vzrEbULtprrOGD25/S YiFZ71W6vrp2qLbq5kE/JriN+Tvr1Xg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730205579; a=rsa-sha256; cv=none; b=55jE9Yj6G5wKxJa6PscIPLhXFAz/E6o9Z9ZPf8I6dxVB0zdoLeSfzsY4yrGSlPtNukcO/o fLLSGD+4Y4jcZPFocZ9Lxhe3lb+SzzYZFkb2i7CyrWhgrPI4Oyj2v+/k1/CBFHAg6kDa70 A5sgS8rDlVSHw5fs5V9Cqp4S5JO1yr4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="M+HMbJ/S"; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730205738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=W74IpGQRUQTzTro39G8OtmhHbvCKLkRV0MC4eyKHQ8s=; b=M+HMbJ/SzBAgGaZ/B1wlyexffhlhMj+nWRr+Rse07p7KGQmrNTo3vvJgJloam0MUO/qGC2 VPeT9vp9PgBabioZFnIm21aldEaIhIkJscwRf5N4fX6F5wkJ1Hf0oGcVqtRC40o6+3TJns plUCe3EdYvE9sx5QgJSjZUP43mLEkhQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-Sjj9uYAlM9ivmSEHy3Bvbg-1; Tue, 29 Oct 2024 08:42:16 -0400 X-MC-Unique: Sjj9uYAlM9ivmSEHy3Bvbg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d609ef9f7so2586447f8f.3 for ; Tue, 29 Oct 2024 05:42:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730205735; x=1730810535; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=W74IpGQRUQTzTro39G8OtmhHbvCKLkRV0MC4eyKHQ8s=; b=dDX5SAN91Ig0XXQlpsU+hmHurDw9nid98B2I3WHeVsoejqE+Z1dwojdMgTC8BfeabY G/JWV7o56LOcF4oBMmLuRMb2U3YVVLmZPB7KAqRg0fCIdtDpcSqtltXyoOwYLMm5NQcq fc9TS+Z+BSgBxR34Slu/+NQyPKNGn3MD69edCrrl1SuxQmy3a8608bjj0iZpsQtGiY2S g+IWHmr12mmUH9wlXn3NJOjyX2upssxc9+d72agmae9GDVg0in3cTggQLN8ufkawWscJ kvoEqUIOO5jjXoZT6ht+yF5uPKoTcQ8K+PHPSYL5vmaQNBthOqexGO2CA+ck9NAL8lwB frQw== X-Forwarded-Encrypted: i=1; AJvYcCWy1p3JDFB8C7PjU4a0nJM8Hrivje8Dhzh9sEECpCgGcdDgrA9cj++4XYHp6CKXG0xE6Eq/zT1g1Q==@kvack.org X-Gm-Message-State: AOJu0YxNccoFCEL6uxceDr7NgqZxVUT8qbJq0YllMu0SH9hutfJMfhh+ UDM8/JvpGWgYyAolDNm8WDLzYno/3guCYoZ6qzV12CPl920Htz0p12m77id1FYWZZer7XqQVhGw exoHD7WC+xeaBnnvdmX8tGgzo5GNQE0fTqhMFNOiZhgWR3XXQ X-Received: by 2002:a05:6000:c92:b0:37c:d11f:c591 with SMTP id ffacd0b85a97d-380611372d5mr8395803f8f.17.1730205735574; Tue, 29 Oct 2024 05:42:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmV9MoFToXUAd4jPQsnGOjLKsvVTJGnioYA+7Fr7GLiNRNi9ivKHt4JKB9TnFXBSesOzH81A== X-Received: by 2002:a05:6000:c92:b0:37c:d11f:c591 with SMTP id ffacd0b85a97d-380611372d5mr8395762f8f.17.1730205735167; Tue, 29 Oct 2024 05:42:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c72d:8500:d87a:ed8e:1e80:5a7e? (p200300cbc72d8500d87aed8e1e805a7e.dip0.t-ipconnect.de. [2003:cb:c72d:8500:d87a:ed8e:1e80:5a7e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b71231sm12350616f8f.66.2024.10.29.05.42.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Oct 2024 05:42:14 -0700 (PDT) Message-ID: <55a5b63a-a6bb-4ba0-9aad-c9d8741d1c3a@redhat.com> Date: Tue, 29 Oct 2024 13:42:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] acpi,srat: give memory block size advice based on CFMWS alignment To: Gregory Price , x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org Cc: linux-cxl@kvack.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org References: <20241022213450.15041-1-gourry@gourry.net> <20241022213450.15041-4-gourry@gourry.net> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241022213450.15041-4-gourry@gourry.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4DA98140025 X-Stat-Signature: ik6qj6u9qddf7owimsiea8x8ubz4wmmr X-HE-Tag: 1730205720-387305 X-HE-Meta: U2FsdGVkX19deoq9kjFrwYOD3u7Rbj4OJic/Twrwja1X4CmZN995jaPO07bFFpj5ADgBniyX+0a6nah6fExrCxm2XlscTH6dlT/F4XiYOdZUsY7mrcCeysTtp4N4+KbD4R7RSREh3UijjNcshhup7Gm6SQyuPBEACzIySA5UaiLdYNV/aV4Mhjq7zoGZOob7cUOVn07bgD3rnv5LFSezkTUCnd7VjIcBC0fjqhCTE81FFlsIyxoASMwI5w30KD6E3RP99eHwZ8V/N2QnjeaYAwBHoWyAwQ5vzo7SnwMwAnC8YADFmR0OixfxczVWV+lcB1nAkdhVvHn7F1ZwEHIBZ2ou+67klrpnmnlx3RKciBLGC791SSRMeVe82mmDuZxn5tmE+UB3k4TiFAvnmNmIzXNRVyVzbBh9KN5Rs4tNgxH25jojC0/O/f2H6uWDaH2ZTcj0reMuRl1H0UyJbYyOjCihin/Yy2mm25w9iJQPJvaDWCRi0WLAQ+fKtRf23K7zqmHz1yvJD2jaW0ty+GZOIi1O1qE27cuG+5VYA1/QdwwF/rvxPnFB7ki94604/1WkV4N6inm73N7wAfXyCvnVTI46mgiP0o5eBBOJ9I7Vgr30iD14byDsNLx2W8ER8DUKzs/lU8xPzLFjdTeKomCiNUxnEPGRSenRs77QvYNa+kJJDhaiJxjdz2gz3jmoFxNmWSoJ5Trg+jbtmmBWapvLQOi9JDBKSlOXqnLJpR+bTp8vu9p62vffviVbqnCrZ+yEJVlq7BO4m7wT0nPVz74lSZixVav+1KOFUjB8FN+BM8HxXn2RYyyEUO8/RIQb1nauM/E6TL4bOWDQtdLtHwpm7pkmAgXI5hPul+JT2MQ/XMl6CSw1Yqjv3m0b+6KfALVEY7WxF6qoEh9kxa6vDCEQgoC9CFZ1+8s5yG1bzx4pYdoCNmSs9uFV7BgkmFRMTnByA7sxzLeSa2dzytdZP2/ Glae7G+w N9x3rB4lJ4hdCcWgTARJQjddk6dtOhgt+qzmlEl4t20LwWBbe/AqJw5fsqEQlb5bB7H5YIf+/xw5UgK0hXcB392I8t4nXyKP8GyxsYGk0visS1cYp5xi47BtiLqZ7WumhDqReYkEegAZDs3SpPdS4S6F/hSloMEbzdyb5R3eJW4HREr4gHv3XgPhDNhXVFW+zL4XMnv3Rzd4oaRkVmWRRyF+kudxJH4CZNuNuXSRjI9jtLqrTAe32kGGo61pOAhnSnvPzXxf4HnsHmieNPG3QzqcfQZ/BlmHz8owjIVQ/2BvhKN1ngJNn6KcwFX/tL5IA03uiJ5wwDYLr12IwYyk3BWiowVT6MeRLabFPOLZzqNcr+DM8cx/Uehr/EEXHXIAKMpoPnSqXHu1/9jE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > void *arg, const unsigned long table_end) > { > @@ -545,6 +569,15 @@ int __init acpi_numa_init(void) > * Initialize a fake_pxm as the first available PXM to emulate. > */ > > + /* Align memblock size to CFMW regions if possible */ > + acpi_table_parse_cedt(ACPI_CEDT_TYPE_CFMWS, acpi_align_cfmws, NULL); > + > + /* > + * Nodes start populating with blocks after this, so probe the max > + * block size to prevent it from changing in the future. > + */ > + memory_block_probe_max_size(); > + This looks odd. Why shouldn't we allow someone else to suggest/advise an even smaller "max size" ? I'd drop that. -- Cheers, David / dhildenb