From: David Hildenbrand <david@redhat.com>
To: Gregory Price <gourry@gourry.net>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-mm@kvack.org
Cc: linux-cxl@kvack.org, Jonathan.Cameron@huawei.com,
dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com,
dave.jiang@intel.com, ira.weiny@intel.com,
alison.schofield@intel.com, dave.hansen@linux.intel.com,
luto@kernel.org, peterz@infradead.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org,
lenb@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, rppt@kernel.org
Subject: Re: [PATCH v3 3/3] acpi,srat: give memory block size advice based on CFMWS alignment
Date: Tue, 29 Oct 2024 13:42:12 +0100 [thread overview]
Message-ID: <55a5b63a-a6bb-4ba0-9aad-c9d8741d1c3a@redhat.com> (raw)
In-Reply-To: <20241022213450.15041-4-gourry@gourry.net>
> static int __init acpi_parse_cfmws(union acpi_subtable_headers *header,
> void *arg, const unsigned long table_end)
> {
> @@ -545,6 +569,15 @@ int __init acpi_numa_init(void)
> * Initialize a fake_pxm as the first available PXM to emulate.
> */
>
> + /* Align memblock size to CFMW regions if possible */
> + acpi_table_parse_cedt(ACPI_CEDT_TYPE_CFMWS, acpi_align_cfmws, NULL);
> +
> + /*
> + * Nodes start populating with blocks after this, so probe the max
> + * block size to prevent it from changing in the future.
> + */
> + memory_block_probe_max_size();
> +
This looks odd. Why shouldn't we allow someone else to suggest/advise an
even smaller "max size" ? I'd drop that.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-10-29 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 21:34 [PATCH v3 0/3] memory,x86,acpi: hotplug memory alignment advisement Gregory Price
2024-10-22 21:34 ` [PATCH v3 1/3] memory: implement memory_block_advise/probe_max_size Gregory Price
2024-10-28 17:27 ` Mike Rapoport
2024-10-29 12:39 ` David Hildenbrand
2024-10-22 21:34 ` [PATCH v3 2/3] x86: probe memory block size advisement value during mm init Gregory Price
2024-10-29 12:40 ` David Hildenbrand
2024-10-29 13:48 ` Gregory Price
2024-10-29 13:52 ` David Hildenbrand
2024-10-22 21:34 ` [PATCH v3 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Gregory Price
2024-10-28 17:24 ` Mike Rapoport
2024-10-28 20:55 ` Gregory Price
2024-10-29 12:42 ` David Hildenbrand [this message]
2024-10-29 13:20 ` Gregory Price
2024-10-29 16:31 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55a5b63a-a6bb-4ba0-9aad-c9d8741d1c3a@redhat.com \
--to=david@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Terry.Bowman@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=gourry@gourry.net \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=osalvador@suse.de \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=rrichter@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox