From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B680C54E69 for ; Tue, 14 Nov 2023 20:11:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 361AD6B028D; Tue, 14 Nov 2023 15:11:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 313D16B0292; Tue, 14 Nov 2023 15:11:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 189766B0294; Tue, 14 Nov 2023 15:11:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 01B2E6B028D for ; Tue, 14 Nov 2023 15:11:53 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BE9F0B5D07 for ; Tue, 14 Nov 2023 20:11:53 +0000 (UTC) X-FDA: 81457655706.27.2A99EF2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf09.hostedemail.com (Postfix) with ESMTP id 510CE140023 for ; Tue, 14 Nov 2023 20:11:50 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QztLg3ps; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NcSJZK89; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699992710; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jx5LtWmsLR+LfLuIaijRwnFRntSIu1BC0epYmgHcaMQ=; b=4s97jEooN2YJ871qdOGat7lvmN7bQIWwyxy6fVxhXSxT4IWtwIaxt32+1lzfkwQrsMfcRA CUiWpW+5TehPioBfMwuM5qzXjs99etsHFCcNyzqEwNVj87O/cn++u+sCSwBk5gFssOGLGs 0X5vPK/3ZzXI0/27dlmEGDwVJ3Gmeeo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699992710; a=rsa-sha256; cv=none; b=R0kGZsT9mgNxGO7wgGPoN9jlPtSAv0Q2XUb8EqvLGdE/RM7tDZ+5UxfY5ZVlOXthLcRBzj WZX/9zVgK8QPHZMH7u2OvRFbf6jjELbdDj41fu0DaJg/Db+YImXjKOyB/MtKulkwLcyyBR edTE75Rn9XoJWlTV5UWDTTbQM5bIxHc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QztLg3ps; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NcSJZK89; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 78AB920430; Tue, 14 Nov 2023 20:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1699992707; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jx5LtWmsLR+LfLuIaijRwnFRntSIu1BC0epYmgHcaMQ=; b=QztLg3psAOKHMl6gbAEvrcxmmJo9FhUCQ7OhduKlUpTqKuKkwL0p419HwTadOkkN56LNhV DJqfitKLBKDYB0QuPtO139EwyaPKvgaI3qrvj6xusCkDEcJEkKF2x8owyoGrvIlxaiXXDj bSacZpf3Co3JzSWXWsvNVsuUJVChs38= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1699992707; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jx5LtWmsLR+LfLuIaijRwnFRntSIu1BC0epYmgHcaMQ=; b=NcSJZK89lOQ0tthmCnON+iffFckuV9XsKXUSSHht9GT36OrnfM0rMyzOSDB1xtbq3MBssf +q6wb/FzUt4TsSDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1F4A913460; Tue, 14 Nov 2023 20:11:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8LsfBoPUU2V+WAAAMHmgww (envelope-from ); Tue, 14 Nov 2023 20:11:47 +0000 Message-ID: <55a589d7-edcc-6db4-759d-c928577cba8b@suse.cz> Date: Tue, 14 Nov 2023 21:11:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 01/20] mm/slab: remove CONFIG_SLAB from all Kconfig and Makefile Content-Language: en-US To: Kees Cook Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-23-vbabka@suse.cz> <202311132009.8329C2F5D@keescook> From: Vlastimil Babka In-Reply-To: <202311132009.8329C2F5D@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: xskxoufqr3hy1omu361hrhsmsfg41ruy X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 510CE140023 X-Rspam-User: X-HE-Tag: 1699992710-435952 X-HE-Meta: U2FsdGVkX1/PB9zdVJzhO0e8Hg8AKz++cEIqTE4YNFfevUI4OmMDZI2wAQMDN/5ajPRzSjuJOGr5njOrE3XhVKH3PgMs78nU3aDkY08t4SJjk5BzQp/RO7XF8cIvt1AtFBss5UhPpTWvqFz5hlfGTXbdBS+aiRy1EgyHXhzQEdjTtgDKmWcCgin3qfrvNEkgEXcnGeWrR7ikS03tqeszIHXqC9d9ROM+nkj+vzoQYdm4+gUSmzRAcEJXJCeKrmMqmZgboOTyV3gM/BMQ1XkegWgjMdcpSL8JQQW9pkaRW7WXb9l8KFAwN5l1qyBCDJ/4k4ii7cQzSUUuHy7tIita2pKQkrVcAlsT1ls2l2HCP/h+7OS4n7/rOet7tX99uJGqtagAeZWkqt+UawBKd+ZFPVwGTzfPFSVZtLLx2MJ8u9jCh7naqFnnz06pcCIbFFyY8fhnJ3zVFhI7YCPI7fDWU7JcUuaj0tXaDYGHmhazCo6m50g4hOlLQaMQkdOeDTybtjjy1nslvSW87FkXtWIGuFCNlBtKMdhidc/OB5ylO9rLejh9NudgVsg5XpXEZfyIyI92ZcX0y8qEAESPG06PTSysAwjbOBTZ4h/FzJcHno/AI6WoCUOYZnMrFRuaZ1YOlMknIrWJ55CNQdzTlXWR5mePGSOsY2GPyl3le/JIBF/kXlziWd4/YXMRKTm48FImsTKEzP9rgE2eMJzm8fJpLmSHg5dKvqtX7sygDyxnhmYN3e6xyFpgI3pnH9p6CEzEUfmfweilrt1+ljv+djlaNN7w3h5yrcvZyw8j04AT4hdL2o1+dB4Xowf+X2lJ4o51RFlsIsX/5Q20wMpymOiisZJKhSv0l14tSep2Vhc7/6RwbhGzbOlWyaISIQwHaFBZi4oFeWPYMrpX6qHbynLYBn1K2goNFQwYFag5qvdvu5d6T/TYQS8G+LTOTMm+hcgNOnVTv7Jmxzj5L3uHrDG ywvkYCU0 QwF0JXrqMDmEUKbt6aDfw7t1euvXg0QMMwN2UKOcwkE8OZYc/Ko3IWCg1nnd/5ssudyJK7azCzMzjtaS5TXklZOJyAxp/aj/lBCY2UZxgHswxyMRCgARk6eW/aaPYarnmIZOoWyx2h68RIdTsjZzQtKXkj/dnGxSlSZ7r4rovn3WeM3somCLxFF4oleKIdg17mLNochKFd7HZuxZ0KH2XO0hLYVPVKllK9i7AbwIeUKIAYrLuT2EDFuI5ByEgVvPmDHvsaJnYW/Knh5gVEghyRk4IOaLdjOxEzdMwBTyzAsKmMvz9OYgpp99YGvlpJvGmi34Yj4wzeEKHVfSq7Bz5lX9JoICnzwxgRyPFFVNjgd75bd/vvcUr4GySBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/14/23 05:11, Kees Cook wrote: > On Mon, Nov 13, 2023 at 08:13:42PM +0100, Vlastimil Babka wrote: >> Remove CONFIG_SLAB, CONFIG_DEBUG_SLAB, CONFIG_SLAB_DEPRECATED and >> everything in Kconfig files and mm/Makefile that depends on those. Since >> SLUB is the only remaining allocator, remove the allocator choice, make >> CONFIG_SLUB a "def_bool y" for now and remove all explicit dependencies >> on SLUB as it's now always enabled. >> >> Everything under #ifdef CONFIG_SLAB, and mm/slab.c is now dead code, all >> code under #ifdef CONFIG_SLUB is now always compiled. >> >> Signed-off-by: Vlastimil Babka >> [...] >> diff --git a/mm/Kconfig b/mm/Kconfig >> index 89971a894b60..766aa8f8e553 100644 >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -228,47 +228,12 @@ config ZSMALLOC_CHAIN_SIZE >> >> menu "SLAB allocator options" > > Should this be "Slab allocator options" ? (I've always understood > "slab" to mean the general idea, and "SLAB" to mean the particular > implementation. Good point, will change > Regardless: > > Reviewed-by: Kees Cook Thanks!