From: Byungchul Park <byungchul.park@lge.com>
To: peterz@infradead.org, mingo@kernel.org
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-block@vger.kernel.org,
kernel-team@lge.com, david@fromorbit.com, tytso@mit.edu,
willy@infradead.org, torvalds@linux-foundation.org,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH] locking/lockdep: Make CONFIG_LOCKDEP_CROSSRELEASE and CONFIG_LOCKDEP_COMPLETIONS optional
Date: Tue, 12 Dec 2017 16:15:28 +0900 [thread overview]
Message-ID: <55a0928a-4b62-70f8-577d-a63a21199279@lge.com> (raw)
In-Reply-To: <1513062681-5995-1-git-send-email-byungchul.park@lge.com>
+cc david@fromorbit.com
+cc tytso@mit.edu
+cc willy@infradead.org
+cc torvalds@linux-foundation.org
+cc amir73il@gmail.com
On 12/12/2017 4:11 PM, Byungchul Park wrote:
> At the moment, it's rather premature to enable
> CONFIG_LOCKDEP_CROSSRELEASE and CONFIG_LOCKDEP_COMPLETIONS by default,
> because we face a lot of false positives for now since all locks and
> waiters are not classified properly yet.
>
> Until most of them get annotated properly, it'd be better to be optional.
>
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
> lib/Kconfig.debug | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 2689b7c..bc099f1 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1092,8 +1092,6 @@ config PROVE_LOCKING
> select DEBUG_MUTEXES
> select DEBUG_RT_MUTEXES if RT_MUTEXES
> select DEBUG_LOCK_ALLOC
> - select LOCKDEP_CROSSRELEASE
> - select LOCKDEP_COMPLETIONS
> select TRACE_IRQFLAGS
> default n
> help
> @@ -1164,7 +1162,9 @@ config LOCK_STAT
> (CONFIG_LOCKDEP defines "acquire" and "release" events.)
>
> config LOCKDEP_CROSSRELEASE
> - bool
> + bool "Lock debugging: enable cross-locking checks in lockdep"
> + depends on PROVE_LOCKING
> + default n
> help
> This makes lockdep work for crosslock which is a lock allowed to
> be released in a different context from the acquisition context.
> @@ -1174,7 +1174,10 @@ config LOCKDEP_CROSSRELEASE
> detector, lockdep.
>
> config LOCKDEP_COMPLETIONS
> - bool
> + bool "Lock debugging: allow completions to use deadlock detector"
> + depends on PROVE_LOCKING
> + select LOCKDEP_CROSSRELEASE
> + default n
> help
> A deadlock caused by wait_for_completion() and complete() can be
> detected by lockdep using crossrelease feature.
>
--
Thanks,
Byungchul
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-12-12 7:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 7:11 Byungchul Park
2017-12-12 7:15 ` Byungchul Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55a0928a-4b62-70f8-577d-a63a21199279@lge.com \
--to=byungchul.park@lge.com \
--cc=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=kernel-team@lge.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox