From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by kanga.kvack.org (Postfix) with ESMTP id C2F866B0038 for ; Mon, 24 Aug 2015 11:02:19 -0400 (EDT) Received: by wicne3 with SMTP id ne3so75022528wic.0 for ; Mon, 24 Aug 2015 08:02:19 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id o7si32546110wjq.49.2015.08.24.08.02.17 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 24 Aug 2015 08:02:18 -0700 (PDT) Subject: Re: [PATCHv3 1/5] mm: drop page->slab_page References: <1439976106-137226-1-git-send-email-kirill.shutemov@linux.intel.com> <1439976106-137226-2-git-send-email-kirill.shutemov@linux.intel.com> From: Vlastimil Babka Message-ID: <55DB31F8.4020200@suse.cz> Date: Mon, 24 Aug 2015 17:02:16 +0200 MIME-Version: 1.0 In-Reply-To: <1439976106-137226-2-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" , Andrew Morton , Hugh Dickins Cc: Andrea Arcangeli , Dave Hansen , Johannes Weiner , Michal Hocko , David Rientjes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim , Andi Kleen On 08/19/2015 11:21 AM, Kirill A. Shutemov wrote: > Since 8456a648cf44 ("slab: use struct page for slab management") nobody > uses slab_page field in struct page. > > Let's drop it. Ah, how about dropping this comment in mm/slab.c:slab_destroy() as well? /* * RCU free overloads the RCU head over the LRU. * slab_page has been overloeaded over the LRU, * however it is not used from now on so that * we can use it safely. */ > Signed-off-by: Kirill A. Shutemov > Acked-by: Christoph Lameter > Acked-by: David Rientjes > Cc: Joonsoo Kim > Cc: Andi Kleen > --- > include/linux/mm_types.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 0038ac7466fd..58620ac7f15c 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -140,7 +140,6 @@ struct page { > #endif > }; > > - struct slab *slab_page; /* slab fields */ > struct rcu_head rcu_head; /* Used by SLAB > * when destroying via RCU > */ > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org