From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB37AE77197 for ; Tue, 7 Jan 2025 17:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E99A6B00B0; Tue, 7 Jan 2025 12:02:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 349796B00B3; Tue, 7 Jan 2025 12:02:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 175136B00B4; Tue, 7 Jan 2025 12:02:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E315B6B00B0 for ; Tue, 7 Jan 2025 12:02:18 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A4B911C7A4B for ; Tue, 7 Jan 2025 17:02:18 +0000 (UTC) X-FDA: 82981273956.01.5B0064F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 06073140016 for ; Tue, 7 Jan 2025 17:02:15 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NiT2woIW; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736269336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ml+i5Y031koGxlGfy9NVkgnxHVhu74Le2+yCtHwQa/c=; b=7J++ccS696rF0ZuHvByiYEdM4JN8Fkga7ww3R3UCesKtB732UfAYGdmtt9gpC95jM96jsJ 2O6NR41Hebxi8f9iPHfS+A8wkp/po5OOQRy6X+awKz3DrWwtdzRjMxIODk7EIQcP6D3/HM DfDCxyBxYyr08/vS3sib0b9etUNjGrU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736269336; a=rsa-sha256; cv=none; b=xF4tb14KTHy/YSdeuZyDuzy7GRRXMi2c/Wa75gw3MViHR8MqcnSFxL81B0UHCEZmuMoGUe xx6sQ1BC4XKQ7Du7IQlF1E8G/vdDlx1JwiHVHOin4SAZ03C9LPs0270RAvLn/A670HsGfk u90b207+EvoFvpENOH7oyGGRD3XLWPk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NiT2woIW; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736269335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ml+i5Y031koGxlGfy9NVkgnxHVhu74Le2+yCtHwQa/c=; b=NiT2woIWtjswimex6oJ9iLOtiZ4cgrb1oeKI1TN25Bf+cI1at/bSCY9dyp6BJVul3bGjK8 o/KMtYJaoMMwr18E+FG2wCFPm0IqRNKjtZl93hJwodwW5Pp6Mj0cRG4lDs40mvpGc1WBke HgsKBzt8TwLO4jDauQ5fw6A2g3f4bLg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-CL4B6WfRMmKq2_BHwsEkRA-1; Tue, 07 Jan 2025 12:02:14 -0500 X-MC-Unique: CL4B6WfRMmKq2_BHwsEkRA-1 X-Mimecast-MFC-AGG-ID: CL4B6WfRMmKq2_BHwsEkRA Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-436289a570eso121185395e9.0 for ; Tue, 07 Jan 2025 09:02:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736269333; x=1736874133; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ml+i5Y031koGxlGfy9NVkgnxHVhu74Le2+yCtHwQa/c=; b=YYNQXW7coCN7bFxzHmsCtGc+7tinNlkfdSbT4LNnuQQJULKjMxvsQOxxzdhbyvpBdA TUOGjqH6K9mjAEsvprio2OHy7dKrUH1RQaaeXqoUDf2FKnQ6YoYH7RAW6GpJGY/PIo0w h3Uba09e4o4tiDDEg8KYM9yZ9sgVo+fKjOhjHsIhJv9JDDOBTD6NbDseRacVb3DNlAeD 6jepJN40AY0Ep4Sb9r3PtN75AcNVPGd9pnatwbMTeOqhqXmCryS//aBv9tWw72s5mIN3 tYKGjBc4DtkXJ9fzDtHoMrDwL16yB0R/y38xkqsDw8ru85QAVIIUhojWw0AgemANMisN yNtw== X-Forwarded-Encrypted: i=1; AJvYcCW2beHldlJdy/dmezoB24k8ixl3ulEdsfij30jIlTklu9c31vytFpAcSHBOScQ+sLkr+rFYu1JQ6g==@kvack.org X-Gm-Message-State: AOJu0Yyu0no85n3t/HvBjiBcX8iM/H6YrAWbzIQnLSb6PgKZILjCc7Ho 8Z+58xECwxeYyalhGgIKNoJZIYl6RXwh6CsjvJKcayE5YCnWF4Px+2iAYxaVPefxca7+7c3/GP6 felBUVs4naxJGwNg9AUVY3PHOKUxFkVarMaUWOYp15yv5tLSF X-Gm-Gg: ASbGncuTpiZ8x6QSaHP8V/vublhQvvbHFf3lC2ScRzhMnEp4icvnDZ3DJ+8AF59ngoA GBL7pD0v7sbvwQHmHfQ0M6TQYY/EyyfOibQC/7NE0s/vjLaQfFR+ldjkiUMEixuiVZinBOnBoxp uEYv0khFwZ8CP71jSGBbI7iY/h8jrPELQbPWu9aA1F7VzOIYVXDEKOco82j6t8qIHJozm8BtAat S2gIGx04oaiUJ5ipcWUZudcC2nhfn8VT8Ndc6Bxe4FDVenCMohMICgNn6lJyDWYG7qs8kNzR19X U7oQqbdS8U+dn1vzk56R/okRTp2cKeDtoyH9bb6l3qwJJ/CYYNDVgAyLuwZPJojqj0t6x95zWiW aMWp0tTHT X-Received: by 2002:a05:600c:3b13:b0:436:488f:4f5 with SMTP id 5b1f17b1804b1-4366864420bmr544002905e9.19.1736269331142; Tue, 07 Jan 2025 09:02:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IH831uLh5Mj7aUB/xio+HRhWWKfF4N6mD9hkgVX9Y3KYGbbPzwcIxk+HQL/Ghab3kVNIgPl3w== X-Received: by 2002:a05:600c:3b13:b0:436:488f:4f5 with SMTP id 5b1f17b1804b1-4366864420bmr543998825e9.19.1736269328687; Tue, 07 Jan 2025 09:02:08 -0800 (PST) Received: from ?IPV6:2003:cb:c719:1700:56dc:6a88:b509:d3f3? (p200300cbc719170056dc6a88b509d3f3.dip0.t-ipconnect.de. [2003:cb:c719:1700:56dc:6a88:b509:d3f3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436611ea47asm603054135e9.4.2025.01.07.09.02.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 09:02:07 -0800 (PST) Message-ID: <559ea5ca-fea2-4a0a-a099-23e2d972f6e6@redhat.com> Date: Tue, 7 Jan 2025 18:02:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v1] mm/hugetlb_vmemmap: fix memory loads ordering To: Matthew Wilcox Cc: Yu Zhao , Andrew Morton , Mateusz Guzik , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Will Deacon References: <20250107043505.351925-1-yuzhao@google.com> <85ea0bc9-0892-489d-b42b-430ff8a1f368@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qH52U_o94EZ06cQXhpGRx-aq6-jLD80_C12tdkyhEss_1736269333 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 06073140016 X-Stat-Signature: hpazuh3gti8ka41yca9izhx6dzts93xa X-Rspam-User: X-HE-Tag: 1736269335-214773 X-HE-Meta: U2FsdGVkX1/D5pU+6ghh4oDzhLbIZBWaUw803H6nwlIxScshAuA9461NsPSgyHbs9fEQS/7TVWvVX9LAVrPM5ToCnvWDzXaJtAPY8nLwkLjRQhHDpCO/NsnHoQaRSo9T9i9BrJOsDlEpbjwMzV7LfwOjF3Z6P4434DIjhfxE/2VNeQim3dLllSgLfueNdebGpr1KVylCsTZo3AfRSbDUcAKX9uaGO6Ni2flGp3zdoFf+awWpp6Qus/MUMTZCnN3zVLN7nSb24JR4/jGXOoChkrbUwh3DdA+SP6x79IX4Ez8G326F3dyrpf+qJyp60it6rOrlRvHrP9yZ3k+dXHssWm+cC4A3j7zyIeyPjvOBMqNvkMIYnZg6JbFHeT1BVL5CQ8GETwy9h+TckNXPRJ1/JPrI+PBeqNxmmHicg6bxZqEe4yAzcQ7I9QFpCC0F+MvMVfNF5+fyPbj6Sjvq6xy5OcBIoBNOR3CniMC1ewDo4Zbsm5oFmUky3ISXN/qb3dPRiQ2KgBrVHAc66J0lSwoaRMCRxE9mB1NNyqtsRt/w+h9s0+7ixIlcEafkEUSsw7YvFUlwF8OcFF9nVVTBcdKuhQZz8+MQ9dLCrRjBp4c9afAMCpAWBk0YHHp4VFaA95vh5tRJOWDBQvOVkikvcdTIahlvVnfy4FZ/ZfPa9uD3mfh8ul3jF4GdQi2bvMcETL4w7Sm5oDt+z8pKV8In8lwPUxQU38yrIJo87bTi1+F68auVKlwVUqacpX+LSFxjXz9Qrf2eD26h/0Qa4zBAHHTMBaqK2j8VG/hbEKOUVvLPLWA9ohOhisNndjU5GPhekVOUedVZf3nruqezhjf+8EveP5fA97KQj+hrGNwumOck4mNy69bXhesRzUBQ16oDdNel+sG0/1RvHgGOa7HaYMNaMe9OyUNmKD6gB/F/kS8sEgCLBi0N0VG0/bv6YeU8kCqvnLy8fR+r99Lw8XzVpNz dralqmN2 7T3ox9+IQFOsw4szEUZEwcY4X6UN5MILN0H3lVvww2eWXCvaIX6ygyfkRaMnVgNJotLpaIsMbXOQXBPJGgLxahxyicu2nSMNQnCnV6+o5Hzz4OE0ozqnhaSebR5OeVVruOeFkiqSh+CEWvf/M2WCbg28N44q8yAXn++0Dv2v/8FQ2WggMcUvYxIR16RRvqUuWv1bF0Y88IdftU5ArPznOnh3ieZD62XyqpYgufYGGBKH001sbbG1bjShLOPGIISRx5DEAUBSXE3RJQkEOsZ3PPu756Rfe4ND2WQlS6tKHF6bAFST2oZHA7qbI6PQuBWBkd+CQiutgFaMvW84VxVHDVp28E9USrGwkgR3gnAmCO9L10NqFsjt15icO6FmtFr8uDWZ2wkaVOlXfVNFvUZqLvFpUVuRjmPuzK3RbCQzMJLniSebEYTXN8XGUKQVA4qEsWmgN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.01.25 17:35, Matthew Wilcox wrote: > On Tue, Jan 07, 2025 at 09:49:18AM +0100, David Hildenbrand wrote: >>> +++ b/include/linux/page-flags.h >>> @@ -212,7 +212,7 @@ static __always_inline const struct page *page_fixed_fake_head(const struct page >>> * cold cacheline in some cases. >>> */ >>> if (IS_ALIGNED((unsigned long)page, PAGE_SIZE) && >>> - test_bit(PG_head, &page->flags)) { >>> + test_bit_acquire(PG_head, &page->flags)) { >> >> This change will affect all page_fixed_fake_head() users, like ordinary >> PageTail even on !hugetlb. > > I've been looking at the callers of PageTail() because it's going to > be a bit of a weird thing to be checking in the separate-page-and-folio > world. Obviously we can implement it, but there's a bit of a "But why > would you want to ask that question" question. > > Most current occurrences of PageTail() are in assertions of one form or > another. Fair enough, not performance critical. > > make_device_exclusive_range() is a little weird; looks like it's trying > to make sure that each folio is only made exclusive once, and ignore any > partial folios which overlap the start of the area. I could have sworn we only support small folios here, but looks like we do support large folios. IIUC, there is no way to identify reliably "this folio is device exclusive", the only hint is "no mappings". The following might do: diff --git a/mm/rmap.c b/mm/rmap.c index c6c4d4ea29a7e..1424d0a351a86 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -2543,7 +2543,13 @@ int make_device_exclusive_range(struct mm_struct *mm, unsigned long start, for (i = 0; i < npages; i++, start += PAGE_SIZE) { struct folio *folio = page_folio(pages[i]); - if (PageTail(pages[i]) || !folio_trylock(folio)) { + + /* + * If there are no mappings, either the folio is actually + * unmapped or only device-exclusive swap entries point at + * this folio. + */ + if (!folio_mapped(folio) || !folio_trylock(folio)) { folio_put(folio); pages[i] = NULL; continue; > > damon_get_folio() wants to fail for tail pages. Fair enough. > > split_huge_pages_all() is debug code. > > page_idle_get_folio() is like damon. > > That's it. We don't seem to have any PageTail() callers in critical > code any more. Ah, you're right. Interestingly, PageTransTail() is even unused? -- Cheers, David / dhildenb