[PATCH] mm:Change unlabeled block of code to a else block in the function dma_pool_free

[PATCH] mm:Change unlabeled block of code to a else block in the function dma_pool_free

[Nicholas Krause]

This fixes the unlabeled block of code after the if statement that
executes if the passed dma variable of type dma_addr_t minus the
structure pointer page's dma member is equal to the variable offset
into a else block as this block should run when the if statement check

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 mm/dmapool.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index fd5fe43..ce7ff4b 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -434,8 +434,7 @@ void dma_pool_free(struct dma_pool *pool, void *vaddr, dma_addr_t dma)
 			       "dma_pool_free %s, %p (bad vaddr)/%Lx\n",
 			       pool->name, vaddr, (unsigned long long)dma);
 		return;
-	}
-	{
+	} else {
 		unsigned int chain = page->offset;
 		while (chain < pool->allocation) {
 			if (chain != offset) {
-- 
2.1.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm:Change unlabeled block of code to a else block in the function dma_pool_free

[Andrew Morton]

On Mon,  6 Jul 2015 19:30:31 -0400 Nicholas Krause <xerofoify@gmail.com> wrote:

> This fixes the unlabeled block of code after the if statement that
> executes if the passed dma variable of type dma_addr_t minus the
> structure pointer page's dma member is equal to the variable offset
> into a else block as this block should run when the if statement check
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  mm/dmapool.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/dmapool.c b/mm/dmapool.c
> index fd5fe43..ce7ff4b 100644
> --- a/mm/dmapool.c
> +++ b/mm/dmapool.c
> @@ -434,8 +434,7 @@ void dma_pool_free(struct dma_pool *pool, void *vaddr, dma_addr_t dma)
>  			       "dma_pool_free %s, %p (bad vaddr)/%Lx\n",
>  			       pool->name, vaddr, (unsigned long long)dma);
>  		return;
> -	}
> -	{
> +	} else {
>  		unsigned int chain = page->offset;
>  		while (chain < pool->allocation) {
>  			if (chain != offset) {

This patch has no effect?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm:Change unlabeled block of code to a else block in the function dma_pool_free

[nick]

On 2015-07-07 06:41 PM, Andrew Morton wrote:
> On Mon,  6 Jul 2015 19:30:31 -0400 Nicholas Krause <xerofoify@gmail.com> wrote:
> 
>> This fixes the unlabeled block of code after the if statement that
>> executes if the passed dma variable of type dma_addr_t minus the
>> structure pointer page's dma member is equal to the variable offset
>> into a else block as this block should run when the if statement check
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>>  mm/dmapool.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/mm/dmapool.c b/mm/dmapool.c
>> index fd5fe43..ce7ff4b 100644
>> --- a/mm/dmapool.c
>> +++ b/mm/dmapool.c
>> @@ -434,8 +434,7 @@ void dma_pool_free(struct dma_pool *pool, void *vaddr, dma_addr_t dma)
>>  			       "dma_pool_free %s, %p (bad vaddr)/%Lx\n",
>>  			       pool->name, vaddr, (unsigned long long)dma);
>>  		return;
>> -	}
>> -	{
>> +	} else {
>>  		unsigned int chain = page->offset;
>>  		while (chain < pool->allocation) {
>>  			if (chain != offset) {
> 
> This patch has no effect?
> 
It's a cleanup as clearly people didn't make this into a if/else statement block as clearly this 
needs to run if the if statement fails and making into a else block makes this easier to understand
them a unnamed block. If you prefer we can just remove the brackets creating this block otherwise
that's my reasoning.
Nick 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>