From: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
To: Shaohua Li <shli@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: next-20130128 lockdep whinge in sys_swapon()
Date: Thu, 31 Jan 2013 13:45:14 -0500 [thread overview]
Message-ID: <5595.1359657914@turing-police.cc.vt.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]
Seen in my linux-next dmesg. I'm suspecting commit ac07b1ffc:
commit ac07b1ffc27d575013041fb5277dab02c661d9c2
Author: Shaohua Li <shli@kernel.org>
Date: Thu Jan 24 13:13:50 2013 +1100
swap: add per-partition lock for swapfile
as (a) it was OK in -20130117, and (b) 'git blame mm/swapfile.c | grep 2013'
shows that commit as the vast majority of changes.
[ 42.498669] INFO: trying to register non-static key.
[ 42.498670] the code is fine but needs lockdep annotation.
[ 42.498671] turning off the locking correctness validator.
[ 42.498674] Pid: 1035, comm: swapon Not tainted 3.8.0-rc5-next-20130128 #52
[ 42.498675] Call Trace:
[ 42.498681] [<ffffffff81073dc8>] register_lock_class+0x103/0x2ad
[ 42.498685] [<ffffffff812493ad>] ? __list_add_rcu+0xc4/0xdf
[ 42.498688] [<ffffffff81075573>] __lock_acquire+0x108/0xd63
[ 42.498691] [<ffffffff810b482b>] ? trace_preempt_on+0x12/0x2f
[ 42.498695] [<ffffffff81608e6e>] ? sub_preempt_count+0x31/0x43
[ 42.498699] [<ffffffff810fda36>] ? sys_swapon+0x6f9/0x9d9
[ 42.498701] [<ffffffff810764f2>] lock_acquire+0xc7/0x14a
[ 42.498703] [<ffffffff810fda62>] ? sys_swapon+0x725/0x9d9
[ 42.498706] [<ffffffff81605023>] _raw_spin_lock+0x34/0x41
[ 42.498708] [<ffffffff810fda62>] ? sys_swapon+0x725/0x9d9
[ 42.498710] [<ffffffff810fda62>] sys_swapon+0x725/0x9d9
[ 42.498712] [<ffffffff8107520a>] ? trace_hardirqs_on_caller+0x149/0x165
[ 42.498715] [<ffffffff8160be92>] system_call_fastpath+0x16/0x1b
[ 42.498719] Adding 2097148k swap on /dev/mapper/vg_blackice-swap. Priority:-1 extents:1 across:2097148k
Somebody care to sprinkle the appropriate annotations on that code?
[-- Attachment #2: Type: application/pgp-signature, Size: 865 bytes --]
next reply other threads:[~2013-01-31 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 18:45 Valdis Kletnieks [this message]
2013-02-04 1:46 ` Minchan Kim
2013-02-05 15:49 ` Valdis.Kletnieks
2013-01-31 19:08 Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5595.1359657914@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox