From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9377C54EBD for ; Mon, 9 Jan 2023 12:27:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34D468E0002; Mon, 9 Jan 2023 07:27:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FC958E0001; Mon, 9 Jan 2023 07:27:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C4C88E0002; Mon, 9 Jan 2023 07:27:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0892D8E0001 for ; Mon, 9 Jan 2023 07:27:31 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CA7B41C5ACF for ; Mon, 9 Jan 2023 12:27:30 +0000 (UTC) X-FDA: 80335186260.14.6000884 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf26.hostedemail.com (Postfix) with ESMTP id 07EF714000B for ; Mon, 9 Jan 2023 12:27:28 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="HHzBk/XX"; spf=pass (imf26.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673267249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EE9Qcu3z7v0X1mDBiTnwrZNHkM5hhkyxidu/GsNr9gE=; b=INI9CnCPiW0IwEwL+MsszkvkkWxCeqwItUF4kWURKRkiwC/y2Z0ltLLoKMSdbmg1MR51I4 rohqaQV7zg8m30xUXG88es5rH4cjVEr8hP8g5ihWJc1irfpAujx9uyvQqa7qzVkD2MCNKl IAqNWbXQNluruP3mcrFKbb5ljoDDhOo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="HHzBk/XX"; spf=pass (imf26.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673267249; a=rsa-sha256; cv=none; b=TwZeX2+Ym3deXSdJC28rboLJAk3vIdUf6nCUVnTw0dFW1dcmlozmr9XspLU07TVJ6sd69R 4RbkNEuY9AencW48ghHEuI9nABc+SmO0Kw9STts6pdjAU2Lh1ZV65MKaNWYlATihg5BTvE K+oJ4x0lStiZugdxar6Tep3JSqPVb6s= Received: by mail-ej1-f46.google.com with SMTP id gh17so19668350ejb.6 for ; Mon, 09 Jan 2023 04:27:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EE9Qcu3z7v0X1mDBiTnwrZNHkM5hhkyxidu/GsNr9gE=; b=HHzBk/XXxKPMa9zUSD9579QR5DxcZC3rzr3DEr5jBImYvCav0lC2uLSz2p4UIdM3yS QtU+YvqpEJh0REQKXF8u0yMRQlnoesXArX9PY+OSHfJBwoO6mB8ySHK4Rg5CeUXNYm5N ftqQInbPmtmn29BjImohXMZXrznjqFlLGaE/yx0ghEO7wIyEDYKj8JoVgma4mj3h766m lg7CeNfTzuS2Naa6AClN/tFCRUj68rJi9Mvb17A/eEaO3+JdOm77YQVlFM0aSOCvDh2L oNCjW3F+gKAxDsCpiVD3NjE1IURBzvdnMsJaLndwN0Pxn2ExWcO5vB5R5oPV/h4B7Qj7 kQCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EE9Qcu3z7v0X1mDBiTnwrZNHkM5hhkyxidu/GsNr9gE=; b=CVAYsDgsEOqK1jhuECMv7eXRMRbdX7+uKG48MFclUV+Qb412SywwcCuBuzRFwv4bma Poa/wHWVgjHZ43vBoruUMZQg5pVPFspvNeZAGWqbbb5CCR8QN+LWQraEzeL9ljb0GaJS Rcpuy5YCFPBK8Xv82wpZ9ScNE0S0vb6XARwyoWLLL2VCAVB3VaviKZ8JDpUlq+gOdwlM 4Rj9DZVprwKS8ZDwR8+cghUw7DYv5zaAMvh4eam3eHVRLa2zk9O0CIaDpkfRgRkKBgqV iMf/8CLN9MB0IbZ/x212a3InShysicNw2VVK0mtPsAzvgfJc/sZpT/DKeEJhzk+PiB8w TnSA== X-Gm-Message-State: AFqh2krRhn97PyfseWxFFy5Nq530YCCKVR+unPy42xrQk3UUJeWlJgk4 2H+YFZPrzJLxjPVpnKZX3VQ= X-Google-Smtp-Source: AMrXdXvvwhSuYxEZ/vXA8iDG4gVWSSLPZRUvc6Wv/irVmyVsFev+hVU81J5c0x5xAVDuboCskbw1jw== X-Received: by 2002:a17:906:398f:b0:7fd:ec83:b8b9 with SMTP id h15-20020a170906398f00b007fdec83b8b9mr53095058eje.44.1673267247674; Mon, 09 Jan 2023 04:27:27 -0800 (PST) Received: from [10.158.37.55] ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id e21-20020aa7d7d5000000b0048ca2b6c370sm3662719eds.29.2023.01.09.04.27.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 04:27:27 -0800 (PST) Message-ID: <558a8db8-ee66-b333-a065-0f4e83646232@gmail.com> Date: Mon, 9 Jan 2023 14:27:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 24/24] mlx5: Convert to netmem Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Jesper Dangaard Brouer , Ilias Apalodimas Cc: netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-25-willy@infradead.org> From: Tariq Toukan In-Reply-To: <20230105214631.3939268-25-willy@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 07EF714000B X-Stat-Signature: fxi1866rmm688a5naya569ry94r5na3t X-HE-Tag: 1673267248-792081 X-HE-Meta: U2FsdGVkX188wcPoUulHOr0fiu79vWZeVjXaRm9p14i3Xy+rvAsu+wluJaLhg0/UkdSsHpH+23aBRwv1Ki+VZyy9bVYuHCf/xVTUKLGrVhFJph50TA1WpxSsH/PdtM2BbzvZB7nj49l3wi8rwno7yFCAvqzImG1WjsnbcpCeM8tAXnuIjZeoB+NQCXivHeZjO6qd8BeyTSs8B8+S5pdB/UjgmxwacTsssc33NPKgdTRSd+ensksGRpYwR8KOPZ1AqI4XuYtXCGZI5MZli+pY4Kx3qLTxm7+/vcg5cZWSB2clfBduNJQy/9G2ZQGXzMpJJeuRtOBkQa9SKTTAWWY0RqYe3BhH9NexxgY3TB3AjQ7mXAX3Lscv8mBBXhN0Oy6pwnvuifU1sNpIhKOv3ie9ETmsqSa1sqJsQ+i1ah1beAPotfmI7uuVYZE4ridtCum+sLFxB99c7/ypQesTZzrNy1Epta3yMykIQm8UaDe1Q4H+zfXWh12AfOlcNZQTk9hDnI+6ilO0SBk2WUtvX1q0ojh7yJ8haUQfF3VKn5iCsIwxvUlKO7CTu7IDBGYj8if+9m7jqBobAP10yGm82S0a0V9zsHqihsl2+TAffH3B5/t6xut7eMOeD0Oz5pjTDMxWWeK3Nbieh7veLtemPPHCJknSQgEMgRLuX4arivCiK+KpK14Orn/2BwnEh99Dugzd6/iz6sFWohSPx5LN8jwgUnTtnmkRObtZZjvpopHTHjshD/R4RFncmhniD0tFdoGqW7EgpixZH2lkqSqqzE1YIaMn9glxd9Hqg9huEjQ3E3pDw39rpgNDyhlgDnj46ril/XpqWYK1TRqu9kCmzm7e9jiwxr9asSk1F0V4AHU/n9vLLj2voo1YMhaM2zctBjboNNpPfPQNUMPWsmWR6aSqMpuUZJ1+4/GXSMBmKcWBZiLTDqJTG7pcpKWOw3KY6TJceT2JZaXibUkNOD677Cl til6AWlw jyaIvAUY+8jrfjmgmQPiMhek5/Mz0UXHNISUUFBq569l6/0pxhmg02vO+EanKaRl1rO8aacQw5XXxKCs5+ywAdFyw7FyfhX2/NqpTxVjdR9qwQmfnUJXLv+7iqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/01/2023 23:46, Matthew Wilcox (Oracle) wrote: > Use the netmem APIs instead of the page_pool APIs. Possibly we should > add a netmem equivalent of skb_add_rx_frag(), but that can happen > later. Saves one call to compound_head() in the call to put_page() > in mlx5e_page_release_dynamic() which saves 58 bytes of text. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > drivers/net/ethernet/mellanox/mlx5/core/en.h | 10 +- > .../net/ethernet/mellanox/mlx5/core/en/txrx.h | 4 +- > .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 24 ++-- > .../net/ethernet/mellanox/mlx5/core/en/xdp.h | 2 +- > .../net/ethernet/mellanox/mlx5/core/en_main.c | 12 +- > .../net/ethernet/mellanox/mlx5/core/en_rx.c | 130 +++++++++--------- > 6 files changed, 94 insertions(+), 88 deletions(-) > Thanks for your patch! Reviewed-by: Tariq Toukan Tariq