linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Martin KaFai Lau <kafai@fb.com>
Cc: Tejun Heo <tj@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Christoph Lameter <cl@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [RFC NEXT] mm: Fix suspicious RCU usage at kernel/sched/core.c:7318
Date: Tue, 16 Jun 2015 21:43:28 -0500	[thread overview]
Message-ID: <5580DED0.3060002@lwfinger.net> (raw)
In-Reply-To: <20150616210720.GC3958923@devbig242.prn2.facebook.com>

On 06/16/2015 04:07 PM, Martin KaFai Lau wrote:
> On Mon, Jun 15, 2015 at 04:25:18PM -0500, Larry Finger wrote:
>> Additional backtrace lines are truncated. In addition, the above splat is
>> followed by several "BUG: sleeping function called from invalid context
>> at mm/slub.c:1268" outputs. As suggested by Martin KaFai Lau, these are the
>> clue to the fix. Routine kmemleak_alloc_percpu() always uses GFP_KERNEL
>> for its allocations, whereas it should use the value input to pcpu_alloc().
> Just a minor nit, 'kmemleak_alloc_percpu() should follow the gfp from
> per_alloc()' may be a more accurate title to describe the patch.

Do you mean that the subject should be changed?

Larry


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-06-17  2:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15 21:25 Larry Finger
2015-06-16  5:37 ` Kamalesh Babulal
2015-06-16  6:02   ` Larry Finger
2015-06-16  8:44 ` Catalin Marinas
2015-06-16  8:48   ` Catalin Marinas
2015-06-16 21:07 ` Martin KaFai Lau
2015-06-17  2:43   ` Larry Finger [this message]
2015-06-17  4:15     ` Martin KaFai Lau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5580DED0.3060002@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=catalin.marinas@arm.com \
    --cc=cl@linux-foundation.org \
    --cc=kafai@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox