From: David Hildenbrand <david@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memory_hotplug: Rename all existing 'memhp' into 'mhp'
Date: Mon, 25 Jan 2021 09:54:49 +0100 [thread overview]
Message-ID: <557ea028-6b6f-6f32-7602-70a62050a3e3@redhat.com> (raw)
In-Reply-To: <YA6AqupAWINtNckx@kroah.com>
On 25.01.21 09:26, Greg Kroah-Hartman wrote:
> On Mon, Jan 25, 2021 at 11:24:53AM +0530, Anshuman Khandual wrote:
>> This renames all 'memhp' instances to 'mhp' except for memhp_default_state
>> for being a kernel command line option. This is just a clean up and should
>> not cause a functional change.
>
> THat says _what_ you are doing, but I have no idea _why_ this is needed
> for anything...
>
Let's add something like
"Let's make it consistent, especially preparing for more users of the
'mhp' terminology."
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-01-25 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 5:54 Anshuman Khandual
2021-01-25 8:26 ` Greg Kroah-Hartman
2021-01-25 8:51 ` Anshuman Khandual
2021-01-25 9:25 ` Greg Kroah-Hartman
2021-01-25 8:54 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557ea028-6b6f-6f32-7602-70a62050a3e3@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox