From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E45C001DE for ; Fri, 28 Jul 2023 04:30:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 574396B0072; Fri, 28 Jul 2023 00:30:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 524926B0074; Fri, 28 Jul 2023 00:30:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EC696B0075; Fri, 28 Jul 2023 00:30:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2FE6A6B0072 for ; Fri, 28 Jul 2023 00:30:39 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5E0A61A07F6 for ; Fri, 28 Jul 2023 04:30:38 +0000 (UTC) X-FDA: 81059744556.02.1D4E7B8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 9907E16000E for ; Fri, 28 Jul 2023 04:30:34 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fC0tkbKy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of mpenttil@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpenttil@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690518636; a=rsa-sha256; cv=none; b=V5P6EBgjH4GerOvPe0Q4jupzxefGZtotUvhxAclLbWGis8Gxe6o4zI9z99mfrH9l3ESVem 0QPbxs/113zjVp0fXN0DEXsrg4g84Xq7jaabZetgKLmtwgYoX1D8BYDJDZfiP+V/Qlksdl VIyLuectNxAMyZMerJsRsDHHW35SYCk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fC0tkbKy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of mpenttil@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpenttil@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690518636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OqviSGXIb7Tqt0NEZdsJaNkD5vh2uKzL/1s+FdO+i5k=; b=5WrGBkyP6u+rQ10UljLcMySa23TnGlSX80kUba2e19ZaUEX0AwLnsb3S4eiSqnyDv0y7Nm w5591+4xA1TwbG53HidX+AwhDuzfRXVEj1Bz4vy5SiVWeLQ+2nFtViqy1jQJkgbo+tFFOF H6ZJKMcBYDZ1Pjql6WC3MD9RRt+o46k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690518633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OqviSGXIb7Tqt0NEZdsJaNkD5vh2uKzL/1s+FdO+i5k=; b=fC0tkbKy1HiJRm1s8yUxNQuKVL3kcJ9Leo+yHNzZXURa9smmZoNqzfDdxuJDnotU0f6RMM EKGGZWdWnUtrgqjNR4saSztMBJf0hA+fjggWCtcXXTSYKAh1jrwOuHx/eY3W4MBcynoEkC Dks3bOmDDMpJdJzdQpCIgpqe8D3tyww= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-131-e1aAhW9iMo-wv7G1D4oVuA-1; Fri, 28 Jul 2023 00:30:32 -0400 X-MC-Unique: e1aAhW9iMo-wv7G1D4oVuA-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2b9b00a80e9so14472651fa.1 for ; Thu, 27 Jul 2023 21:30:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690518631; x=1691123431; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OqviSGXIb7Tqt0NEZdsJaNkD5vh2uKzL/1s+FdO+i5k=; b=iGW7h/Qc8bmEqmf/TVJ+Ef4C+zNmCy1sspdhYNGY6Wk6QD8X79eG8Mv3h2bS5GL1cI +RSIWvvj4C22gesHAZn+mwOvkMVVeDOBQh44pUSatMglJxbe0ocWC9tRSKJ87vZ+jrgF enr5v9dEgS7+Yqq1mhFlmFsU35YfwtWLnL9zFrXq9LuM3AtAuZxMJTv6auCxyfqahkYj fhg1sCGkifwKoB9b5Cb64LJPYElvQvdV4N5fdFpFx75MKATbOfjFjuJ33Q1qSzHmxWa5 XNh2inlDxdZOAhBvEyTlWMPVCj0sdvkh+bVZyIVPMjs6V9cQ5nvUvU0Fd8yF9lBHLvVI ykxw== X-Gm-Message-State: ABy/qLZHHf6n5BzArxibgeX5IONtNsCy5gn4X9UJWWxagxsnYrHGwLyK SRaSUwvxNgnoJgW/6wYGcYWwa/01G6Qj1Mkgvuuhgugl6D688Q3bgvlwNqr6fTBOnO/ulw/ZaU3 6FLmo3IEQzw== X-Received: by 2002:a2e:7410:0:b0:2b9:c55f:f24e with SMTP id p16-20020a2e7410000000b002b9c55ff24emr651103ljc.52.1690518630910; Thu, 27 Jul 2023 21:30:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlEPBGh2+4NUMNrZs/Y80pwXkiBchQVPupt4ninzotlZR03t/gk8gqwtImPmZPiAQiE/nZAs7A== X-Received: by 2002:a2e:7410:0:b0:2b9:c55f:f24e with SMTP id p16-20020a2e7410000000b002b9c55ff24emr651087ljc.52.1690518630590; Thu, 27 Jul 2023 21:30:30 -0700 (PDT) Received: from [192.168.1.86] (85-23-20-79.bb.dnainternet.fi. [85.23.20.79]) by smtp.gmail.com with ESMTPSA id p7-20020a2e7407000000b002b9342fcd62sm694944ljc.67.2023.07.27.21.30.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 21:30:29 -0700 (PDT) Message-ID: <55750855-0029-b10f-3317-e6ae4d89d492@redhat.com> Date: Fri, 28 Jul 2023 07:30:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [v1 4/6] memblock: introduce MEMBLOCK_RSRV_NOINIT flag To: Usama Arif , linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, rppt@kernel.org Cc: linux-kernel@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com, simon.evans@bytedance.com, punit.agrawal@bytedance.com References: <20230727204624.1942372-1-usama.arif@bytedance.com> <20230727204624.1942372-5-usama.arif@bytedance.com> From: =?UTF-8?Q?Mika_Penttil=c3=a4?= In-Reply-To: <20230727204624.1942372-5-usama.arif@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9907E16000E X-Stat-Signature: 8ouywgd7a4bswkymuqyj36ens5c3ixmj X-HE-Tag: 1690518634-8023 X-HE-Meta: U2FsdGVkX19QrF85kGhK2n0ksbzsQwxW6VEBQgpw+mmf8YxoO17xq/kUWToePUpYaeqxfCTHQ/i7J36WD9zc4p3eNvmW/fRgizXfsJV/MOnlfqmFmML5SZWP7BRpnzeB8FNmuZaTyw3zdIC7QiHoR5eNF99KglcEPNw77Tt6rG9UFgZg0CxAsVjA9nyUok8M25TjhmanTwBJZobP1xdgEpmlGM0skMO2c7O4NWNX2BxyzN+w7gSmZabQFw6wn2gFMr3PGtVfM3s/vIRC/LrrLPtDQTiSl+AnSf/GwQWeU5UiNrQUai7aDcsSVtTAQ+cP7Qdehf9pwb9O7RFZ3L2aXmL0yCDz5j23o9OLWYJZR+ftJvdv4Yi/Y8qs1SPksnbePykUnUCfRzWSz0MgYUzDnzxDhoVfrXREDy3zXN6UGCgCLWPM2qOiN1j4/uSYM/ibcLi8cZy+qxGWlGI99VqVXwN9l0xhjk6wt3EeEJdB6MPrN0T/cD6+OjAOvTtpf6nniQQ6jYd7IDzgxnLXixdhi+GMkJWKg79yjpLzUCRYI9vmHQzuoTlSrdr9GWJx6PWx8QcoHhvLL0V9c4Ay9cL0e61NGQ5rFdPzQz4Z0TY+Xzbs/smuuYiQ1Qy0zZeaAp2//aFze21qDqEJ3gMO2wzmxLMgmFhnocPERcj1esWaxhmQpHDctIap1u+ELoqYvy3iHhR5VSwKsD8x+Z/J8XN2TNOLU83btkGFdrDBHKnoaCi9N8RVlvVkV9XHPMDWct29RlBKszmo27iJx1ViA3RvsSI0+xMeZY3l0EINKelowtbR2C1EKS0uLsZ+p1d4+l83yMhQLOhjZPDtJCdvQwcfc18lmoldUkusr7Hy3e2adK2kjvgN6vE3eEoEjNm5vPk3QYqSM+9/PV23pZJg42s/LFba3hK3ZAZhNJo26KMKVi8pidPdrr/5lHg9lwF7UYdNv0sxvG4zqYKMhZWmRTg 2tmZEp9C epAGmxiLAa4BXCuRDzvT+GJmujdRvgZBHiFs10WfPDavWsJD8QQ3FgzFJRJvhUqsaVTIwqhqFD1jLOqjknBWkpdDVn90wnin2cK/5jRXQ/zSTf2vrjLqzeqjem9+xT9T4fdCWE7yhIJPQ7m9jaZq8CIKoIxF5sKLLJQvRy/Xd3fG4lqIbKHMpLtr9GbGKrHY5O0h/Q3GUVBnyf4WtSqzlWNTpUE1jwxBk8IKHeE07YAN9JleQSobAUwKEZCFkrwjbgl7C12FzcucJRCEh/2naPxcFWm/YjIUUUkomOXC4sojqYm8zJcwHSeElwsJQIrXSgsyWUN3pZ3VGzpaA3H8OiUQG7nymz3HvIIN+h7iDYBaDdGTAbWGV7SyHXcc2e29hWVZIz7r0RencqF+/PVtlP3uu3EfIjrR9MV//szztgb3FK5fX85Ohd3EfIawbjoYl+W2CjtcgLNGgOLb7FqUiXRQfxYGkh0ANgY//tsg9oWEzBtraEQjvrIHJNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 7/27/23 23:46, Usama Arif wrote: > For reserved memory regions marked with this flag, > reserve_bootmem_region is not called during memmap_init_reserved_pages. > This can be used to avoid struct page initialization for > regions which won't need them, for e.g. hugepages with > HVO enabled. > > Signed-off-by: Usama Arif > --- > include/linux/memblock.h | 7 +++++++ > mm/memblock.c | 32 ++++++++++++++++++++++++++------ > 2 files changed, 33 insertions(+), 6 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index f71ff9f0ec81..7f9d06c08592 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -47,6 +47,7 @@ enum memblock_flags { > MEMBLOCK_MIRROR = 0x2, /* mirrored region */ > MEMBLOCK_NOMAP = 0x4, /* don't add to kernel direct mapping */ > MEMBLOCK_DRIVER_MANAGED = 0x8, /* always detected via a driver */ > + MEMBLOCK_RSRV_NOINIT = 0x10, /* don't call reserve_bootmem_region for this region */ > }; > > /** > @@ -125,6 +126,7 @@ int memblock_clear_hotplug(phys_addr_t base, phys_addr_t size); > int memblock_mark_mirror(phys_addr_t base, phys_addr_t size); > int memblock_mark_nomap(phys_addr_t base, phys_addr_t size); > int memblock_clear_nomap(phys_addr_t base, phys_addr_t size); > +int memblock_rsrv_mark_noinit(phys_addr_t base, phys_addr_t size); > > void memblock_free_all(void); > void memblock_free(void *ptr, size_t size); > @@ -259,6 +261,11 @@ static inline bool memblock_is_nomap(struct memblock_region *m) > return m->flags & MEMBLOCK_NOMAP; > } > > +static inline bool memblock_is_noinit(struct memblock_region *m) > +{ > + return m->flags & MEMBLOCK_RSRV_NOINIT; > +} > + > static inline bool memblock_is_driver_managed(struct memblock_region *m) > { > return m->flags & MEMBLOCK_DRIVER_MANAGED; > diff --git a/mm/memblock.c b/mm/memblock.c > index 4fd431d16ef2..3a15708af3b6 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -997,6 +997,22 @@ int __init_memblock memblock_clear_nomap(phys_addr_t base, phys_addr_t size) > return memblock_setclr_flag(base, size, 0, MEMBLOCK_NOMAP, 0); > } > > +/** > + * memblock_rsrv_mark_noinit - Mark a reserved memory region with flag MEMBLOCK_RSRV_NOINIT. > + * @base: the base phys addr of the region > + * @size: the size of the region > + * > + * For memory regions marked with %MEMBLOCK_RSRV_NOINIT, reserve_bootmem_region > + * is not called during memmap_init_reserved_pages, hence struct pages are not > + * initialized for this region. > + * > + * Return: 0 on success, -errno on failure. > + */ > +int __init_memblock memblock_rsrv_mark_noinit(phys_addr_t base, phys_addr_t size) > +{ > + return memblock_setclr_flag(base, size, 1, MEMBLOCK_RSRV_NOINIT, 1); > +} > + > static bool should_skip_region(struct memblock_type *type, > struct memblock_region *m, > int nid, int flags) > @@ -2113,13 +2129,17 @@ static void __init memmap_init_reserved_pages(void) > memblock_set_node(start, end, &memblock.reserved, nid); > } > > - /* initialize struct pages for the reserved regions */ > + /* > + * initialize struct pages for reserved regions that don't have > + * the MEMBLOCK_RSRV_NOINIT flag set > + */ > for_each_reserved_mem_region(region) { > - nid = memblock_get_region_node(region); > - start = region->base; > - end = start + region->size; > - > - reserve_bootmem_region(start, end, nid); > + if (!memblock_is_noinit(region)) { > + nid = memblock_get_region_node(region); > + start = region->base; > + end = start + region->size; > + reserve_bootmem_region(start, end, nid); > + } > } > } > There's code like: static inline void free_vmemmap_page(struct page *page) { if (PageReserved(page)) free_bootmem_page(page); else __free_page(page); } which depends on the PageReserved being in vmempages pages, so I think you can't skip that part? --Mika