From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E9AFC369D9 for ; Wed, 30 Apr 2025 21:49:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A0B96B00C9; Wed, 30 Apr 2025 17:49:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7285A6B00CD; Wed, 30 Apr 2025 17:49:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 551156B00CF; Wed, 30 Apr 2025 17:49:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 32B3E6B00C9 for ; Wed, 30 Apr 2025 17:49:31 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3D57B160F13 for ; Wed, 30 Apr 2025 21:49:31 +0000 (UTC) X-FDA: 83392052142.02.F5C16EB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id D620FA000C for ; Wed, 30 Apr 2025 21:49:28 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X4aGwKpX; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746049768; a=rsa-sha256; cv=none; b=keAxpTxZrvzDBHXwFKiVcXpB491SAUvbA0LikMCccZZPtykVeCrIwFJO1qVuyh7Co16/kO a3QYOdbXPoR2uvOtpcJGfZtmdivG/UOkP+1J8ts7dMiPPNsFGuTW6utoyLgVxJVXjter4o mmY91je998IDCSMYoyzpt6JKIhy+AcM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X4aGwKpX; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746049768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T7/P2eHxVjPJoDuuG0iv5Uz560VChzz0yK3nOkTrqLs=; b=LjsA0JzHwez0LmIfIB4+hyPYs8XLsxqrnCURATd7RgTYJiLWize1ysc8/u0yPP2zCi88om RpEuvlSvbRpfy/L4k/cP0AkIEqzvbaL02p/xMRuKHnbqMNL7OHza4wKruBvokec1UKPdV8 epWkHT0ogiaRHLFK3l8aL9UNTXzmH6k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746049768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=T7/P2eHxVjPJoDuuG0iv5Uz560VChzz0yK3nOkTrqLs=; b=X4aGwKpXIzOCYop3FJrG68tuF/O5um/NYAPu+xX8hnyifNDL5W4+TcHAYVZwmnxOIgl8+N hnjEu6Pslr3TOLDFj1HbwXc1g4CfzeoNIwPfuMpwxzbNipPbpjKoxcrMf4qB3qVT/GjI5N E79trvvholZvH4Nnn4mBuJ84qGZ0tww= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-LzRB-CzrOPGljtyOA8j-aQ-1; Wed, 30 Apr 2025 17:49:26 -0400 X-MC-Unique: LzRB-CzrOPGljtyOA8j-aQ-1 X-Mimecast-MFC-AGG-ID: LzRB-CzrOPGljtyOA8j-aQ_1746049766 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cf44b66f7so1336385e9.1 for ; Wed, 30 Apr 2025 14:49:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746049766; x=1746654566; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T7/P2eHxVjPJoDuuG0iv5Uz560VChzz0yK3nOkTrqLs=; b=k/zvqC0mR0naX5MvmyA7WdQvqDTWpKlqljOjDIS2tulFB1Hcm2Z1Ge1gv2XG9nE29v k4zqwtbKnFDHhmMHa3uC4kUkAWQkmYPbMV2cc7IfPrg86i2P807xxp1NShLuXZLcA0+l X53HKrXondnEeScxFRLRMNR3UZbxzpY/5/tgqfgk65KyhuRJo9jSrA+dNwXcrvbG1Ym2 /oXhghPXOTvVHU1gJfEhsgfrOjFybSMlFANAq+VTVRLO/o796VdWQ8LHbWIlLCImdYnk Xr4NJTTp+V2PwC38BZj6Jb83BBW7KZpS4IB0Lo7SMbtr6aHn6sV/m6WG9deMRsubOEQp H8Tw== X-Forwarded-Encrypted: i=1; AJvYcCUczDVEO962lxvdNrxUUvQNG7dspYMq/9KqXvbnC88/YOGAfalHw7il4bpcmSKQuQRcpX6JGA7sBQ==@kvack.org X-Gm-Message-State: AOJu0YwEW78gNtyV10OGVegJaH5A+lh6/XbS+IfEb+qKmY5LXZlYycrv L3Os8wxTu/jL+8MUUb6GmMIVwvb9mfgqOsll4klLii3gHcJw6YaPKamsw030yW0AL/FQDvA3uB/ fTIycpupin//XRg+Njl0N1GPqn51pwFaLbtZBPNFf5BuiBD62PTC9+N+jtZplGA== X-Gm-Gg: ASbGnctwLACxIA36g+IjhRoxXkXEilkCMz/yYmg31KKON+EHCjfzpj6Q/wWLNZQbB5x UUVPpD/0IpEnMT6+sHn24l7rPwOvxQZHLxWHum4lalKRcPP+sZiN34XPQjRv8hdOwyxbNgF2Zup a0Uh60b6D3m/+OhdF+CmYVgxAOrn0GT6PWKplWIWJDXwIMjJUg4Lc7uiDGDT3miDTjekbeRGXSK OqVMEAQYqOn6dgOa7R/rDH4CupwOe/MpsvhSDxhdm3nVS7Dh+khZ04f3+dYexbWLueINI+XkxoW ZZxNQmELOPPZoyq9D1bB0KuXexzUKrwTEldCaMf7oPU5HBso8LmlOg6bKeGvM9k+8+JbSSezcRz o12zfUzfNWIAVBfWHEQdjuzfKdDlHEA5QaqBcs4s= X-Received: by 2002:a05:600c:548d:b0:43c:e467:d6ce with SMTP id 5b1f17b1804b1-441b64ed8a8mr6725715e9.4.1746049765785; Wed, 30 Apr 2025 14:49:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEt9JBUiNWwgOJYDw+GzMvBWT5lb5OsJ0qyzMpdTG+PNR54fN5u3esIfDPXV2lqLC6bUSVbLQ== X-Received: by 2002:a05:600c:548d:b0:43c:e467:d6ce with SMTP id 5b1f17b1804b1-441b64ed8a8mr6725595e9.4.1746049765463; Wed, 30 Apr 2025 14:49:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:a500:7f54:d66b:cf40:8ee9? (p200300cbc745a5007f54d66bcf408ee9.dip0.t-ipconnect.de. [2003:cb:c745:a500:7f54:d66b:cf40:8ee9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b3ae0c19sm29651625e9.24.2025.04.30.14.49.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 14:49:24 -0700 (PDT) Message-ID: <55736622-b0fa-4ec6-ba47-09fa5c34c6c5@redhat.com> Date: Wed, 30 Apr 2025 23:49:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm/gup: Remove page_folio() in memfd_pin_folios() To: "Vishal Moola (Oracle)" , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Vivek Kasireddy , Andrew Morton References: <20250430010059.892632-1-vishal.moola@gmail.com> <20250430010059.892632-3-vishal.moola@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250430010059.892632-3-vishal.moola@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CIYZ2JYw-keraPadn-OY8Lg0MXf3ARZLf9WfTzfjeY4_1746049766 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D620FA000C X-Stat-Signature: smm1gdda3wx57b9nsij9n13og7c3bgny X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746049768-289275 X-HE-Meta: U2FsdGVkX19Ph61TCZb6wDTeM2B1gi9TIuICtJd4iwCUZbKgbzjyvy/DJj4OdgDqUAxL2UeaRqdYigtQmdrEojfEhIcznaFWsb2Au/SxHQIUTTHUK2296vDhhG/LLFI9qvW98/4WhZY+s4+q0e3qeDYhenj6TxUkFlZpazMCNbiWr0GoqsnvGVl4t14dISnt9ZS49HI5toFaeJpyj8osicO0JzegbVZ7kb9AOz9zl0CzU7Px9TP8R+MJbvfvGjhZOl7oBI1PT8ZWKMWEWwUqkZ35d0wLlMo9MupOoltN/2NYZk0hLlxiK2Xp88SpLrStQHdNuVQatdwJA43mOU+VUlw5rrmwMzku72ymrMcGWz7Dj0BAQYwlwGiZ4X3rNGzS/XNSQcJneHoKAEuLkEwoRCsNl4pePDHM7EQIP05nHB1bjOU6kIlEH19d41DfGLcDrznI61dRlfLk6OT/2mLGo2/66Z6WrG1sdRts4pxEhqwamqeOHcymQXLLaWH0j29R6nHJfHoxd1D1nebQ1etfuDDNKPyoe4Ae/bTLGd8tO8aUHmdEr/+iqUL/LOjy7SIsnFmn4fRCJTq4fwrKX/3c2FPNhdPNj89AIFAZC19Y+xblTd4SHOaSipQ87ocJABCI0MkPxFWQMipk1F79dISAA0ZFMCuA4/DcOCRCzQmUkQ7ON1YHfKOzxmHmIPmeK58sglFazG+bFH5RZyEFX0pFlrcJalnJpGoAZ8bm0VLvGls4fX/vbNieJRxRYrNcYkNuheaDmKyqBEDP3X6BancajgF6e9jEl4qMvna8TwvRVpGQ+ZXCJWgnwRzQvi5B6N9zqOG7dQ0jHuM2hl7cgGNAhBS+SWK5nKxDpByH67jKlLlgLMUgk3Fkda/pm7Qcb1jl17d62Qst0AF2fWEtSowU7acvHkr5S7OOIObOMETsQFyWRaXTzYTIEJOyW4Ju7cvzh13VnWBqDHJKOXAiGp5 Up5YLOiI Yysr6JbxBS8A13FVdNdfKIPY+3jHIHFUJVxChcAxHOyjdIV8NfJIaSE4BMAdH/qfZ8NrgCOcuvPXXazub1cl9+MBmbCA3Oo6RbrhwfEmQxKEtbk0nxOwtXdk43sNQn4PjLSZG2x5DD2knWkTbvXotA5HtbphCXXWyksgdefzQZfViBAgW/ZVumsvdyb5yk/Ph0YoHlh0SoIaiAxxLBUTLF5uQkIFfcArAShwRWSM9zvFJg1e7OsZICIcHQG4D/TcuZMSjXBZgrPZ+DF3DnBSQmCPpb2NZ4hyHpiExd8oz4rkSgTgzqxZaerht0FwhV3ywQqWJ1LRz9uy4/zEBGoLrM96DgSdjpcbqQN8PMdORZ3n4n5scRbkBCqTIWdRwQI9v4KStU3OL+pxu25qtpsDxnhAEh1gqZh2mMnOMjmwYtx5ibQfZD61iWOaETo6VSxegbTrzYElbKEO7N12aLsbD+sTUn0Cyfsk7SNs8Tq8uOcxBnJfxPj+/CCKk8AwV+8aq1p9HDimSgbk23XOyyfodJZ+ftt2jloE45U+PXL5wqb50zn5GsiIDE+veZslYF9ldlKhN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.04.25 03:00, Vishal Moola (Oracle) wrote: > We can get the folio directly from the folio batch, so remove the > unnecessary page_folio() call. > > Signed-off-by: Vishal Moola (Oracle) > --- > mm/gup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 1fb8f3b9a493..795fd94f379d 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -3640,7 +3640,7 @@ long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, > } > > for (i = 0; i < nr_found; i++) { > - folio = page_folio(&fbatch.folios[i]->page); > + folio = fbatch.folios[i]; > > if (try_grab_folio(folio, 1, FOLL_PIN)) { > folio_batch_release(&fbatch); Acked-by: David Hildenbrand -- Cheers, David / dhildenb