From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EEE4C369AB for ; Thu, 24 Apr 2025 21:13:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E54226B00C3; Thu, 24 Apr 2025 17:13:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E04226B00C4; Thu, 24 Apr 2025 17:13:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7D0F6B00C6; Thu, 24 Apr 2025 17:13:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AB3116B00C3 for ; Thu, 24 Apr 2025 17:13:26 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 48883B4EAD for ; Thu, 24 Apr 2025 21:13:27 +0000 (UTC) X-FDA: 83370188454.03.1AB8291 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id BE581180012 for ; Thu, 24 Apr 2025 21:13:24 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S5vzUB/z"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745529204; a=rsa-sha256; cv=none; b=Z4YZSuUpDay0F8ilrQM2E2IaPONXSvNEJqwhA8ywQ1wpPuNN03YpYQ4D2kGm4qvYsuU+Lg +9EbXdjbB7raUxUQphGk9kqbyTsnWr5/OZXuDWvKTjDfjNw8X7QGSlb/YoMZ1zwRPSBxV5 M8jjEh/Km5YeSPlCvPkolZWAsVL4wdI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S5vzUB/z"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745529204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TOXhqaJnJp2+DQnqUGdABkzPsXEKdnuTwS+DW6VMcYU=; b=VPKWv56tjwzPUjp6miZiwZhnvsTTrVOOVv0lr1TbkweLtiAMHWApLvYlKxK61oUmolMM7p RYaVajrbCcGWxhprkVBi7ySv1BY0dbrYKCK+KKRAQPYwKRhxp6+oEIYfucTAiWOty3zi67 gJ5DKYAuQ+kwrEUr7xprRz6IJTRYOtQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745529204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TOXhqaJnJp2+DQnqUGdABkzPsXEKdnuTwS+DW6VMcYU=; b=S5vzUB/zz/jEB7xmZHRlgPT0VYffGISXVvvJ7WQR/pOQ8BtXzpyAFnDh9LUQFJW87NR4nw aAivpZfchBKOe1xzDSAWvxtBspat/uXN5tvs2Bd0TbHRrL289BZ8frm7q+MTkyPSuSWvyd 0u2G2vDLs9zMo0Wx4GmLug88qZ1EyhY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-LWccM_S_M-WaAv1jnVftWQ-1; Thu, 24 Apr 2025 17:13:21 -0400 X-MC-Unique: LWccM_S_M-WaAv1jnVftWQ-1 X-Mimecast-MFC-AGG-ID: LWccM_S_M-WaAv1jnVftWQ_1745529200 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43e9a3d2977so10867995e9.1 for ; Thu, 24 Apr 2025 14:13:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745529200; x=1746134000; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=TOXhqaJnJp2+DQnqUGdABkzPsXEKdnuTwS+DW6VMcYU=; b=DcevaMuwHkG6WoxaJK0ckBf5zDEzndAFZpsrmPBmb+bNwX2rPBbyTaQyU/5Vc04LgS 4rtQsPnxqoT9fmCSgqc0vDyMLz3J2ItgephY/EAcAEILPg+HQvOAZRsFHpviuiGg+E0R mcFuBeQPSLBqe5odO3K7QLUhFTuc0jZx8CrZ0IYjxgu3TmusqmVkKCCHS55nydjSPFp6 AHD7i6s10EIDFmlSFtbcTgFzzqvFdbVWD6wN8ZqZFnS7LYsUeZKlbjDAcTFwXOXZhJii KdmVsMmjouMGqz2C5f5U9Ka2Qc+8p/CSE+L2hqnJy6PwJ6J6g8dalJ2zOPJhqxjok6ZZ b/Hw== X-Forwarded-Encrypted: i=1; AJvYcCVxAu28SRNEsmG2VQOha11HpIzWHI2Pl4HWJMFs6zsI3ZyoCsSORGhFMOUtPaHSYUYs9BgklYNf9w==@kvack.org X-Gm-Message-State: AOJu0Yx1u2f8DRn6guKUquMt6rfiIRndeDQNulLXbKTaUagBNphD7PzY Cuse0m0Pc/ngLAhwYw4gvGLwpTH3GkXE35AhxJb9iJL+6MapkQcV4pKx8bgTnoIbmkdHZDmIwkW YJyn7IFc+WZkqpfXF8T8mtb4Z/hPGugcz793j8ID3aGJ8y57J X-Gm-Gg: ASbGncsu+BGMSJdWWhm4f+Qq7nI3yorEwvc14EBvYYfQApDpD127gYknW9z54MSbHic D6LE0Ah5VOqD5O1zGUe8SYinqfQnI/xPDK7kSykUX6SCjIqxC0us4epGV6VFFukN8HM4fLsuZ4w cg+hS9nGlmI1qYeV+1Qv4LLHiBPeMA3YlOi7PkGRGnZWpIZKBhYqSA3zNgE7z00x8iF1urF/kwa 0jJTOnQM7mtGuSnuGWzuDvHB15k+l/I+fVHLAmwv1tYM4bjEyR9OAav3mxjxGI6VkUaWTBOLiV3 xvhRXkFSmv9DVQ/yZCQ4+4KLs4rzcAdV00Hiz9179vYARX/t77iaqv3ndCoYxdTTptbor5Rb9Ls DygLAIlcyTzuGI/Mg5ckZm9QvkzOy4CLP4wW/ X-Received: by 2002:a05:600c:524c:b0:43c:fe15:41c9 with SMTP id 5b1f17b1804b1-440a310818dmr7773255e9.9.1745529199952; Thu, 24 Apr 2025 14:13:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXu7rx60czPGcmWU0+8461KGJT0DcvIUYSs2uaUCrKVXSoMHpwGwItsZlEECqxxyTiY6BuTg== X-Received: by 2002:a05:600c:524c:b0:43c:fe15:41c9 with SMTP id 5b1f17b1804b1-440a310818dmr7773115e9.9.1745529199621; Thu, 24 Apr 2025 14:13:19 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:ff00:f734:227:6936:cdab? (p200300cbc74eff00f73402276936cdab.dip0.t-ipconnect.de. [2003:cb:c74e:ff00:f734:227:6936:cdab]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a530f6e6sm1830695e9.17.2025.04.24.14.13.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 14:13:19 -0700 (PDT) Message-ID: <5569da56-4bd7-4ebf-88bf-a9edf7310f51@redhat.com> Date: Thu, 24 Apr 2025 23:13:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/7] mm: Implement for_each_valid_pfn() for CONFIG_FLATMEM To: David Woodhouse , Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li References: <20250423133821.789413-1-dwmw2@infradead.org> <20250423133821.789413-3-dwmw2@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250423133821.789413-3-dwmw2@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FnFSrwTWoQX__2eVkicNuazwVVSYwBKyrsXn2LG_6QI_1745529200 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BE581180012 X-Stat-Signature: huo7r7fsm55dzjsq37qqiyn81gi5i8jb X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745529204-939059 X-HE-Meta: U2FsdGVkX1+WYX9G67Da3G3AsIzvTsyKDYohP1Oul08HMh38nZvtDZoNABAXDL08JS4DOrrJQutJ/7otzT5Zao0vCYiH4LSvTWZmjA4YDxdRyX3BXffdC4cntPgt4KVZQy60mQNH50MNdb2PgAfcC4zvpbRGWMwdOeLbmpD+WaHQGaSr0A6CLDWLchCDhjtZh2egaTJNJQzhDSLhK9F6W7u6i5tC96njoCGdprbebyP2XkFMN44NLlF0WEGAIfd+vYteBaOKq3jVFwIB8wBKNC//E9qFcBSjTBbJ4QAtzNFYjFyy1A+lIk8VscRs9tqg8MgAaTCm0+SQ/FTaYfy+WZKpXh+0BAuBu2CNghSX7deZRkgK2TC+iO4SnRSYXpZSBPITkrKt/uEkOromhwTOKln/PB3QMNijUzsDSjXyK96c5h6iqlqrtheoT/X9DdDwUHc00cpr/u+64ertaoUKz0GDXQ4OEQ3aumUbkC8cG5xC89/8vcKpGCbTyArNOCxRVqNJM7sh8ImQjLIo2KnmbQX3H62OQep2+DRbngX6awxkE30T518lrHAB+an15c6y/OXW+o6zsevxlFjACoSvwo4H9wHDyumF07eCqKh01z/dCgtWhJXDnvfg6TW2rXu7ndagBjly31ES0A5PKB8V0/z++7CW0UD326ZjooitBokUiKZkOmVBlPPo0DXhHqXwynV7w9SO58vqnSfgPA4OkYvZXbE8YOsBaZp/aEzNj1Hsc3dh8HOwvSB56c68AoLsMbuh4mQtGEmr6HSJ3lvVq1MfpJZwv101axJvOYdTRi5nbcNkodsECdnc+ByIlWQSqsITbOE4XKkplvljQJdTPaI4gLCIp4oMlFjkTcjIdlloz8KlYjhQUO0qfo660t3WNK5Vh1CwAHQiLee3eKAF+ISyz6pUuc+RX+DEJxBGiPPtIceHQzcqKkz2gv1pHDZ+J+Ad8jYP9+JRIhsaI7J 6yrZ7n7V XXxxYPh8FYySsIpunygOviWIC6oUpn/j8fsHMOamOU0AYAE2l777SsUDEHhoT6zKysnBrTHCQQz/Vck8SELn0wDkSTqiEgLkkESo81EOT3zgM2A/tlJP6bkNjxsaPu1JJLzbpofuQuuuch1n4BpISahPCIUv1Q7t9UjRK3beoVbJQlh8cG8TifmlF5OD5/G5iR6v56/JaAtb0iHwuwAuStGgrKUPSKfDEioRtltZRE8SrSDQEjoluZkzDyaN6UilOWP/eLyjW9hz1BNzZ7Izn9B2Eo6OeF06w3CDzQ6tS9e6bFUZFrYWv5ehJovoqXpANg2Q9iAYhYLqXLvZ3++YdQm7ERWgw3EIiYEmLy9/rbvAUADqfwOTWwZRLt91G0ZsVI98fvbgZ/tTMSdWtaNcXgQ570EkFCk/K07jL6TVQ3mmqGL3PPd+mzNtuQq02AAo5eGId7fUUm8szproP36JO5WF4hPAR0/9po9unpMKalHNwj5A5eOf0RN4NkFzZofWSIk6M5tCrP6ZCTl8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.04.25 15:33, David Woodhouse wrote: > From: David Woodhouse > > In the FLATMEM case, the default pfn_valid() just checks that the PFN is > within the range [ ARCH_PFN_OFFSET .. ARCH_PFN_OFFSET + max_mapnr ). > > The for_each_valid_pfn() function can therefore be a simple for() loop > using those as min/max respectively. > > Signed-off-by: David Woodhouse > Reviewed-by: Mike Rapoport (Microsoft) > --- > include/asm-generic/memory_model.h | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/include/asm-generic/memory_model.h b/include/asm-generic/memory_model.h > index a3b5029aebbd..74d0077cc5fa 100644 > --- a/include/asm-generic/memory_model.h > +++ b/include/asm-generic/memory_model.h > @@ -30,7 +30,15 @@ static inline int pfn_valid(unsigned long pfn) > return pfn >= pfn_offset && (pfn - pfn_offset) < max_mapnr; > } > #define pfn_valid pfn_valid > -#endif > + > +#ifndef for_each_valid_pfn > +#define for_each_valid_pfn(pfn, start_pfn, end_pfn) \ > + for ((pfn) = max_t(unsigned long, (start_pfn), ARCH_PFN_OFFSET); \ > + (pfn) < min_t(unsigned long, (end_pfn), \ > + ARCH_PFN_OFFSET + max_mapnr); \ > + (pfn)++) > +#endif /* for_each_valid_pfn */ > +#endif /* valid_pfn */ "pfn_valid" > > #elif defined(CONFIG_SPARSEMEM_VMEMMAP) > Acked-by: David Hildenbrand -- Cheers, David / dhildenb