From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D228CE7B1B for ; Thu, 28 Sep 2023 17:09:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D3A06B024D; Thu, 28 Sep 2023 13:09:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 883D96B024E; Thu, 28 Sep 2023 13:09:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D7016B024F; Thu, 28 Sep 2023 13:09:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5C2606B024D for ; Thu, 28 Sep 2023 13:09:31 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1EF1FA03D2 for ; Thu, 28 Sep 2023 17:09:31 +0000 (UTC) X-FDA: 81286642542.29.DD8EBCF Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf25.hostedemail.com (Postfix) with ESMTP id ADA3EA0031 for ; Thu, 28 Sep 2023 17:09:28 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RTCWP38X; spf=pass (imf25.hostedemail.com: domain of jlayton@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695920969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WeJmzV4JvFZz14Bi7n5eT9UeLT4u7m3FR+NHBqKUVRI=; b=5SPqvzCQsQWrPqSPQAC8rf794Ll2nuVH5p9I8dW6FRmIhYKs5oQ89Fxkimzag/GEXu29Vs NOANETv+QPbA2++MyxQofH5vkxopZELSLMDl7CeM3JNQR7A5BlDYbKDbSn26JoYKj3dfA9 /UhEKAny+4d6RoTKBLC178J49+kVX54= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695920969; a=rsa-sha256; cv=none; b=QvTxx/rXSP2v8uBotfEJa8DQzriWjdBFFAwhClsHyqp8joFaGbKvqICaEmfCOUTMBKhR/q CqeV7kMes4Es+sNvtkP0iOInrgOCy+S554QAde9BJfrcQ7ICg7yaICESAShk761ROizdQX DLmrRwCT9dLGtPwv6WUGqI5dtWtQoXA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RTCWP38X; spf=pass (imf25.hostedemail.com: domain of jlayton@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BE5D1CE223E; Thu, 28 Sep 2023 17:09:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E060C433C8; Thu, 28 Sep 2023 17:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695920964; bh=zRV/ipMOOeHJFSr00KRb3DbkWuWIfMUsmholMiYqIFk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=RTCWP38X/3Qiq9e2eoLruFi6qLhhyLJQrL65PrzDXWj1P7d+rG2Zhi5BPUongplET wsh5RnIrkn2G9TM6HAAN0NYZV5F3YR+mvgQFtP+9DfawGUb0VUEGN4ZEWFes0Iqc9f GfOE5yeYJ7UoCrij4lXLrG+jRW8wnHjCzfKNNQxN4dSF4K07yMiaZJqV+VHP19Z5O0 9Eizi+4+cRTlhImq1fbs7Tb7Mmc79AROTIyl6OUF1ztlUjMfm5tqzXneCy0nyt31m3 teqvuavXAiJG2oyvZuxOiGcbkwGZED723LL7ZyPIvGZsh/B5aAGwbzTt8Xw0FUHUy0 P2xkFw6PYWKrw== Message-ID: <555fd53b72742fe8a8d2b67c80502f749631d773.camel@kernel.org> Subject: Re: [PATCH 86/87] fs: switch timespec64 fields in inode to discrete integers From: Jeff Layton To: Alexander Viro , Christian Brauner , Linus Torvalds , David Sterba , Amir Goldstein , Theodore Ts'o , Eric Biederman , Kees Cook , Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Greg Kroah-Hartman , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Mattia Dongili , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Brad Warrum , Ritu Agarwal , Hans de Goede , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Mark Gross , Jiri Slaby , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Joel Becker , Christoph Hellwig , Nicolas Pitre , "Rafael J. Wysocki" , Ard Biesheuvel , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Christoph Hellwig , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , Mike Kravetz , Muchun Song , Jan Kara , David Woodhouse , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Chuck Lever , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Mark Fasheh , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Iurii Zaikin , Tony Luck , "Guilherme G. Piccoli" , Anders Larsen , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Sergey Senozhatsky , Phillip Lougher , Steven Rostedt , Masami Hiramatsu , Evgeniy Dushistov , Chandan Babu R , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Hugh Dickins , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-rdma@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, gfs2@lists.linux.dev, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Date: Thu, 28 Sep 2023 13:09:08 -0400 In-Reply-To: <20230928110554.34758-2-jlayton@kernel.org> References: <20230928110554.34758-1-jlayton@kernel.org> <20230928110554.34758-2-jlayton@kernel.org> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspamd-Queue-Id: ADA3EA0031 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 4ppysyb67wrtjhy1fscsptwxx86kfcje X-HE-Tag: 1695920968-922735 X-HE-Meta: U2FsdGVkX18HJvO055oICpgHLQ7Q1C4R5XfCE5qb27D/orOtTu+fjPAbeOLlNYPygsVYUegJ5CcU+5F9PJg3ESRTKbF3qn38/xwN+DqxpCM+yhbNljq0QBcxbB2enFCIvzskjM2VOjDWtUkm9fKeDFRJZtWOoVurTMr9R/lldJGcFioquPuAzERUdDa8iTLPtPKlRtTixnNm9MLrXGygi+mymPBojTFUdDdO08EsExaZXfR2PdGdCpAAay5uVfaQ91MZelcRo6uMEsNeEd6knLOqii6MntLEIFr8CeM7Y5adAYhdkhc7dnVqPeVj/YTwcEINwn3SUv2Ug7IeAR9ZZCBWE3r2bqHEQQUCGz5co8FF3KtZPHw6RCs91QxmLeI2gf7Ca8FBkbOuWZO0ZIPOaGq2i040x7msWod9ncwVdLPUJQhocCwxv8quqMy9SNtAnS3ycj/JK4e30AsRkKNHwQUh5A6o0SL67SfHSuF/3JJRwqp1t5lI8b4J+69jDunbwaLLZ3UsfWXJ1vvbs64CyyhuyJoGKFKE7VtQUjQr+PZgB8U0WWmakzZpmrv7Dn7q3VQNbo7bhe+6kWhMyaVsR8VA9ViHPwMhRIJ4ih2IUCYmyCLNbK2cDL2JqGnZgARsTNIc9Qu7GCQ5/i3BD/ioI3xmfV5c0cML1uhm2BapgWKx5nUqlrjlv8LdUgbZD078fD4k4ew2iG+bzcL1z7GgdHUvEstMNMCUfaoxy4wMXBlBJ1RNmE7hipnk/FYW00aOj9d9mD5t+Zk4SFiG20L6HOc1dO3QGEPvv19XZF6WnBqX237cLhmDeQMFTcjfaxiMZJ6MYmQZR1azdcbJd/SCKOur9IUVW+c2LmiiYkw5w8q3ElFchVtqel0WIDT7x3+Sg/Ey8fQ7X4Nsuo5OQSd8IoetomV80ZiC4QbqAgVtUt0leOFlMAFSE438nxvwshgkHnAxkV9Tm5Gp8rmacNG S9cEKVG0 lMoWBn9MdDAi0A3v4reKzPAPq7zQ38tm9rvY7k82gfYAg/L9bJqZKKalugDPomQxbC3NexvhY175OVkfGD34WJP5o7HMy0ucLsqT6mMSJgvFZT7hmaGWUWwVYp8R/unbZWSc7XV5NlxE4Mv/hdqKsoA8eNQS6H2+j3/zEqI1k3W6LlUaaZ9SnW6Ag9yfdQmIqnHaNPqZeUr2RpGqYtfJTW2IlSxX0dRhm7P0cudZ96sW0tJkpMmet1pb664Fwh2aPH1l7CdmrX2B12qd+wNzSNrcC3OjcpJFGKMv5fGOqf8vdQeqqkxgfSAMp6MbwTXIvUPLnWGlXUTDhwXqWKQMNNlTJNffyN3QemX949OKsDon4EFCtZ0ZdwARl+r5cDSR2M9ZTzl/dM4AP9tvk8aGkaJcyT0JQb9itrSZxa7htTWjmI+040RfsKYtA9VQxgMKBEe5W54DqlxKSoyqVDpWcVUR0R+jt9bML0t/J2olj+4dODD+QaZTbAJ/XtrNgvn/tc7DGR+iKilbYKc7+jh3qGYw0JQn5D+onEDKRjZ+AyDfZKqYrLaEZyGLjrTUZ9tBJNYhv7R+qR7+/7Yg8tMrL1i0BToLGADHTtuGhEib0aATwWzSHkzI2rutqgLmRtEBqpDYppvBfX7h+r3Cw0xP/5/gvuMbloKy7xsSmzHasm9SiST1SU3tudA6E1YTNqnfp0pVgZ5dirZjPBDCHSNoc8uhtp+eBIYzOnM6IniaMQ4gs3nSCmt0YIyX3swfFeP4uaCbpISGhV5xyAqgZ6X8evWSoGo/NHsymjbhQ1c2cocmq4CgwwUlHvYpoxVKS4QfK656v9wPnS7l3N59HqRMliG/pTB8jEXmBX3P4sq+SRkW2VtdPHC3tJozzK4f0VXngcH5DhMhGDeQ1S9MVdKhc7B/Vy7M8evGFxf0LdYTkYfW7uS2FqOG7xp98qDuTKnFxm3riZvCq1aIkz3BcctD+JvMSt5zE wf2OEVi3 pf04RX8jjyJyu9aSny5GUSv0J9vqHgnr2d4xFOLWy9yfCsBNPNk4fMCXBXgA9eSQqo0PLzR8p6XJaVpcJZL9TLQIvHe35YOBdAcXfkz7uB3as/M7m8EDdegxzxCr0avEtG1gK1tm5cbQut5HfJQi7Q0Q+LCMa0lyEKwguUzJ1D/bkoyDqRI3FH/VBryP2tEuRsJNGTeVvtGqB2HNNjsP0bm7tCdWmLDtM/aDIz8E0/tev73+womW7ySR1pzqBQaxhYTTBIUs7nUBW1hmRS1rgvycwErtnBNE/oeV2FQOEDwUwwUPzXogkaJ8DvlmE1Lqnr2NXoPiA6865azirxZ2s8nBoGdI55okjLeMbqGldP5me6VSCsHSvOXhCdA2kdXiZzmdwsBfqGAB31eYB1U7N0ie042OuXSjShf7XhLJqsNwhU4VOUcKi+rVDA94Ozyfnya6JLj20tjG1WEUWCJA5ZsO6iuXw5OoXqH1pAbuXD7A3kZExlcH79ZQVj2Mjtwy6zEjueMu5O/q0BQFrjQhvNmf5vOOX2K1M5S9HBvChXknmGSMUnyQxJWJ9tXedyd/P+LyyVSeO5Qz1g7aP8VlhEOmAob8DALjQjV1PdINWEEGjm10Ng2aGGY2GDNsYl4XOPkBvvNzu82Iqe2ulOlYhcSZXFoDQ/9SB95Exp2cjm+7tgZjC1agZb+6UucB0g2zUpggXAuILtQaZRdO52O9yuNuwkPdhlioUiSMEDOcA9ZNbQYNNNCTfLE8CjzJnx0s+KljDHd/jmgMcMMfxNRbuyH1xWZ3s1a4+KpE+/EsV/2Amc0bsTqGEtwpLe+DesV2XrCLhk6FEOr7wtQSdWp8re+98ifdbKNBhsmxra3a9VEUvpyZgHtWBPpmrdZunrPZ0eFVSXiALU0IBLL77kYmKyXQs0zUGHiJhpmSapfsScYcrHYJ+jZSMfIQYIMZLsZTd9Ad1aDvjVhifdC11/pU3wW6Oo2jF jRoPcTtJ F6Bhf5J8B79oyRt2SceY1OxnjStyQtyUfkk9uuz3vDiK9xYP9WlZjAVX+6RybPEFh6x7zj8HTlxJW0JMJXG5pJeOA1wBLSPwMHwcH3W9D8waZ0eTvbFxgPpSDw9XrzZ/6ca27oI00AM2a1LqDCH80gKRHMNSBirzVISz1tF10tLk7dI+WXdJAM/zhsTT9Che04w2WLd3IVQ/3YdR/vqiLwIZWcfoUsF3MadZt6uFMw7vUDYHyI1zC6XpC3TIIpYsAscZznP3Mwtex7ouHAzhcqdaz8UN/qM6GMNxPzm+8PRaKvYdAj4lZD3Lk3/CXAnHZhDZz6WPoPVjeYN+w6/v7Ea8wgO6haf9S2eIcCG3q9TNOm510vBrlXkuitN6H9Pi+Mtrl3FdatDBf4xtsSWkjwjHbfXrCJRAH6824N5RIBNEBjlqrA7DLmCoO8RuZar00/3lz4etMXMhyh78Wp0Hkce2T8X8JwMf0he5hhoy32YDm9rF+pZG+mVNqF8eNUFgWliz8c5sMSdqr38S+RBdsn18ix1Vpu9XcQFdwfa3zVXhrYZ+Rmu0Sfifcre9Tzgggo8ckFKhMnbdqodvRlRVE/3EvS2/Jbn+EONqqb92EX+QszlSg3r7qtR/fUMT+/DJAYFW/1cBylIpD7ehyp0FwbN+L18iNNaC74gIfksSVChRJL64Zi8WnmE2RjwPZwgYeVeCeBfn2e/rWxGCguPqwpl++99YPrM5eVWCefhNAPBIn9nz+zbIzyThVbuA9O4AMgdNeUoLRmnrJBsXEQ4XoCYw0DQc1SF3QLzqp8shG7+qOxgYJppdYymRJoctUnI3oMlEeGnfACq2X20J1esa3Jd9sDm+WQGPu7qymSY77jQFgsGZ9nJzvfLGxs4j7OBojGLUXHgpZZaCLSZQmy7NJhHUxtj/+DbuGGAOgcP1AxlaGmWL4sggeoreQ9tbZCV20tUDF/MlltI1UA2C08AZzJLyCLdMl qtAFz7rL o19G+uW7SjzXLB7nLikb/P1Q/BEShNkYHmrAfEle5PFN9r1FXBbstttIjAbocNuO4r3n60TirL12EJF5+9W6UEVvHwK1xlxmw0MO5GK+EvKzHBFsruZr57Izc6ntiOf7tB9JeHd0uC3euZ+5We5LWXdkOHTR1Q0TBFLza56vFJtVoIubofYrDF5oKPJlfOH2ZSMJOnp432tK4O5K75RWkV9V3pam9eWGLnu1jC9132hBt+WtpsMz//TS3rdFk9u0MnQSIhis2xWBb2Xe2BveEVrUgjsu2MzdmD/EJugcbzHf7sLxgd0sVG5rhRzzzTQn3A8/2bh2J2wQ7IbXEYxGcGoLNTW3wP7eyanj+Bj/tpqM5ZMOpRzDwy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2023-09-28 at 07:05 -0400, Jeff Layton wrote: > This shaves 8 bytes off struct inode, according to pahole. >=20 > Signed-off-by: Jeff Layton > --- > include/linux/fs.h | 32 +++++++++++++++++++++++--------- > 1 file changed, 23 insertions(+), 9 deletions(-) >=20 > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 831657011036..de902ff2938b 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -671,9 +671,12 @@ struct inode { > }; > dev_t i_rdev; > loff_t i_size; > - struct timespec64 __i_atime; /* use inode_*_atime accessors */ > - struct timespec64 __i_mtime; /* use inode_*_mtime accessors */ > - struct timespec64 __i_ctime; /* use inode_*_ctime accessors */ > + time64_t i_atime_sec; > + time64_t i_mtime_sec; > + time64_t i_ctime_sec; > + u32 i_atime_nsec; > + u32 i_mtime_nsec; > + u32 i_ctime_nsec; > spinlock_t i_lock; /* i_blocks, i_bytes, maybe i_size */ > unsigned short i_bytes; > u8 i_blkbits; > @@ -1519,7 +1522,9 @@ struct timespec64 inode_set_ctime_current(struct in= ode *inode); > */ > static inline struct timespec64 inode_get_ctime(const struct inode *inod= e) > { > - return inode->__i_ctime; > + struct timespec64 ts =3D { .tv_sec =3D inode->i_ctime_sec, > + .tv_nsec =3D inode->i_ctime_nsec }; > + return ts; > } >=20 > > =20 > /** > @@ -1532,7 +1537,8 @@ static inline struct timespec64 inode_get_ctime(con= st struct inode *inode) > static inline struct timespec64 inode_set_ctime_to_ts(struct inode *inod= e, > struct timespec64 ts) > { > - inode->__i_ctime =3D ts; > + inode->i_ctime_sec =3D ts.tv_sec; > + inode->i_ctime_nsec =3D ts.tv_sec; Bug above and in the other inode_set_?time_to_ts() functions. This isn't setting the nsec field correctly. > return ts; > } >=20 >=20 > =20 > @@ -1555,13 +1561,17 @@ static inline struct timespec64 inode_set_ctime(s= truct inode *inode, > =20 > static inline struct timespec64 inode_get_atime(const struct inode *inod= e) > { > - return inode->__i_atime; > + struct timespec64 ts =3D { .tv_sec =3D inode->i_atime_sec, > + .tv_nsec =3D inode->i_atime_nsec }; > + > + return ts; > } > =20 > static inline struct timespec64 inode_set_atime_to_ts(struct inode *inod= e, > struct timespec64 ts) > { > - inode->__i_atime =3D ts; > + inode->i_atime_sec =3D ts.tv_sec; > + inode->i_atime_nsec =3D ts.tv_sec; > return ts; > } > =20 > @@ -1575,13 +1585,17 @@ static inline struct timespec64 inode_set_atime(s= truct inode *inode, > =20 > static inline struct timespec64 inode_get_mtime(const struct inode *inod= e) > { > - return inode->__i_mtime; > + struct timespec64 ts =3D { .tv_sec =3D inode->i_mtime_sec, > + .tv_nsec =3D inode->i_mtime_nsec }; > + > + return ts; > } > =20 > static inline struct timespec64 inode_set_mtime_to_ts(struct inode *inod= e, > struct timespec64 ts) > { > - inode->__i_mtime =3D ts; > + inode->i_atime_sec =3D ts.tv_sec; > + inode->i_atime_nsec =3D ts.tv_sec; Doh! s/atime/mtime/ in the above lines. > return ts; > } > =20 Both bugs are fixed in my tree. --=20 Jeff Layton