From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A45C432C0 for ; Wed, 27 Nov 2019 22:56:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D59C3206E0 for ; Wed, 27 Nov 2019 22:56:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="PAARS5Pc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D59C3206E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 89E346B04F1; Wed, 27 Nov 2019 17:56:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84F266B04F2; Wed, 27 Nov 2019 17:56:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78C4A6B04F3; Wed, 27 Nov 2019 17:56:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 610916B04F1 for ; Wed, 27 Nov 2019 17:56:43 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 0E170181AEF10 for ; Wed, 27 Nov 2019 22:56:43 +0000 (UTC) X-FDA: 76203568686.13.jump32_3a9864b52ef20 X-HE-Tag: jump32_3a9864b52ef20 X-Filterd-Recvd-Size: 4143 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Nov 2019 22:56:42 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id q28so2119852qkn.10 for ; Wed, 27 Nov 2019 14:56:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=XYhfRwG5Ji2pvMuCuinGa1OmrcViu32wplTTKEJhTfk=; b=PAARS5PcPoQL3XS9GQzyp2fDTPw3+pUXtyo52tuExZFSfaIimO5e4M+TgBervYDP7U yhUVGPxTjccP9BCtGXAcM0XetuU1oUTzPeqhPmHoE1dMxcvPoLDnJX90nNtLptJD/uP1 ju63egzcZc+qyp0v9JxEe0A4YxDXiDmyrT1WrJ7y9wECAYYxYgEATqabazbToNKHAofz hG4stzgnWmZYPw1NxrIoYc6eMbWT0WlB7un2ZhhwIi01p8TNCRLc82GUpEhYT1DNLY2D yeineiUFS+oLwXUsNXWGlIGyeTpyeIaE4Fct4BynsdREr5QLuW9ucMeYwnIPPYGUydxl zBFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=XYhfRwG5Ji2pvMuCuinGa1OmrcViu32wplTTKEJhTfk=; b=AobhefuC2hcdErfBHWn4lMh1/LxqaOvtYiingPKHe6hJQYLqcDhURLfOoRNqy+yJma j0Lm0nOqTLu7h1vQOOaFinmdumWO5i9Kkt4k8XlmOk3m54cbyo+9wrRTttQJ7howwTZ2 y2iIkyATbioAhi1AqqiPzN9xy+bJicfqIDkOHrlSk1YahjI7RJuvICyH4ChL2GAQgD8Q w2xiKnY0JQSPcWj7JXnpfk8RAdFpcxoDEoti0SrHHlq1AMpc6WhT9zhNcPkkLX1ho7Ha ZwWIZy0yqtd1D032RYDjx169LMa+0OXMcoq5QFwtpmAMTNCytLYaQArUR3yFP/1qleAD ZU5g== X-Gm-Message-State: APjAAAW9/X0N5zBNVBGAGRBnQ35Kf9FmyTO13R1k8HVm2FAYYl5lf2MB cHejBYe1OPzS20dsw3QOH7RPJfkGDXwqSw== X-Google-Smtp-Source: APXvYqzmKp4CtfXv6/HagS2sTgegvpTVS6zdaqSQywUUhkFMbj8c01JkSqjXG7xlf5mELrHR22q0Xg== X-Received: by 2002:a37:b183:: with SMTP id a125mr6844021qkf.19.1574895401631; Wed, 27 Nov 2019 14:56:41 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id k26sm8134476qtm.10.2019.11.27.14.56.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2019 14:56:41 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn Date: Wed, 27 Nov 2019 17:56:40 -0500 Message-Id: <555512D0-986D-437D-AE01-2087CB668F68@lca.pw> References: Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Michal Hocko , Oscar Salvador In-Reply-To: To: David Hildenbrand X-Mailer: iPhone Mail (17A878) X-Bogosity: Ham, tests=bogofilter, spamicity=0.018738, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Nov 27, 2019, at 3:49 PM, David Hildenbrand wrote: >=20 > (I am a friend of cleaning up and refactoring code to make it easier to > understand, maintain and extend. I was assuming your mentality is to > rather keeping code changes minimal if there is a chance to break things > - I'm sorry if that assumption was wrong.) Yes, I tested linux-next everyday and saw enough of those cleanup efforts en= ds up introducing regressions. It is almost every day or two I had to invest= igate at least one regression and pick the suckers out even though my testin= g is only focus on MM and friends. However, I do agree if there are worthy c= leanup and refactoring but those tiny ones make me uncomfortable. See, I am j= ust trying to save a real vacation for a few weeks in the future, but given t= he current situation, I=E2=80=99ll need to give up on this project [1] at al= l because I just have no courage to debug all the regressions there once bac= k. [1] https://github.com/cailca/linux-mm=