From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB45C47420 for ; Tue, 29 Sep 2020 20:11:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2412420774 for ; Tue, 29 Sep 2020 20:11:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Wl4BhHVX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2412420774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 505386B005C; Tue, 29 Sep 2020 16:11:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48E826B005D; Tue, 29 Sep 2020 16:11:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 356C06B0062; Tue, 29 Sep 2020 16:11:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 1B91E6B005C for ; Tue, 29 Sep 2020 16:11:38 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CD1EB180AD802 for ; Tue, 29 Sep 2020 20:11:37 +0000 (UTC) X-FDA: 77317194234.04.toe07_3b02ace2718d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 971898003421 for ; Tue, 29 Sep 2020 20:11:37 +0000 (UTC) X-HE-Tag: toe07_3b02ace2718d X-Filterd-Recvd-Size: 3742 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Tue, 29 Sep 2020 20:11:35 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 29 Sep 2020 13:10:44 -0700 Received: from [10.2.53.30] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 29 Sep 2020 20:11:34 +0000 Subject: Re: [PATCH 2/8] selftests/vm: use a common gup_test.h To: Shuah Khan , Jason Gunthorpe CC: Andrew Morton , Jonathan Corbet , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ralph Campbell , Shuah Khan , LKML , , , , References: <20200928062159.923212-1-jhubbard@nvidia.com> <20200928062159.923212-3-jhubbard@nvidia.com> <20200928125739.GP9916@ziepe.ca> <6481e78f-c70d-133a-ff4a-325b5cd8fd5d@nvidia.com> <20200929163507.GV9916@ziepe.ca> <20200929175524.GX9916@ziepe.ca> <715c49ec-d2a8-45cb-8ace-c6b1b4b8f978@nvidia.com> <20200929190816.GY9916@ziepe.ca> <3022912c-f11b-f564-3a8a-f516ca259a37@nvidia.com> <20200929195356.GZ9916@ziepe.ca> <64bb5ba7-77f7-2f09-44f0-29ee9329b183@linuxfoundation.org> From: John Hubbard Message-ID: <554699c6-cc01-4c3c-3ed5-26d22ac3bac0@nvidia.com> Date: Tue, 29 Sep 2020 13:11:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <64bb5ba7-77f7-2f09-44f0-29ee9329b183@linuxfoundation.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601410244; bh=h1cShwScpls1cxoBr43dDhqnFtUnjOc7/H7Y8HWxAgM=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=Wl4BhHVXCxnN2MbBzLUijMKatEV4a+hk1x1KprGMe7sx2IRfHuUPwV1G8DK3/Uym7 s1WqObC4zZUpHV8MazVJcK+ij9OSOyFSV41pcViWpH2droSzSXzO2B7YDNLd7btX+v haigRF8z6Y+X6YrXltTZ9sMTl2J2ov5VYW9wkM18+El91/tvCj5Q9/Yyibh8hkZjR/ CCjieAzw/GA8k2JNpdvnBl+kTEbTLiCQ+v6NFpsRYWEhhojsy5RtmogBk/1lRFSKSG W6hQ8eoCKGbLEkWXVX9fTyH4pp+F5n6hM7dxRfUwgc7DOtOQ+6DX/0KZ6eB51vLh2d njiPyDcmUpJhw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/29/20 1:00 PM, Shuah Khan wrote: > On 9/29/20 1:53 PM, Jason Gunthorpe wrote: >> I only remarked because I didn't know it wasn't using kbuild. I >> thought it would have used the existing HOSTCC stuff, not sure why it >> is special. >> >> The only investment that seems worthwhile would be to switch it to use >> the normal kbuild stuff?? >> > > I explored switching to kbuild at the kernel summit last year during > my kselftest where are we talk. > > There was push back from several developers. We can definitely explore > it as long as we can still support being able to build and run > individual subsystem tests and doesn't break workflow for developers. > Do you have a link or two for that? Especially about the pushback, and conclusions reached, if any. thanks, -- John Hubbard NVIDIA