linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@kernel.org>
To: Shawn Chang <citypw@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: spender@grsecurity.net, keescook@chromium.org
Subject: Re: [PATCH] Hardening memory maunipulation.
Date: Wed, 29 Apr 2015 15:09:37 -0700	[thread overview]
Message-ID: <554156A1.3010903@kernel.org> (raw)
In-Reply-To: <1430321975-13626-1-git-send-email-citypw@gmail.com>

On 04/29/2015 08:39 AM, Shawn Chang wrote:
> From: Shawn C <citypw@gmail.com>
>
> Hi kernel maintainers,
>
> It won't allow the address above the TASK_SIZE being mmap'ed( or mprotect'ed).
> This patch is from PaX/Grsecurity.
>
> Thanks for your review time!

Does this actually reduce the attack surface of anything?

These functions all search for vmas.  If there's a vma outside of the 
user range, we have a problem.

Also, that use of TASK_SIZE is IMO ridiculous.  Shouldn't be TASK_SIZE_MAX?

--Andy, who is annoyed every time another pointless TIF_IA32 reference, 
even hidden in a macro, makes it into the kernel

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2015-04-29 22:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 15:39 Shawn Chang
2015-04-29 22:09 ` Andy Lutomirski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554156A1.3010903@kernel.org \
    --to=luto@kernel.org \
    --cc=citypw@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=spender@grsecurity.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox