From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC931C433F5 for ; Fri, 18 Mar 2022 09:42:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43EB68D0003; Fri, 18 Mar 2022 05:42:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EF1A8D0001; Fri, 18 Mar 2022 05:42:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B75C8D0003; Fri, 18 Mar 2022 05:42:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 1AC1A8D0001 for ; Fri, 18 Mar 2022 05:42:14 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DE3CA24E22 for ; Fri, 18 Mar 2022 09:42:13 +0000 (UTC) X-FDA: 79257016146.03.A467897 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by imf31.hostedemail.com (Postfix) with ESMTP id 1FA162001A for ; Fri, 18 Mar 2022 09:42:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1647596533; x=1679132533; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=IZlToiA7xQT46xbfd6wc6WVzBsKusl5FN+i5YenXrPI=; b=HRO9MM/yCj68mE8RzYc1br7W9VqmQ2H/9KIh4osJ1BYmd1Bl7HOWNAMT NWERpTjk1b0kny+4/p61HNnwqzAUCLH7n6jbncquZQJVuBnXvEf1w5kFw e/ByiqK+P9/QP/MdV4Qydm9PVzRovxxrYVzDIvkqRc64YPLwDCT9MzCJN uP6n8GlhYhbx3Nb2UzE5JomaiQm10witbzuZC3jF6782tGory+evkAqBd 1B3FC5ZdlA6QzP6Z/ywFgrLVp8hJwuyemXVXtuEByZF9XkreFaJUKN1uZ slLsuAGxZFpUsSu/hilSXwIJd69eIo9obE7AI+t8rcZlXPMyo/60Fji7C w==; X-IronPort-AV: E=Sophos;i="5.90,191,1643698800"; d="scan'208";a="166278804" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 18 Mar 2022 02:42:11 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 18 Mar 2022 02:42:11 -0700 Received: from [10.12.72.220] (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Fri, 18 Mar 2022 02:42:10 -0700 Message-ID: <5534acbb-41cf-c70b-6d06-9312f4d60680@microchip.com> Date: Fri, 18 Mar 2022 10:42:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [linux-next:master 7918/13392] drivers/soc/microchip/mpfs-sys-controller.c:73:1-6: WARNING: invalid free of devm_ allocated data Content-Language: en-US To: conor dooley , CC: , , References: <202203180259.lgIylRZV-lkp@intel.com> <20220317211734.1340281-1-mail@conchuod.ie> From: Nicolas Ferre Organization: microchip In-Reply-To: <20220317211734.1340281-1-mail@conchuod.ie> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1FA162001A X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=microchip.com header.s=mchp header.b="HRO9MM/y"; dmarc=pass (policy=quarantine) header.from=microchip.com; spf=pass (imf31.hostedemail.com: domain of Nicolas.Ferre@microchip.com designates 68.232.153.233 as permitted sender) smtp.mailfrom=Nicolas.Ferre@microchip.com X-Stat-Signature: 8f7jwwjahb69bd6fuwuwe31tjucfxg1f X-Rspamd-Server: rspam04 X-HE-Tag: 1647596532-267589 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Conor, Arnd, On 17/03/2022 at 22:17, conor dooley wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> head: 97add482e9033a9386baa8824fbea34d0cbfe663 >> commit: d0054a470c33902f5ae88835ed8a8ecc3cf8faa4 [7918/13392] soc: add microchip polarfire soc system controller >> config: ia64-randconfig-c004-20220317 (https://download.01.org/0day-ci/archive/20220318/202203180259.lgIylRZV-lkp@intel.com/config) >> compiler: ia64-linux-gcc (GCC) 11.2.0 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> >> cocci warnings: (new ones prefixed by >>) >>>> drivers/soc/microchip/mpfs-sys-controller.c:73:1-6: WARNING: invalid free of devm_ allocated data > > Silly mistake, should've changed this when the alloc was converted to > devm_. > > @Nicolas, rest of this week is public holiday, but I'll try to > send a fix before the weekend. Should it go to you or to Arnd? I cannot queue in my branches because otherwise it will conflict with the patch already taken by Arnd as an individual patch [1]: "soc: microchip: make mpfs_sys_controller_put static" What I propose is that we deal with this during the stabilization phase as a "fix" after 5.18-rc1 is released (in 2 weeks). Is there a drawback to this approach in the sense that it can trigger other test robots? This way, we won't have to disturb Arnd as I believe that his branches are all ready to be sent to Linus after this week-end. Additional benefit, you don't have to change your plans and enjoy St Patrick week-end ;-). Best regards, Nicolas [1]: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/commit/?h=for-next&id=17588e867e694e8a03234628145f7c4d738288e2 >> vim +73 drivers/soc/microchip/mpfs-sys-controller.c >> >> 66 >> 67 static void mpfs_sys_controller_delete(struct kref *kref) >> 68 { >> 69 struct mpfs_sys_controller *sys_controller = container_of(kref, struct mpfs_sys_controller, >> 70 consumers); >> 71 >> 72 mbox_free_channel(sys_controller->chan); >> > 73 kfree(sys_controller); >> 74 } >> 75 >> >> --- >> 0-DAY CI Kernel Test Service >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Nicolas Ferre