From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F61C8302D for ; Mon, 30 Jun 2025 11:17:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 068376B009D; Mon, 30 Jun 2025 07:17:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0177B6B00AB; Mon, 30 Jun 2025 07:17:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFAC06B00AC; Mon, 30 Jun 2025 07:17:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CA8EE6B009D for ; Mon, 30 Jun 2025 07:17:00 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8A358123452 for ; Mon, 30 Jun 2025 11:17:00 +0000 (UTC) X-FDA: 83611815000.13.481EC9D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 34428140004 for ; Mon, 30 Jun 2025 11:16:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q0B9sqln; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751282218; a=rsa-sha256; cv=none; b=MsOEyUS5BgryV9dVR2u9SPkPCqJKJJh/kufW/+lNE2vflhHWZJNyfD4FzFQmajHg98zDZB vjKT/SIsN0vRKjj1snTLsEs5w1VrsoWP4uWxzWBYe9C/f5+bKe3HP2M5gcXwbEP//Zb2GC JQfNo23+4mGZhYAhs1rVDTDSUE+d6JA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q0B9sqln; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751282218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uSNbgfLpVD/Nd2AR6Zy5V8tzVyhxiZQgQB24rZmMwYg=; b=jzvJfbEuEqQZjXX7zj24CTVle+tWSwJO4Aox7d0gYpQjUmWT60ba2YB39EmM0mUCfRx0iN aIZR6i4qfVRfypB0sSs9iwQe/UYFEnJahJ4niBfmVMb58f3Gk3UxJnqJK0ANZX7ulkKvNl y6lGZNFtx5IliolldFYAbOhWqiVa0g0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751282217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uSNbgfLpVD/Nd2AR6Zy5V8tzVyhxiZQgQB24rZmMwYg=; b=Q0B9sqln56rcEvTtY0+cd/03F3lPM8kz58WD3fSwgkrtdLTNaOi4N8DYffFjAMXo+mZkBu LvpFESkIg0MvF2NLwcH6BdDq/Kz4UEFvFUHWGHDy5WGuf7MPz0d7EOGfguuZ7p4g+C4X4D g81bOuaReb7n/EHyJ/k8XJiX5XsNu1Y= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-108-euuH_sAiPQGlQ32ODT3QVg-1; Mon, 30 Jun 2025 07:16:56 -0400 X-MC-Unique: euuH_sAiPQGlQ32ODT3QVg-1 X-Mimecast-MFC-AGG-ID: euuH_sAiPQGlQ32ODT3QVg_1751282215 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4532ff43376so17726835e9.3 for ; Mon, 30 Jun 2025 04:16:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751282215; x=1751887015; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uSNbgfLpVD/Nd2AR6Zy5V8tzVyhxiZQgQB24rZmMwYg=; b=hbDRTq7EYzzjP08YtdGhcJSBJl5iITvtqESWbEGiZUuY0GfsNd1yalPUz+8Fu2HHQq qzTvR+acccqgAP0PmjELHWopWbW+dZwWApEJrR09YDv+u+Zaf8bpFDPyp7Zwy643Laye elZz2daLfIm1dYO2gZcQADiduIUNOuMqFComS2exK1Uco6Qk0cDMBdWeNwrrP0duDMZq eBQPgdRegqPp+aU7jlrDWL1fDmSGnuOLF5TUF5eHYu7Mb7yfSY7oHLO+lx6N3gEACKvC /filuQBWUAG+aQvnJeqFWgl8Wm7499bL+ebH/G7medmAdk/5lxhCRcjXi3VaGQOGrz5f f2cA== X-Forwarded-Encrypted: i=1; AJvYcCVfDRhNVPdZJ6WiccTlM7nPpE7mKYUsKb9pSuAOipEQ/Koi4UccihGOiAMv2+9Wa4oVhxFH7ShKqQ==@kvack.org X-Gm-Message-State: AOJu0YxJdoCUcfLj4yZ28BWq6d1hiqO3ok0mdRTTJhyJ4QqRH7Oh1rPS rX33dfshctpCFFhRFXDi0NiWDz7CplWkg+YHOgsq7G4LVjzMEQb2Me8zwtgfQduhLrZfDbi8BgJ +0OV0uaA0dcA0m4pM6WtoQEPsPTJe1VXBNLSU8YRmWJiAJ1qWygt6 X-Gm-Gg: ASbGncuyvrGdjWlItT2RIo7Uo5fr28RETqjoFjIR1zcJ6R80KfZTTnN6a6LLnaFHaIT jhUo7jqOxvfbc4Dl3xpS2ZLDuWq2L+23S+r1ggia7PuB+5QhQTdNRKFpjhJZvqQ2pGCCp9t2+LT cetGOF566W+bXETxzFLBf0J6/8fsdiFfoB7N73NBhZmD78zg4NMkGx+lD7f5oFS5h0bg65jGdY4 3m8rWBVRO//p8Sd6WNoPcZE77UbcR+u0rcJclPB37UstRCGzQwYZgTF10XQN4rnaOoAOO/znrLd GBMVbhL5TdQhIzyhnbhI6xG4/dOr49B6KEOdDzXwY2oxhl5el5edoOzuwdKUr+Jrfd5gPGDr+/e 1+x5wnmuHQfvMhJMYmcwQIvirkYhIDHUQcRpy6f8kn1TTs/93Ug== X-Received: by 2002:a05:600c:3483:b0:441:b19c:96fe with SMTP id 5b1f17b1804b1-4538ee5794cmr153257255e9.10.1751282214941; Mon, 30 Jun 2025 04:16:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHPcMAuDi8vVaNDz66d39uLwRF2AxzD8s2DdPf9KbDJ9DS6L5jnCAepis8YVqLBcTvkPU1hIQ== X-Received: by 2002:a05:600c:3483:b0:441:b19c:96fe with SMTP id 5b1f17b1804b1-4538ee5794cmr153256755e9.10.1751282214441; Mon, 30 Jun 2025 04:16:54 -0700 (PDT) Received: from ?IPV6:2003:d8:2f40:b300:53f7:d260:aff4:7256? (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e52a35sm10273501f8f.57.2025.06.30.04.16.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 04:16:53 -0700 (PDT) Message-ID: <5513d9ba-80bf-49a1-9a50-e1a6814925e7@redhat.com> Date: Mon, 30 Jun 2025 13:16:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/4] mm: remove boolean output parameters from folio_pte_batch_ext() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-5-david@redhat.com> <997a3af4-0c8f-4f8d-8230-08b43d0761b6@redhat.com> <4500541c-dde1-41a7-81c8-ac1573d05419@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4500541c-dde1-41a7-81c8-ac1573d05419@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zHzCs1okC7Zx3biyrrJZK6t6nuafhLWyAYx-kEQp8Nk_1751282215 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4idwa8yd8pmjewsj1puduxwnz8x9j4yq X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 34428140004 X-Rspam-User: X-HE-Tag: 1751282218-186734 X-HE-Meta: U2FsdGVkX18HVXXou8gJAtCJd5AgLGupZRPbsQdy5pfHWVgk9GK5AtO9YTy+UK20XEeWWTdFH2SB3eQrZjVDGO3eaUUJIA2lUQTvhCppw6rXLfpWOXm1jCc14xdrxQb5KNrk12Z0HuggRssu72LNM7QjFlnbgJwEekeJcnRL54L+7OlkFA+vLYx1IgyFMH+CUIRPqq92je9r7Rnc3HL9RytH0JNpCalcrka7psJ7FF8RNFYZ5WPGh9W8rECE4Mh7Y6LJjazjsT65nmTeUO27ZYj4LdwGl9UrBIJy7dgAi4kOy0PqYJwj/cRMVcAFN+8iD4kK3rTTZsgB7PD2zGN5Q88Kw7eoFlFMS8LzyiE47wQxnLFGRD0j6FLV16Dgi9p12JkliQJPYuxJhxbqgCWHmfS+Gu4Ni68Pv7PdER9lRCmoiKmdjdqrEJCGDKdJQ+LTW4Dhu3ZxDDw+OBpTPrpwemc7I9FgM046a+hPWsgWNTYCD+Z9a6sR1mB0k1cGuaRSD8shpDT+1na+m+eCvAAD7pq5eUAU5zeCI53Sskt5qCmNMgstUUPvq1qdv8FXLDyejD3e06k38aWkQAegRjZi0agDrK0O5iOjrgO4CHQYHndNcAp2eajd+22H8S90RUs9wufbYDZ1LRFH+iu4Wg+0Icz/hztP9G0H2T+p1nQZDcTRooz8m0BgTyXPLr829iWF2V/NkpfXGy6kB/zmqJuZZVdSucKpyFQXZjRFWUWTua+d3cdVqfCEyOKu/Qa9YZfMExv/Xwq8yiI4TYLsmkfEHhfp0GNuRpsSbnHMvhnpM9IyGpx8LS6OfNfcLvf42rIQduCI2K06eghWp1kxrabi/U0XACYvMHON9JhQe2DqVUK74h+ba/8QnWP9H9CABYUCcQrZyCYxSxLklqmhJNS4DcE28Lto9eNbaxwS37n2bvzmh5lI/e7/SViIgD9zxy7aJmWnTsaCNfT8runEYA6 s4YpECIO 9H1K0rpbo9jlm0RBMQNFIwO0XU5XZOpKlJ5Cxj7RFQAWLHIHiWNY8F9IHmZSTCLgv4yIsO4ENY6TEAFvoRMLWRrPnVifEfCtpAyscZ+20K/PsFOfO7z2v76pMcvork2viVK/iXViszngqRT/i7OYvPaR7RWNbYnv5+/A21Drr911mP37hAeeVnlPjRE6rpxtY/oNXAj6GIIqLCdEipl+zM5CUzYwQxvJ7x91edO7jYrXJZ0CYvVxhQlOAUQOC/e7BWi61cZCbq4c8XqDn5xB9dY2W5jKnN1CwQRREeVPOnW2ruH/cWvclhPHLFivkgaGphQT6BJ5EaKPuz3AxnW5x8pagOLkG2uZOucn0iYT1wf1mY0SV8smlH4J0xyMO1GzTORhFjM4NMg0xzy5enme0b8hfUOq5DjM/TJLapnzrCEhl2RSmOSA6F7+YL0uYs0BxFITbm887UQFHIFzKyx3CkQ7eMFZQXfRQNqfi7jKmidm8YAaaUqFkTGK/WKyoIYfP1TWNDKmlRQslKlLgJPC0j6aB3sGt7tgFEPP1lejIH1SboeueUplYkTGLY4r6ZJ5aET5LZWD8IawWM8I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > @ptentp: Pointer to a COPY of the first page table entry whose flags we update > if appropriate. + * @ptentp: Pointer to a COPY of the first page table entry whose flags this + * function updates based on @flags if appropriate. > > And then update the description of folio_pte_batch_flags() both the brief one to > add 'updates ptentp to set flags if appropriate' and maybe in the larger > description bit. Not in the brief one; the other description, including the excessive parameter doc will be enough. FWIW, I briefly though passing in an arg struct, or returning the pte instead (and returning the nr_pages using a parameter), but hated both. More than these two stupid pte*. > >> >> [...] >> >>>> VM_WARN_ON_FOLIO(!pte_present(pte), folio); >>>> VM_WARN_ON_FOLIO(!folio_test_large(folio) || max_nr < 1, folio); >>>> VM_WARN_ON_FOLIO(page_folio(pfn_to_page(pte_pfn(pte))) != folio, folio); >>>> + VM_WARN_ON(virt_addr_valid(ptentp) && PageTable(virt_to_page(ptentp))); >>> >>> Hm so if !virt_addr_valid(ptentp) we're ok? :P >> >> I had the same question when writing that. Obviously, >> PageTable(virt_to_page(ptentp)) faulted when called on something on the >> stack. (ran into that ... :) ) >> >> Maybe "VM_WARN_ON(virt_addr_valid(ptentp));" would work as well, but I am >> not sure how that function behaves on all architectures ... > > Well you wouldn't want to limit callers to only working on stack values... > > I guess just add a comment, or rather update the the one below to something like: > > /* > * Ensure this is a pointer to a copy not a pointer into a page table. > * If this is a stack value, it won't be a valid virtual address, but that's > * fine because it also cannot be pointing into the page table. > */ > > Which would clarify. Yes, I'll use that, thanks. -- Cheers, David / dhildenb