linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@01.org, Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [next:master 6096/6547] fs/nilfs2/btree.c:1611 nilfs_btree_seek_key() warn: impossible condition '(start > (~0)) => (0-u64max > u64max)'
Date: Wed, 25 Mar 2015 22:26:25 +0900	[thread overview]
Message-ID: <5512B781.1070607@lab.ntt.co.jp> (raw)
In-Reply-To: <20150324084823.GB16501@mwanda>

Hi,

On 2015/03/24 17:48, Dan Carpenter wrote:
> [ I suppose this is intentional but this is the first time
>    NILFS_BTREE_KEY_MAX has been used since it was introduced in 2009 so
>    it's strange. - dan ]
>
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   50d4d7167355e3ffa6e0a759e88cd277e58a5cb9
> commit: 6c302a8684cd06a7ec985fb23f31fa8f3f210eef [6096/6547] nilfs2: add bmap function to seek a valid key
>
> fs/nilfs2/btree.c:1611 nilfs_btree_seek_key() warn: impossible condition '(start > (~0)) => (0-u64max > u64max)'
>
<snip>
> 6c302a86 Ryusuke Konishi 2015-03-20  1604  static int nilfs_btree_seek_key(const struct nilfs_bmap *btree, __u64 start,
> 6c302a86 Ryusuke Konishi 2015-03-20  1605  				__u64 *keyp)
> 6c302a86 Ryusuke Konishi 2015-03-20  1606  {
> 6c302a86 Ryusuke Konishi 2015-03-20  1607  	struct nilfs_btree_path *path;
> 6c302a86 Ryusuke Konishi 2015-03-20  1608  	const int minlevel = NILFS_BTREE_LEVEL_NODE_MIN;
> 6c302a86 Ryusuke Konishi 2015-03-20  1609  	int ret;
> 6c302a86 Ryusuke Konishi 2015-03-20  1610
> 6c302a86 Ryusuke Konishi 2015-03-20 @1611  	if (start > NILFS_BTREE_KEY_MAX)
> 6c302a86 Ryusuke Konishi 2015-03-20  1612  		return -ENOENT;

Thanks.  This check is actually meaningless.
Will fix it.

Regards,
Ryusuke Konishi


> 6c302a86 Ryusuke Konishi 2015-03-20  1613
> 6c302a86 Ryusuke Konishi 2015-03-20  1614  	path = nilfs_btree_alloc_path();
> 6c302a86 Ryusuke Konishi 2015-03-20  1615  	if (!path)
> 6c302a86 Ryusuke Konishi 2015-03-20  1616  		return -ENOMEM;
> 6c302a86 Ryusuke Konishi 2015-03-20  1617
> 6c302a86 Ryusuke Konishi 2015-03-20  1618  	ret = nilfs_btree_do_lookup(btree, path, start, NULL, minlevel, 0);
> 6c302a86 Ryusuke Konishi 2015-03-20  1619  	if (!ret)
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2015-03-25 13:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24  8:48 Dan Carpenter
2015-03-25 13:26 ` Ryusuke Konishi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5512B781.1070607@lab.ntt.co.jp \
    --to=konishi.ryusuke@lab.ntt.co.jp \
    --cc=dan.carpenter@oracle.com \
    --cc=kbuild@01.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox