From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by kanga.kvack.org (Postfix) with ESMTP id D838A6B006E for ; Mon, 16 Mar 2015 16:49:09 -0400 (EDT) Received: by pdbni2 with SMTP id ni2so68312606pdb.1 for ; Mon, 16 Mar 2015 13:49:09 -0700 (PDT) Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com. [210.118.77.14]) by mx.google.com with ESMTPS id e6si24728061pdo.202.2015.03.16.13.49.08 for (version=TLSv1 cipher=RC4-MD5 bits=128/128); Mon, 16 Mar 2015 13:49:08 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NLB00GGLOODXX30@mailout4.w1.samsung.com> for linux-mm@kvack.org; Mon, 16 Mar 2015 20:53:01 +0000 (GMT) Message-id: <550741BD.9080109@partner.samsung.com> Date: Mon, 16 Mar 2015 23:49:01 +0300 From: Stefan Strogin MIME-version: 1.0 Subject: Re: [PATCH v4 1/5] mm: cma: add trace events to debug physically-contiguous memory allocations References: In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Joonsoo Kim , Andrew Morton , Marek Szyprowski , Michal Nazarewicz , aneesh.kumar@linux.vnet.ibm.com, Laurent Pinchart , Dmitry Safonov , Pintu Kumar , Weijie Yang , Laura Abbott , SeongJae Park , Hui Zhu , Minchan Kim , Dyasly Sergey , Vyacheslav Tyrtov , Aleksei Mateosian , gregory.0xf0@gmail.com, sasha.levin@oracle.com, gioh.kim@lge.com, pavel@ucw.cz, stefan.strogin@gmail.com, Steven Rostedt , Ingo Molnar Oops... forgot to cc tracing maintainers. Sorry! On 16/03/15 19:06, Stefan Strogin wrote: > Add trace events for cma_alloc() and cma_release(). > > Signed-off-by: Stefan Strogin > --- > include/trace/events/cma.h | 57 ++++++++++++++++++++++++++++++++++++++++++++++ > mm/cma.c | 5 ++++ > 2 files changed, 62 insertions(+) > create mode 100644 include/trace/events/cma.h > > diff --git a/include/trace/events/cma.h b/include/trace/events/cma.h > new file mode 100644 > index 0000000..d88881b > --- /dev/null > +++ b/include/trace/events/cma.h > @@ -0,0 +1,57 @@ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM cma > + > +#if !defined(_TRACE_CMA_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_CMA_H > + > +#include > +#include > + > +TRACE_EVENT(cma_alloc, > + > + TP_PROTO(struct cma *cma, struct page *page, int count), > + > + TP_ARGS(cma, page, count), > + > + TP_STRUCT__entry( > + __field(struct page *, page) > + __field(unsigned long, count) > + ), > + > + TP_fast_assign( > + __entry->page = page; > + __entry->count = count; > + ), > + > + TP_printk("page=%p pfn=%lu count=%lu", > + __entry->page, > + __entry->page ? page_to_pfn(__entry->page) : 0, > + __entry->count) > +); > + > +TRACE_EVENT(cma_release, > + > + TP_PROTO(struct cma *cma, unsigned long pfn, int count), > + > + TP_ARGS(cma, pfn, count), > + > + TP_STRUCT__entry( > + __field(unsigned long, pfn) > + __field(unsigned long, count) > + ), > + > + TP_fast_assign( > + __entry->pfn = pfn; > + __entry->count = count; > + ), > + > + TP_printk("pfn=%lu page=%p count=%lu", > + __entry->pfn, > + pfn_to_page(__entry->pfn), > + __entry->count) > +); > + > +#endif /* _TRACE_CMA_H */ > + > +/* This part must be outside protection */ > +#include > diff --git a/mm/cma.c b/mm/cma.c > index 47203fa..63dfc0e 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -23,6 +23,7 @@ > # define DEBUG > #endif > #endif > +#define CREATE_TRACE_POINTS > > #include > #include > @@ -34,6 +35,7 @@ > #include > #include > #include > +#include > > #include "cma.h" > > @@ -414,6 +416,8 @@ struct page *cma_alloc(struct cma *cma, unsigned int count, unsigned int align) > start = bitmap_no + mask + 1; > } > > + trace_cma_alloc(cma, page, count); > + > pr_debug("%s(): returned %p\n", __func__, page); > return page; > } > @@ -446,6 +450,7 @@ bool cma_release(struct cma *cma, const struct page *pages, unsigned int count) > > free_contig_range(pfn, count); > cma_clear_bitmap(cma, pfn, count); > + trace_cma_release(cma, pfn, count); > > return true; > } > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org