From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A04FFC021A0 for ; Thu, 13 Feb 2025 11:23:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28CBA6B0085; Thu, 13 Feb 2025 06:23:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F1A76B0088; Thu, 13 Feb 2025 06:23:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0E8C6B0089; Thu, 13 Feb 2025 06:23:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D11B66B0085 for ; Thu, 13 Feb 2025 06:23:16 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 87DE4120C4C for ; Thu, 13 Feb 2025 11:23:16 +0000 (UTC) X-FDA: 83114685192.07.3A8E834 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id CC3AE20013 for ; Thu, 13 Feb 2025 11:23:14 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of steven.price@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=steven.price@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739445794; a=rsa-sha256; cv=none; b=s8KZN8WmfsQWRGLTVSXtkDIevfoCLse3ZBOI0Tp4N360YEUnm4MjvmO9PK80emAauNdEbG MtG6QiRlfsway3g/qYYp15VVnp42G4VNZJIGoZIxduKv3qA+aICmwa04PrVFVAwTuwuQDu D8lAHaDqEhZnO4nTwQRyo7mOy3mHnr0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of steven.price@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=steven.price@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739445794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bx8L+fEhoak9M81sLmQlt1yInYLp0VEidX6HAM3zf8o=; b=TkmNs6zYet+gULHCGlrKMrVeqspp7WfoL7E0u/SlrD70E+U7WWHrl0jXdTgtYIocI2o1fl YtNfxoFLfdXDYVsEPeNILhsR4AFD9YGTP25nolYCxaf61kbDeDbuJDAuoK9c/ShEb7Ymoz 5rzvZj3eFevMr49DDnBRVoOlnPxGHo0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A4A621756; Thu, 13 Feb 2025 03:23:34 -0800 (PST) Received: from [10.1.32.44] (e122027.cambridge.arm.com [10.1.32.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 58D143F6A8; Thu, 13 Feb 2025 03:23:12 -0800 (PST) Message-ID: <5504fadd-6174-41c4-90a8-d3ae7f76d7f6@arm.com> Date: Thu, 13 Feb 2025 11:23:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm: Make GENERIC_PTDUMP dependent on MMU To: Anshuman Khandual , linux-mm@kvack.org Cc: christophe.leroy@csgroup.eu, Paul Walmsley , Palmer Dabbelt , Andrew Morton , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250213040934.3245750-1-anshuman.khandual@arm.com> <20250213040934.3245750-4-anshuman.khandual@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20250213040934.3245750-4-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CC3AE20013 X-Stat-Signature: wf6qd437sd1dx9i4konfj8aeroocdmx9 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739445794-319793 X-HE-Meta: U2FsdGVkX198Cr+09dxGiybeMOSNqSP7RDB1w1+ZdVqeFfgnjjFZ8vFSSkfuDZ34zFcNy+8YdoxxsE+aqaVjfkiDn7rAjSmnQBUQhNcVNkkiHqkf7szzbvuw3vGEQmfrM83wY3pwU/FMh65n90/0qglbfxTsO0GMtt/9gskxTkYsTEat7cmwuueGvpkLR7vT4w44zrgmVMw8XREt1DMIjnPDeJKE/NUfPaquRZ51e8+Mkg5SHHdOnvXWvgqfmSCr/SGMExNH226O5b2/JGcdOaQgaizAWybnS5gFri+lZhsM+T8VoNiY+4DQcYlIy+RTBZ/7Dw53sFycDyvERpC06IhEQpqX7CiQzNLHiv8vvdmtQlUviUKrx0o81kmwXl/cInQ6nB1eQfkHVwZ2G7N8kk7rPDcOggXQQK9pOFo4tjDiK8YaXoX+JoeEiJseu+1jJJfYV0uKMivYf4+mNpEv5KwHyBVrMq36pkzFPvBJLIxszHMtxuwAOCGsErxhFq52vN6nCS1LLI768pW7S/s16RvjFZvc20DDFjEwo9bXpbbBC28rBp4D39pdLnVsgPt7p+Gb1y5zdEC/ucVQryM8yb+h8FPi7+5JLLfK5+txk2/AaOE7TBAwaBXqaCi1VnTqSqAx1+55KfXr5cOc7ucel1vBY5uf8w5F3lZrHsBT/X/DgnZwMU8ISEOF4YaJMfosFQ77p7NH+dTxC8RvrSJd2AhAbSFtwEppErRWe3sQD812L8fJjba5DQl8qy5Ubdfl+WzpPc40dWDtNTypfoXmiDGU4F4BkH5jyll9XryEGJ4OU64q/7apIZmLJc5/gvnuyJud6DAtviSfqLxRjA7k6YCVoZjkL5OLwHmpRSsoOiv5GadwVNMWODav3PzdfKc1Zgx9Vuhu2EzyZtA74Jmm/1+SUn+1oXDAQ3k3O5MTbBVb8fQr/sDWMUyLRq3A4KsCR659Thl0q5k2xNtFo5z HiNQnWiD 3ee86KhydxWKkHwWGr3NiZo0/KFaUfZOybmaNjOBhVcprCaJMAQTDtI1LPEBCC0FfaDLh0rXbPT/2lYUQz2iQA5hOX5p1UoIf/qq57Zi2hgzemWVCIobw5ReeZzdxivz1ZFUkVwSoya5HomJGJP3OhjdFe4cslI7eYfcYhOX8r1sA2aC4AExmoaMAKMGZMoTP1eCCEQShoaDnGQlhMJzrb57JPnmHLpCtPU7IhxjELQRjv0cVaO3Pgk8l+iokf5Y515CCaatNhAj0s/omgPh0Uw6Zk6gmCcc0i+9tU9Q1yvktREAkDsOnXNJj3kaRNY1h8RKJw3L0ps997NBRrULiqmiaIbvTppR1YQ8dW2heAdNGXuPtazLtjHiH6EEfEK45/k7WPiEL9GnD1aPjPOUEjhzauOF0fDVqlQH+uNAiy2Osa4QphgMGg20asZDhq0IW/98XDTC5nSBymHdbZEOLaqx17MhJkoIZjPCX578AWjMyo+o7DNNe3ITS5VOnRYxKIYtsc7dY2Zx9tCejz3w9pzBmlY8EoDY1ivbg81jfahN0Cjs47MCoF3UA22A/dXCeliMm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13/02/2025 04:09, Anshuman Khandual wrote: > There is no page table dump without a MMU. Make this dependency at generic > level and drop the same from riscv platform instead. > > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Andrew Morton > Cc: linux-riscv@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > Signed-off-by: Anshuman Khandual As Christophe has pointed out - this is broken. The select will override the dependency you've added in GENERIC_PTDUMP. Generally have "depends on" for symbols that are "select"ed is broken. I'd suggest just dropping this patch. Steve > --- > arch/riscv/Kconfig | 2 +- > mm/Kconfig.debug | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 7612c52e9b1e..c4cdba6460b8 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -112,7 +112,7 @@ config RISCV > select GENERIC_IRQ_SHOW_LEVEL > select GENERIC_LIB_DEVMEM_IS_ALLOWED > select GENERIC_PCI_IOMAP > - select GENERIC_PTDUMP if MMU > + select GENERIC_PTDUMP > select GENERIC_SCHED_CLOCK > select GENERIC_SMP_IDLE_THREAD > select GENERIC_TIME_VSYSCALL if MMU && 64BIT > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > index a51a1149909a..c08406760d29 100644 > --- a/mm/Kconfig.debug > +++ b/mm/Kconfig.debug > @@ -214,6 +214,7 @@ config DEBUG_WX > If in doubt, say "Y". > > config GENERIC_PTDUMP > + depends on MMU > bool > > config PTDUMP_CORE