From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F917C25B75 for ; Mon, 3 Jun 2024 21:05:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF3A06B009A; Mon, 3 Jun 2024 17:05:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA2D56B009B; Mon, 3 Jun 2024 17:05:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1C4E6B009C; Mon, 3 Jun 2024 17:05:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 907E36B009A for ; Mon, 3 Jun 2024 17:05:52 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4498B1A0513 for ; Mon, 3 Jun 2024 21:05:52 +0000 (UTC) X-FDA: 82190809344.26.3A14D68 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id F1CD71C0009 for ; Mon, 3 Jun 2024 21:05:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fQVtYwdh; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717448750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UJgT/cnaSQmGF8SBb4Dtq0AmHEbwAi/yOwU2N8vRP3I=; b=uzIjHGYioAGgWt64klj/Ny1Kk9JhnJlSFHIWJMNV1xKwadvtppNrPWHgc2b0mZgMBqG/oD z1yTojtrMrXzscF84KW95/KI0MimVoo1yqyMkCaligpQSuwdK3nGLYasrcBDsRHanflTfB OjU5ktuToNEoBl1LPp1PgSUTLasHk7k= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fQVtYwdh; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717448750; a=rsa-sha256; cv=none; b=yyd32kVbSTy7jPDPioOpmp7hDxnZyoGkG41ASYpcczPKeXY1YTBkYA54lXc2F5ZdPCIsvg U5P4y+NHl4rQFfLAEvnvNbBlOPU8klgOgaWxbC+3hUcYL0jfjcveRRRiMXmChvhnZkd4Xa nX05SnowauDJlgL8roqkKel0jCoFK+E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717448749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UJgT/cnaSQmGF8SBb4Dtq0AmHEbwAi/yOwU2N8vRP3I=; b=fQVtYwdhKUYSEHt4w/q5qTr7HSFBNL+fV0VrqFP//CT7u9J0tLZw3H2n96zGk5phOOowYU XI5TscZkqTu7aqP2raHIL+GnK8OV5YU8F+j7n3WzV/a2/11ZEnVor+PHBUpF1uMzgwEJCV F5St0rU+GhWBacfDR/73fpPi3LfQV2M= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-YQ79bhJxNRuyLv8LOARF2g-1; Mon, 03 Jun 2024 17:05:47 -0400 X-MC-Unique: YQ79bhJxNRuyLv8LOARF2g-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-52b99933b68so1122530e87.3 for ; Mon, 03 Jun 2024 14:05:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717448746; x=1718053546; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UJgT/cnaSQmGF8SBb4Dtq0AmHEbwAi/yOwU2N8vRP3I=; b=VCrzfDAW1rbpGG1MlVEBowqsQkO5C10Bx+ec2fHlFQujHzPQke7JmSR+YZyKFEh4Qd uISMtgObXG2wFtCB/9Xw8BDn3Hi/HOgyAu4HMLfNGQsEQXWv7d6ecDOk36BW2wAGcJWy fQfP0LeWqeeHw48TdlVW59PKH62/mpaYvBy7JFSmomMmb92plqR/XjUgtngHXn/KImRG yjrUN91aNpMBvUC2cV9i0mUZXioM4r6lQI0SAZ0GmzIU8cdTbrPDX1nmXkw+WkN7e+BF G5/AKf+gSN6NXvsenYPzw4ywKc8H6wjGjNmdLk///PgxfqWuW4bhZzedl5D/nhvohDTF 9/lw== X-Forwarded-Encrypted: i=1; AJvYcCVpHJrHH6xCRhzEaIv1Vn2W4kSaGiTaVeUcWqCC8CjX0Ww4QjbEUUu7Qq5hnoUcbSTfCjGZR/MQu9fFsySuniiKH1I= X-Gm-Message-State: AOJu0YyAwsKofGHXOlgvslU/jVlsEUH82YyDORudZd8o9ypCKQ50Q6dc zRPe9M3VbljgZXboEqRL5tIEh79FG1lqPOZ7tYBP88ynT3Z6YloikKMj02LJG7uGbSYv6mmtMxW bxDbjYQljuCd6yz1fm3Dqy/zzuVAtT1oqIqGXpmXuDwa6AUpu X-Received: by 2002:a05:6512:74c:b0:52b:38e8:db1b with SMTP id 2adb3069b0e04-52b896d9161mr6109886e87.65.1717448746217; Mon, 03 Jun 2024 14:05:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdTIf5KUUYaY5/SyxKEFIs98LowwF7Wk0ISgtF/E057yLZw7OKYCTsublUCEwZIh564M28Kw== X-Received: by 2002:a05:6512:74c:b0:52b:38e8:db1b with SMTP id 2adb3069b0e04-52b896d9161mr6109870e87.65.1717448745790; Mon, 03 Jun 2024 14:05:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c731:3d00:918f:ce94:4280:80f0? (p200300cbc7313d00918fce94428080f0.dip0.t-ipconnect.de. [2003:cb:c731:3d00:918f:ce94:4280:80f0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04cb1e7sm9742014f8f.43.2024.06.03.14.05.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 14:05:45 -0700 (PDT) Message-ID: <54ce029f-b16f-4607-bdf1-a1efe904029a@redhat.com> Date: Mon, 3 Jun 2024 23:05:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linus:master] [mm] efa7df3e3b: kernel_BUG_at_include/linux/page_ref.h To: Peter Xu Cc: Yang Shi , kernel test robot , Jason Gunthorpe , Vivek Kasireddy , Rik van Riel , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , Christopher Lameter , linux-mm@kvack.org, "Paul E . McKenney" References: <890e5a79-8574-4a24-90ab-b9888968d5e5@redhat.com> <0edfcfed-e8c4-4c46-bbce-528c07084792@redhat.com> <8da12503-839d-459f-a2fa-4abd6d21935d@redhat.com> <9d9a5730-161b-4a9d-a696-1cf6d0c5123c@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: F1CD71C0009 X-Stat-Signature: nyjpncznfugzad8p43mdg8rowyr1zm75 X-HE-Tag: 1717448749-208337 X-HE-Meta: U2FsdGVkX1/1w4ozIkp6/ZR0Am6QJX5um3r7rzxy2kEZFv8MksmhfzTpEiIH6SQI/MOgbZ6106kd23Z/EN9it6t4QMg/SSXKys53UH7H5OxHdoF1EPI6wpzq4OKmXrAtQp/XKmKctRo4o5lQoCdz53EJJCD0yfH9+dSulNjJ29FvfOjgRpNnDROr2FhQsBQ/E5iw8UwzoogSH+7p9d7gqxT1n5hn1ooyakOjI/sVJa+3ILZRuO4ALa5RHWbA/x6l9y/qHzrZI/9eQ6usdRhhGUbPD8epDpmjorYPZoonIo74/Mn47WnIMhrox1PV9TqqJ7BK96ohv2IBDrqVZ2bppeFkUWotmO7W/t7qU8hMcLY3h4Ivr2mJvFAXRHEh5wR2jtVx7B4avwD3J9B2lHplbnaE+jHM/vYM/914dHF2BsrDvz+G1avSl5ZcICrtnz0mvUOlyPSI+LLh+EzmDdCK0iZSz1hoBct9zZ93lV56w2DNCjdd/le9NE561fbTgDo2vxlZbh9o4jqvfADCbEFaMcBG6JUARyw3wI9it/w7UqdhZpkcEZKM70tshkQ9KyAPTQehMqFiMkI8TpUhnfTs4Axrt69cxG7AszMRt3497+rIH0Z2RPzWjXhkwSoQSb9ln5CDLBty5l8Kj8GrP0SKkXEffuy93s22yX5ZElhD3YBBH+OFpB6K906nK+cBMnOzS7hIzjF4BGsmnF20o/ZMq+14MP6UhRboWQ6DGQCEWeIDIKkXVtg4VZuZ4j+iwGxU9K7ISkiVHPz+nYrzVwhStAjxi8ry3fmMD3w9DGr2fwdKIG0fkeN/NTnkdDOr39p4wNIOfgRpgbQFdmSkejO6tdegTxFGKlTDU7TsKpuInJ1CrmWbq+yhK4aWr+w8McUNPIEU0FpcJDmyzMwTrFtovra2MUwztlprzTrlkZ1g2S5Ej9tERmnRDpGZrcWW9QOQRzyEzTvmfKMtjQwozsq rociNL2p wis7S7btLRH2V0a61yPeHVBuRX1a9HeRkOxh9QaeE4KNcjao27xoMwQjQBVsKThQMe+3hkK0LyjRm+nBXTCM36473XAuYILG8lmnHWzhyM1QFUg1NGwZa2gPypr8x7WkDTlq3fZ1OIXv9W4Jq44vE/JzPDmj1ISXiZB9B9K8JTU8NEZqtDJyAGHIdeHHnWGkF1reM6bAzE1KqbOrge0KD0ZXqdvonOzOBq6ma/yI9kTfoYm5YbHB4dhTDE3u0sgwe0bfB4QfZHbUbQU2O4F+bxr2b6THazWI1breYhzg9V1IRaNDHHunJ9k7uQ4KbbYoiB+ZEdS2MKyFQ4fNjmeIkU1LrpQB+GkxX85jv8f6gdqsg2ErJgfWIwwfYrOi0RXVEQb4mgauDZy9412CRrq9a80ZYEnjcFnBrsyJv14Rg6yhzhBW8mCixwAK0iX2qJ+QK9kPy0bIXzSjXz9UHlYJZZEKsd8oOjRwSy7hk/3TyocpGxU7Nv8do3VtcHn+a5gu4BxwMaxXRXurGXy6de3IexSCK92QdQIdkFKngTq0ng+wbfxoMxedDo6iomVICfIFxYvUftv8jard2GJ3GKMIMQU2FyibP+WTahJgZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.24 23:03, Peter Xu wrote: > On Mon, Jun 03, 2024 at 10:37:55PM +0200, David Hildenbrand wrote: >>>> try_get_folio() is all about grabbing a folio that might get freed >>>> concurrently. That's why it calls folio_ref_try_add_rcu() and does >>>> complicated stuff. >>> >>> IMHO we can define it.. e.g. try_get_page() wasn't defined as so. >>> >>> If we want to be crystal clear on that and if we think that's what we want, >>> again I would suggest we rename it differently from try_get_page() to avoid >>> future misuses, then add documents. We may want to also even assert the >> >> Yes, absolutely. >> >>> rcu/irq implications in try_get_folio() at entrance, then that'll be >>> detected even without TINY_RCU config. >>> >>>> >>>> On !CONFIG_TINY_RCU, it performs a folio_ref_add_unless(). That's >>>> essentially a atomic_add_unless(), which in the worst case ends up being a >>>> cmpxchg loop. >>>> >>>> >>>> Stating that we should be using try_get_folio() in paths where we are sure >>>> the folio refcount is not 0 is the same as using folio_try_get() where >>>> folio_get() would be sufficient. >>>> >>>> The VM_BUG_ON in folio_ref_try_add_rcu() really tells us here that we are >>>> using a function in the wrong context, although in our case, it is safe to >>>> use (there is now BUG). Which is true, because we know we have a folio >>>> reference and can simply use a simple folio_ref_add(). >>>> >>>> Again, just like we have folio_get() and folio_try_get(), we should >>>> distinguish in GUP whether we are adding more reference to a folio (and >>>> effectively do what folio_get() would), or whether we are actually grabbing >>>> a folio that could be freed concurrently (what folio_try_get() would do). >>> >>> Yes we can. Again, IMHO it's a matter of whether it will worth it. >>> >>> Note that even with SMP and even if we keep this code, the >>> atomic_add_unless only affects gup slow on THP only, and even with that >>> overhead it is much faster than before when that path was introduced.. and >>> per my previous experience we don't care too much there, really. >>> >>> So it's literally only three paths that are relevant here on the "unless" >>> overhead: >>> >>> - gup slow on THP (I just added it; used to be even slower..) >>> >>> - vivik's new path >>> >>> - hugepd (which may be gone for good in a few months..) >>> IMHO none of them has perf concerns. The real perf concern paths is >>> gup-fast when pgtable entry existed, but that must use atomic_add_unless() >>> anyway. Even gup-slow !thp case won't regress as that uses try_get_page(). >> >> My point is primarily that we should be clear that the one thing is >> GUP-fast, and the other is for GUP-slow. > > Yes, understood. > >> >> Sooner or later we'll see more code that uses try_grab_page() to be >> converted to folios, and people might naturally use try_grab_folio(), just >> like we did with Vivik's code. >> >> And I don't think we'll want to make GUP-slow in general using >> try_grab_folio() in the future. >> >> So ... >> >>> >>> So again, IMHO the easist way to fix this WARN is we drop the TINY_RCU bit, >>> if nobody worries on UP perf. >>> >>> I don't have a strong opinion, if any of us really worry about above three >>> use cases on "unless" overhead, and think it worthwhile to add the code to >>> support it, I won't object. But to me it's adding pain with no real benefit >>> we could ever measure, and adding complexity to backport too since we'll >>> need a fix for as old as 6.6. >> >> ... for the sake of fixing this WARN, I don't primarily care. Adjusting the >> TINY_RCU feels wrong because I suspect somebody had good reasons to do it >> like that, and it actually reported something valuable (using the wrong >> function for the job). >> >> In any case, if we take the easy route to fix the WARN, I'll come back and >> clean the functions here up properly. > > Definitely, then there can also be some measurements which will be even > better. I mean, if the diff is minimal, we can be clearer on the path we > choose; while if it shows improvements we have more solid results than > predictions and discussions. > > Yes I do worry about the UP change too, hence I sincerely was trying to > collect some feedback. My current guess is the UP was still important in > 2008 when the code first wrote, and maybe it changed over the 16 years. I > just notice Nicolas wrote it; I know he's still active so I've added him > into the loop too. > > Just for easier reference, the commit introduced the UP change is: > > commit e286781d5f2e9c846e012a39653a166e9d31777d > Author: Nicholas Piggin > Date: Fri Jul 25 19:45:30 2008 -0700 > > mm: speculative page references > > +static inline int page_cache_get_speculative(struct page *page) > +{ > + VM_BUG_ON(in_interrupt()); > + > +#if !defined(CONFIG_SMP) && defined(CONFIG_CLASSIC_RCU) > +# ifdef CONFIG_PREEMPT > + VM_BUG_ON(!in_atomic()); > +# endif > + /* > + * Preempt must be disabled here - we rely on rcu_read_lock doing > + * this for us. > + * > + * Pagecache won't be truncated from interrupt context, so if we have > + * found a page in the radix tree here, we have pinned its refcount by > + * disabling preempt, and hence no need for the "speculative get" that > + * SMP requires. > + */ > + VM_BUG_ON(page_count(page) == 0); > + atomic_inc(&page->_count); > + > +#else > + if (unlikely(!get_page_unless_zero(page))) { > + /* > + * Either the page has been freed, or will be freed. > + * In either case, retry here and the caller should > + * do the right thing (see comments above). > + */ > + return 0; > + } > +#endif > + VM_BUG_ON(PageTail(page)); > + > + return 1; > +} > > Thanks, > I chased it further to: commit 8375ad98cc1defc36adf4a77d9ea1e71db51a371 Author: Paul E. McKenney Date: Mon Apr 29 15:06:13 2013 -0700 vm: adjust ifdef for TINY_RCU There is an ifdef in page_cache_get_speculative() that checks for !SMP and TREE_RCU, which has been an impossible combination since the advent of TINY_RCU. The ifdef enables a fastpath that is valid when preemption is disabled by rcu_read_lock() in UP systems, which is the case when TINY_RCU is enabled. This commit therefore adjusts the ifdef to generate the fastpath when TINY_RCU is enabled. Where Paul explicitly restored that fastpath for TINY_RCU instead of removing that code. So maybe Paul can comment if that is still worth having. CCing him. -- Cheers, David / dhildenb